diff options
| author | Russ Cox <rsc@golang.org> | 2015-06-05 11:01:53 -0400 |
|---|---|---|
| committer | Russ Cox <rsc@golang.org> | 2015-06-16 18:07:36 +0000 |
| commit | 7bc3e5880675ce4aae245f46d193924cff5efdfb (patch) | |
| tree | bc5991015f83aa4852edaf31b096fc968c3f6369 /src/cmd/addr2line | |
| parent | 047f07a285edbc60f64018973be7ce6b341fe22d (diff) | |
| download | go-7bc3e5880675ce4aae245f46d193924cff5efdfb.tar.gz go-7bc3e5880675ce4aae245f46d193924cff5efdfb.zip | |
all: extract "can I exec?" check from tests into internal/testenv
Change-Id: I7b54be9d8b50b39e01c6be21f310ae9a10404e9d
Reviewed-on: https://go-review.googlesource.com/10753
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: David Crawshaw <crawshaw@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Diffstat (limited to 'src/cmd/addr2line')
| -rw-r--r-- | src/cmd/addr2line/addr2line_test.go | 17 |
1 files changed, 5 insertions, 12 deletions
diff --git a/src/cmd/addr2line/addr2line_test.go b/src/cmd/addr2line/addr2line_test.go index c83a883b8c..e8234e2da2 100644 --- a/src/cmd/addr2line/addr2line_test.go +++ b/src/cmd/addr2line/addr2line_test.go @@ -7,6 +7,7 @@ package main import ( "bufio" "bytes" + "internal/testenv" "io/ioutil" "os" "os/exec" @@ -85,22 +86,14 @@ func testAddr2Line(t *testing.T, exepath, addr string) { if !os.SameFile(fi1, fi2) { t.Fatalf("addr2line_test.go and %s are not same file", srcPath) } - if srcLineNo != "94" { - t.Fatalf("line number = %v; want 94", srcLineNo) + if srcLineNo != "95" { + t.Fatalf("line number = %v; want 95", srcLineNo) } } -// This is line 93. The test depends on that. +// This is line 94. The test depends on that. func TestAddr2Line(t *testing.T) { - switch runtime.GOOS { - case "nacl", "android": - t.Skipf("skipping on %s", runtime.GOOS) - case "darwin": - switch runtime.GOARCH { - case "arm", "arm64": - t.Skipf("skipping on %s/%s, cannot fork", runtime.GOOS, runtime.GOARCH) - } - } + testenv.MustHaveGoBuild(t) syms := loadSyms(t) |