diff options
| author | Marcel van Lohuizen <mpvl@golang.org> | 2019-02-08 17:57:46 +0100 |
|---|---|---|
| committer | Brad Fitzpatrick <bradfitz@golang.org> | 2019-02-26 22:57:25 +0000 |
| commit | ef954a03eb9d4e8d19e1024db088095110e19a0b (patch) | |
| tree | 2450f4bd960ec418c5b8d4d685efbf995e08f505 /src/bytes | |
| parent | c55eeeb718b0dfd008f0d722c8b8d05f8b02d62b (diff) | |
| download | go-ef954a03eb9d4e8d19e1024db088095110e19a0b.tar.gz go-ef954a03eb9d4e8d19e1024db088095110e19a0b.zip | |
bytes: hoist error creation out of function
generating frame information in errors will cause this
function to no longer be inlined.
Updates #29934.
Change-Id: I1d7bc11707f1872d7315f627bfb9a12afa41e358
Reviewed-on: https://go-review.googlesource.com/c/161760
Run-TryBot: Marcel van Lohuizen <mpvl@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Diffstat (limited to 'src/bytes')
| -rw-r--r-- | src/bytes/buffer.go | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/bytes/buffer.go b/src/bytes/buffer.go index aff2db5084..190c468162 100644 --- a/src/bytes/buffer.go +++ b/src/bytes/buffer.go @@ -385,13 +385,15 @@ func (b *Buffer) UnreadRune() error { return nil } +var errUnreadByte = errors.New("bytes.Buffer: UnreadByte: previous operation was not a successful read") + // UnreadByte unreads the last byte returned by the most recent successful // read operation that read at least one byte. If a write has happened since // the last read, if the last read returned an error, or if the read read zero // bytes, UnreadByte returns an error. func (b *Buffer) UnreadByte() error { if b.lastRead == opInvalid { - return errors.New("bytes.Buffer: UnreadByte: previous operation was not a successful read") + return errUnreadByte } b.lastRead = opInvalid if b.off > 0 { |