diff options
| author | Jason A. Donenfeld <Jason@zx2c4.com> | 2021-06-12 12:34:40 +0200 |
|---|---|---|
| committer | Jason A. Donenfeld <Jason@zx2c4.com> | 2021-06-13 08:17:17 +0000 |
| commit | 24cff0f0444793be81062684c478a3f7ca955499 (patch) | |
| tree | 5b7b86a48d843e83cb1292251822eacdf2a5dc52 /misc | |
| parent | 67b1b6a2e3a405e3e0b5c6a76f702b2a6071c1f0 (diff) | |
| download | go-24cff0f0444793be81062684c478a3f7ca955499.tar.gz go-24cff0f0444793be81062684c478a3f7ca955499.zip | |
cmd/go, misc/cgo: skip test if no .edata
Clang does not produce binaries with an .edata section, even when it
exports symbols properly, so just skip this binutils-specific test for
that case. Later we can rewrite these tests entirely to do something
more robust.
Updates #46719.
Change-Id: I864b3c2d91e66800c55454ae11d4ab1623693d14
Reviewed-on: https://go-review.googlesource.com/c/go/+/327549
Trust: Jason A. Donenfeld <Jason@zx2c4.com>
Run-TryBot: Jason A. Donenfeld <Jason@zx2c4.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Diffstat (limited to 'misc')
| -rw-r--r-- | misc/cgo/testcshared/cshared_test.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/misc/cgo/testcshared/cshared_test.go b/misc/cgo/testcshared/cshared_test.go index 90d8c365e6d..fdc6df9602c 100644 --- a/misc/cgo/testcshared/cshared_test.go +++ b/misc/cgo/testcshared/cshared_test.go @@ -400,7 +400,7 @@ func main() { defer f.Close() section := f.Section(".edata") if section == nil { - t.Fatalf(".edata section is not present") + t.Skip(".edata section is not present") } // TODO: deduplicate this struct from cmd/link/internal/ld/pe.go |