diff options
author | Austin Clements <austin@google.com> | 2014-12-05 09:24:01 -0500 |
---|---|---|
committer | Austin Clements <austin@google.com> | 2014-12-05 09:24:01 -0500 |
commit | e04c8b063fd7d7aaded8e1ff549dbb520038c61e (patch) | |
tree | a19eedb14272aa2ba3073f144b8a0c9184cc67dd /lib | |
parent | 274976f45c9b2c3f9140768b457e9140ea65bfb4 (diff) | |
download | go-e04c8b063fd7d7aaded8e1ff549dbb520038c61e.tar.gz go-e04c8b063fd7d7aaded8e1ff549dbb520038c61e.zip |
[dev.cc] liblink: don't patch jumps to jumps to symbols
When liblink sees something like
JMP x
...
x: JMP y
it rewrites the first jump to jump directly to y. This is
fine if y is a resolved label. However, it *also* does this
if y is a function symbol, but fails to carry over the
relocation that would later patch in that symbol's value. As
a result, the original jump becomes either a self-jump (if
relative) or a jump to PC 0 (if absolute).
Fix this by disabling this optimization if the jump being
patched in is a jump to a symbol.
LGTM=minux
R=rsc, minux
CC=golang-codereviews
https://golang.org/cl/185890044
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions