diff options
| author | Bryan C. Mills <bcmills@google.com> | 2024-01-23 17:08:50 -0500 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2024-01-24 18:06:55 +0000 |
| commit | 749ebaa4460af237f9facbc43af3e055802dc0be (patch) | |
| tree | 28b00edbfdbc21f5bb50cf0215885d2a9534d059 /api | |
| parent | 3330c69476f4d8bca40a9fb6b429a0401f24f2b7 (diff) | |
| download | go-749ebaa4460af237f9facbc43af3e055802dc0be.tar.gz go-749ebaa4460af237f9facbc43af3e055802dc0be.zip | |
net: ignore Dial errors in TestAcceptTimeout
Also use DialContext instead of just Dial so that we can ensure
the call returns before we close the listener.
The Dial in this test is intended to complete before the call to
Accept, but there is no synchronization to ensure that and sometimes
it doesn't happen. That's ok and mostly immaterial to the test, but it
does mean we need to ignore Dial errors (which can happen when the
listener is closed), and we need to be a little more careful about not
dialing a port that may have already been reused by some other test.
Fixes #65240.
Updates #17948.
Change-Id: Ife1b5c3062939441b58f4c096461bf5d7841889b
Reviewed-on: https://go-review.googlesource.com/c/go/+/558175
Reviewed-by: Damien Neil <dneil@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Diffstat (limited to 'api')
0 files changed, 0 insertions, 0 deletions