aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLeon Klingele <git@leonklingele.de>2019-03-02 19:58:13 +0000
committerBenny Siegert <bsiegert@gmail.com>2019-05-22 20:42:35 +0000
commitd307bd4ede254d73412fede200f2ab1d188c3f54 (patch)
tree9bab9ad6b3c0ff45b7503600fbcabae74dc6accc
parent983986f23d81eae6ee202bd31383d04e73187536 (diff)
downloadgo-d307bd4ede254d73412fede200f2ab1d188c3f54.tar.gz
go-d307bd4ede254d73412fede200f2ab1d188c3f54.zip
encoding/gob: properly ignore errors
Change-Id: I8827cef0f57459384329c50c51795350da0ede4b GitHub-Last-Rev: c9ad9e12b5a0fff47c21a8c299b762b64b8c9c7c GitHub-Pull-Request: golang/go#30010 Reviewed-on: https://go-review.googlesource.com/c/go/+/160434 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
-rw-r--r--src/encoding/gob/decgen.go4
-rw-r--r--src/encoding/gob/encgen.go4
2 files changed, 6 insertions, 2 deletions
diff --git a/src/encoding/gob/decgen.go b/src/encoding/gob/decgen.go
index bad4fe5d92..1c31e66625 100644
--- a/src/encoding/gob/decgen.go
+++ b/src/encoding/gob/decgen.go
@@ -185,10 +185,12 @@ func main() {
log.Fatal("source format error:", err)
}
fd, err := os.Create(*output)
- _, err = fd.Write(source)
if err != nil {
log.Fatal(err)
}
+ if _, err := fd.Write(source); err != nil {
+ log.Fatal(err)
+ }
}
func printMaps(b *bytes.Buffer, upperClass string) {
diff --git a/src/encoding/gob/encgen.go b/src/encoding/gob/encgen.go
index 0c051d2e84..409b8c9d95 100644
--- a/src/encoding/gob/encgen.go
+++ b/src/encoding/gob/encgen.go
@@ -164,10 +164,12 @@ func main() {
log.Fatal("source format error:", err)
}
fd, err := os.Create(*output)
- _, err = fd.Write(source)
if err != nil {
log.Fatal(err)
}
+ if _, err := fd.Write(source); err != nil {
+ log.Fatal(err)
+ }
}
func printMaps(b *bytes.Buffer, upperClass string) {