diff options
| author | Brad Fitzpatrick <bradfitz@golang.org> | 2016-01-27 13:18:35 -0800 |
|---|---|---|
| committer | Brad Fitzpatrick <bradfitz@golang.org> | 2016-01-27 21:33:50 +0000 |
| commit | b460d1d52ffe911828dee58352d3cebbe04d5f30 (patch) | |
| tree | 322531093a23e740544cbd48b6020d0bc252c789 | |
| parent | e3f3f940a09ee99e952be43fd3b19c969cf229d0 (diff) | |
| download | go-b460d1d52ffe911828dee58352d3cebbe04d5f30.tar.gz go-b460d1d52ffe911828dee58352d3cebbe04d5f30.zip | |
cmd/internal/obj/x86: skip test when GOHOSTARCH is set
It's causing the darwin-386 builder to fail with:
--- FAIL: TestDynlink (0.07s)
obj6_test.go:118: error exit status 3 output go tool: no such tool "asm"
FAIL
FAIL cmd/internal/obj/x86 0.073s
So skip it for now. It's tested in enough other places.
Change-Id: I9a98ad7b8be807005750112d892ac6c676c17dd5
Reviewed-on: https://go-review.googlesource.com/18989
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
| -rw-r--r-- | src/cmd/internal/obj/x86/obj6_test.go | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/src/cmd/internal/obj/x86/obj6_test.go b/src/cmd/internal/obj/x86/obj6_test.go index 4387db696d..5fa1d3bfcf 100644 --- a/src/cmd/internal/obj/x86/obj6_test.go +++ b/src/cmd/internal/obj/x86/obj6_test.go @@ -150,6 +150,13 @@ func parseOutput(t *testing.T, td *ParsedTestData, asmout []byte) { func TestDynlink(t *testing.T) { testenv.MustHaveGoBuild(t) + if os.Getenv("GOHOSTARCH") != "" { + // TODO: make this work? It was failing due to the + // GOARCH= filtering above and skipping is easiest for + // now. + t.Skip("skipping when GOHOSTARCH is set") + } + testdata := parseTestData(t) asmout := asmOutput(t, testdata.input) parseOutput(t, testdata, asmout) |