diff options
| author | Russ Cox <rsc@golang.org> | 2009-11-17 16:52:36 -0800 |
|---|---|---|
| committer | Russ Cox <rsc@golang.org> | 2009-11-17 16:52:36 -0800 |
| commit | aae0aefb70f4fe2f51c17ae45dd695a34efd5736 (patch) | |
| tree | ed144a50c24cc8230bb4bc584d6a1746d8f7046a | |
| parent | d05fa26a7d4f27cc8384be468df7a9b80c21d9b2 (diff) | |
| download | go-aae0aefb70f4fe2f51c17ae45dd695a34efd5736.tar.gz go-aae0aefb70f4fe2f51c17ae45dd695a34efd5736.zip | |
codereview: handle spaces and other unexpected chars in nicknames
R=r
https://golang.org/cl/157053
| -rw-r--r-- | lib/codereview/codereview.py | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py index 3376f07364..bed002b9f7 100644 --- a/lib/codereview/codereview.py +++ b/lib/codereview/codereview.py @@ -1351,7 +1351,9 @@ def DownloadCL(ui, repo, clname): # The author is just a nickname: get the real email address. try: - data = MySend("/user_popup/" + nick, force_auth=False) + # want URL-encoded nick, but without a=, and rietveld rejects + for %20. + url = "/user_popup/" + urllib.urlencode({"a": nick})[2:].replace("+", "%20") + data = MySend(url, force_auth=False) except: ui.warn("error looking up %s: %s\n" % (nick, ExceptionDetail())) cl.original_author = nick+"@needtofix" |