diff options
| author | David du Colombier <0intro@gmail.com> | 2019-01-09 21:32:11 +0100 |
|---|---|---|
| committer | David du Colombier <0intro@gmail.com> | 2019-01-09 21:45:00 +0000 |
| commit | 9a5a5043e10dbc8338e21b8c7f4081a56a019b7d (patch) | |
| tree | cbc746bac8fd0f2653c46314b5b103d81bffc53d | |
| parent | 52cae2763ee59ea63e885e9a41708e3ce677039a (diff) | |
| download | go-9a5a5043e10dbc8338e21b8c7f4081a56a019b7d.tar.gz go-9a5a5043e10dbc8338e21b8c7f4081a56a019b7d.zip | |
cmd/go: skip tests using Git on Plan 9
TestScript/get_unicode, TestScript/get_dotfiles and
TestScript/get_brace are failing on Plan 9 since they
expect a full-featured git command, while the git tool
has been emulated as a simple rc script on Plan 9.
This change skips tests using Git on Plan 9.
Fixes #29640.
Change-Id: Id7f6fdca552167f4631fe401f63167e5653daafa
Reviewed-on: https://go-review.googlesource.com/c/157119
Run-TryBot: David du Colombier <0intro@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
| -rw-r--r-- | src/cmd/go/script_test.go | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/src/cmd/go/script_test.go b/src/cmd/go/script_test.go index 4aa92625dd..c56c1fd3e4 100644 --- a/src/cmd/go/script_test.go +++ b/src/cmd/go/script_test.go @@ -283,6 +283,11 @@ Script: if strings.HasPrefix(cond, "exec:") { prog := cond[len("exec:"):] ok = execCache.Do(prog, func() interface{} { + if runtime.GOOS == "plan9" && prog == "git" { + // The Git command is usually not the real Git on Plan 9. + // See https://golang.org/issues/29640. + return false + } _, err := exec.LookPath(prog) return err == nil }).(bool) |