diff options
| author | Austin Clements <austin@google.com> | 2021-03-19 14:55:23 -0400 |
|---|---|---|
| committer | Austin Clements <austin@google.com> | 2021-03-29 18:46:25 +0000 |
| commit | 2ba296da47fe4b3c70be0aea291e307cdb2c7dbe (patch) | |
| tree | 7db91d40015a79af9747d6caa8fb1feb66f5c202 | |
| parent | 24764496c7f7f58867a46aec7192b9425a3fea08 (diff) | |
| download | go-2ba296da47fe4b3c70be0aea291e307cdb2c7dbe.tar.gz go-2ba296da47fe4b3c70be0aea291e307cdb2c7dbe.zip | |
cmd/compile: update a few stale comments
CL 64811 removed dcopy. Update the comment in types.Sym.
The Russquake moved iexport.go. Update the path to it.
WRAPPER is now also used by ABI wrappers, so update the comment since
it's now more general than method wrappers.
Change-Id: Ie0df61dcef7168f6720838cd5c9a66adf546a44f
Reviewed-on: https://go-review.googlesource.com/c/go/+/305269
Trust: Austin Clements <austin@google.com>
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
| -rw-r--r-- | src/cmd/compile/internal/importer/iimport.go | 2 | ||||
| -rw-r--r-- | src/cmd/compile/internal/ir/func.go | 2 | ||||
| -rw-r--r-- | src/cmd/compile/internal/types/sym.go | 2 | ||||
| -rw-r--r-- | src/cmd/internal/obj/textflag.go | 3 |
4 files changed, 5 insertions, 4 deletions
diff --git a/src/cmd/compile/internal/importer/iimport.go b/src/cmd/compile/internal/importer/iimport.go index 33c46a0f90..8ab0b7b989 100644 --- a/src/cmd/compile/internal/importer/iimport.go +++ b/src/cmd/compile/internal/importer/iimport.go @@ -4,7 +4,7 @@ // license that can be found in the LICENSE file. // Indexed package import. -// See cmd/compile/internal/gc/iexport.go for the export data format. +// See cmd/compile/internal/typecheck/iexport.go for the export data format. package importer diff --git a/src/cmd/compile/internal/ir/func.go b/src/cmd/compile/internal/ir/func.go index 0a9db92d96..c17425a4da 100644 --- a/src/cmd/compile/internal/ir/func.go +++ b/src/cmd/compile/internal/ir/func.go @@ -162,7 +162,7 @@ type ScopeID int32 const ( funcDupok = 1 << iota // duplicate definitions ok - funcWrapper // is method wrapper + funcWrapper // hide frame from users (elide in tracebacks, don't count as a frame for recover()) funcNeedctxt // function uses context register (has closure variables) funcReflectMethod // function calls reflect.Type.Method or MethodByName // true if closure inside a function; false if a simple function or a diff --git a/src/cmd/compile/internal/types/sym.go b/src/cmd/compile/internal/types/sym.go index 0e66ed348b..c689304b34 100644 --- a/src/cmd/compile/internal/types/sym.go +++ b/src/cmd/compile/internal/types/sym.go @@ -32,7 +32,7 @@ type Sym struct { Pkg *Pkg Name string // object name - // saved and restored by dcopy + // saved and restored by Pushdcl/Popdcl Def Object // definition: ONAME OTYPE OPACK or OLITERAL Block int32 // blocknumber to catch redeclaration Lastlineno src.XPos // last declaration for diagnostic diff --git a/src/cmd/internal/obj/textflag.go b/src/cmd/internal/obj/textflag.go index 2f55793285..881e192203 100644 --- a/src/cmd/internal/obj/textflag.go +++ b/src/cmd/internal/obj/textflag.go @@ -27,7 +27,8 @@ const ( // This data contains no pointers. NOPTR = 16 - // This is a wrapper function and should not count as disabling 'recover'. + // This is a wrapper function and should not count as + // disabling 'recover' or appear in tracebacks by default. WRAPPER = 32 // This function uses its incoming context register. |