diff options
| author | Joel Sing <joel@sing.id.au> | 2023-11-08 23:29:50 +1100 |
|---|---|---|
| committer | Joel Sing <joel@sing.id.au> | 2024-05-04 07:50:22 +0000 |
| commit | 17fce6323988d20d104b92c110b8be0ceb526051 (patch) | |
| tree | 38f718b7f077bf9b10191f2678aa8def3a49e287 | |
| parent | ae6af9b3d8c88c29c81230abbe697cf61e2ae594 (diff) | |
| download | go-17fce6323988d20d104b92c110b8be0ceb526051.tar.gz go-17fce6323988d20d104b92c110b8be0ceb526051.zip | |
cmd/dist,internal/platform: temporarily disable race detector on openbsd/amd64
Unfortunately, LLVM TSAN decided to remove OpenBSD support, which
means that the syso files cannot currently be regenerated (see #52090).
The race_openbsd.syso contains a reference to the syscall symbol,
which has been removed from OpenBSD's libc in 7.5. As such, this
means that the race detector no longer works on openbsd/amd64 (at
least until LLVM TSAN support is reinstated for OpenBSD).
Updates #63900
Change-Id: I3474fc43a94e5197815862b7dc420b71d5e08815
Reviewed-on: https://go-review.googlesource.com/c/go/+/582255
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Joel Sing <joel@sing.id.au>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
| -rw-r--r-- | src/cmd/dist/test.go | 2 | ||||
| -rw-r--r-- | src/internal/platform/supported.go | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go index 6f4d23182a..a87c2a1aae 100644 --- a/src/cmd/dist/test.go +++ b/src/cmd/dist/test.go @@ -1585,7 +1585,7 @@ func raceDetectorSupported(goos, goarch string) bool { return goarch == "amd64" || goarch == "ppc64le" || goarch == "arm64" || goarch == "s390x" case "darwin": return goarch == "amd64" || goarch == "arm64" - case "freebsd", "netbsd", "openbsd", "windows": + case "freebsd", "netbsd", "windows": return goarch == "amd64" default: return false diff --git a/src/internal/platform/supported.go b/src/internal/platform/supported.go index 8f43cbf25f..a774247e6b 100644 --- a/src/internal/platform/supported.go +++ b/src/internal/platform/supported.go @@ -26,7 +26,7 @@ func RaceDetectorSupported(goos, goarch string) bool { return goarch == "amd64" || goarch == "ppc64le" || goarch == "arm64" || goarch == "s390x" case "darwin": return goarch == "amd64" || goarch == "arm64" - case "freebsd", "netbsd", "openbsd", "windows": + case "freebsd", "netbsd", "windows": return goarch == "amd64" default: return false |