diff options
| author | Cherry Mui <cherryyz@google.com> | 2023-06-08 11:48:38 -0400 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2023-06-19 15:52:13 +0000 |
| commit | 606a5a60fdc174c2985241d8ab05328fb75a13ee (patch) | |
| tree | f2651fa21e34177982bcaa5b95f0226469cb0c7f | |
| parent | 7d6517cf420d131773852f2c5cdd6d07f6edf2ad (diff) | |
| download | go-606a5a60fdc174c2985241d8ab05328fb75a13ee.tar.gz go-606a5a60fdc174c2985241d8ab05328fb75a13ee.zip | |
[release-branch.go1.19] cmd/pprof: skip TestDisasm on ARM64
The test is fixed at tip, but it is non-trivial enough to backport
to (potentionally the last) Go 1.19 minor release. Skip the test.
Fixes #60637.
Change-Id: I0425b703a5270b680346b63ab38c47b890a3a3bf
Reviewed-on: https://go-review.googlesource.com/c/go/+/501824
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
| -rw-r--r-- | src/cmd/pprof/pprof_test.go | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/src/cmd/pprof/pprof_test.go b/src/cmd/pprof/pprof_test.go index 9a37b97286..5c7b19d926 100644 --- a/src/cmd/pprof/pprof_test.go +++ b/src/cmd/pprof/pprof_test.go @@ -99,6 +99,11 @@ func TestDisasm(t *testing.T) { mustHaveDisasm(t) testenv.MustHaveGoBuild(t) + if runtime.GOARCH == "arm64" { + // Fixed at tip (issue 56574). Skip for Go 1.19 release branch. + testenv.SkipFlaky(t, 60637) + } + tmpdir := t.TempDir() cpuExe := filepath.Join(tmpdir, "cpu.exe") cmd := exec.Command(testenv.GoToolPath(t), "build", "-o", cpuExe, "cpu.go") |