From 606a5a60fdc174c2985241d8ab05328fb75a13ee Mon Sep 17 00:00:00 2001 From: Cherry Mui Date: Thu, 8 Jun 2023 11:48:38 -0400 Subject: [release-branch.go1.19] cmd/pprof: skip TestDisasm on ARM64 The test is fixed at tip, but it is non-trivial enough to backport to (potentionally the last) Go 1.19 minor release. Skip the test. Fixes #60637. Change-Id: I0425b703a5270b680346b63ab38c47b890a3a3bf Reviewed-on: https://go-review.googlesource.com/c/go/+/501824 TryBot-Result: Gopher Robot Auto-Submit: Dmitri Shuralyov Run-TryBot: Cherry Mui Reviewed-by: Michael Knyszek --- src/cmd/pprof/pprof_test.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/cmd/pprof/pprof_test.go b/src/cmd/pprof/pprof_test.go index 9a37b97286..5c7b19d926 100644 --- a/src/cmd/pprof/pprof_test.go +++ b/src/cmd/pprof/pprof_test.go @@ -99,6 +99,11 @@ func TestDisasm(t *testing.T) { mustHaveDisasm(t) testenv.MustHaveGoBuild(t) + if runtime.GOARCH == "arm64" { + // Fixed at tip (issue 56574). Skip for Go 1.19 release branch. + testenv.SkipFlaky(t, 60637) + } + tmpdir := t.TempDir() cpuExe := filepath.Join(tmpdir, "cpu.exe") cmd := exec.Command(testenv.GoToolPath(t), "build", "-o", cpuExe, "cpu.go") -- cgit v1.2.3-54-g00ecf