diff options
| author | Bryan C. Mills <bcmills@google.com> | 2022-01-28 17:22:32 -0500 |
|---|---|---|
| committer | Russ Cox <rsc@golang.org> | 2022-01-31 13:43:52 +0000 |
| commit | 41f485b9a7d8fd647c415be1d11b612063dff21c (patch) | |
| tree | 31e1b08a0b5b2ca34ea6c439274a86d4f6fd1e18 | |
| parent | a5c0b190809436fd196a348f85eca0416f4de7fe (diff) | |
| download | go1.18beta2.tar.gz go1.18beta2.zip | |
cmd/go: rewrite TestScript/cgo_stale_precompiled to be agnostic to stalenessgo1.18beta2
The configuration set by x/build/cmd/releasebot causes runtime/cgo to
be stale in the darwin/amd64 release (see #36025, #35459).
That staleness is mostly benign because we can reasonably assume that
users on macOS will either disable CGO entirely or have a C compiler
installed to rebuild (and cache) the stale packages if needed.
Fixes #50892
Fixes #50893
Updates #46347
Change-Id: Ib9ce6b5014de436264238f680f7ca4ae02c9a220
Reviewed-on: https://go-review.googlesource.com/c/go/+/381854
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
| -rw-r--r-- | src/cmd/go/testdata/script/cgo_stale_precompiled.txt | 19 |
1 files changed, 15 insertions, 4 deletions
diff --git a/src/cmd/go/testdata/script/cgo_stale_precompiled.txt b/src/cmd/go/testdata/script/cgo_stale_precompiled.txt index cda804070a..80ed751afc 100644 --- a/src/cmd/go/testdata/script/cgo_stale_precompiled.txt +++ b/src/cmd/go/testdata/script/cgo_stale_precompiled.txt @@ -4,14 +4,25 @@ [!cgo] skip -# Control case: net must not already be stale. -! stale net +# This test may start with the runtime/cgo package already stale. +# Explicitly rebuild it to ensure that it is cached. +# (See https://go.dev/issue/50892.) +# +# If running in non-short mode, explicitly vary CGO_CFLAGS +# as a control case (to ensure that our regexps do catch rebuilds). + +[!short] env GOCACHE=$WORK/cache +[!short] env CGO_CFLAGS=-DTestScript_cgo_stale_precompiled=true +go build -x runtime/cgo +[!short] stderr '[/\\]cgo'$GOEXE'["]? .* -importpath runtime/cgo' # https://go.dev/issue/47215: a missing $(go env CC) caused the precompiled net to be stale. [!plan9] env PATH='' # Guaranteed not to include $(go env CC)! [plan9] env path='' -! stale net # issue #47215 +go build -x runtime/cgo +! stderr '[/\\]cgo'$GOEXE'["]? .* -importpath runtime/cgo' # https://go.dev/issue/50183: a mismatched GOROOT_FINAL caused net to be stale. env GOROOT_FINAL=$WORK${/}goroot -! stale net +go build -x runtime/cgo +! stderr '[/\\]cgo'$GOEXE'["]? .* -importpath runtime/cgo' |