diff options
| author | David Chase <drchase@google.com> | 2021-02-28 21:48:20 -0500 |
|---|---|---|
| committer | David Chase <drchase@google.com> | 2021-03-03 01:40:22 +0000 |
| commit | aea1259a7288d71736273b494e60bd424ea1946c (patch) | |
| tree | 9e845e699db7de3fcc856cc63a01e4116f261e38 | |
| parent | 312fd9937d6e8675a166fe60df77c1c24015a369 (diff) | |
| download | go-aea1259a7288d71736273b494e60bd424ea1946c.tar.gz go-aea1259a7288d71736273b494e60bd424ea1946c.zip | |
cmd/link: disable flaky Darwin "symbols" test
About one run out of 3 it fails on my laptop, and
I am tired of having to be a nanny for my tests just
because of this one flaky test. This has been a problem
for months.
Updates #32218.
Change-Id: I2871d4c6f47e9432d189ed7bdcda8f9c0871cfc5
Reviewed-on: https://go-review.googlesource.com/c/go/+/297469
Trust: David Chase <drchase@google.com>
Run-TryBot: David Chase <drchase@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
| -rw-r--r-- | src/cmd/link/dwarf_test.go | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/cmd/link/dwarf_test.go b/src/cmd/link/dwarf_test.go index db710bed6a..d0284ad4f5 100644 --- a/src/cmd/link/dwarf_test.go +++ b/src/cmd/link/dwarf_test.go @@ -91,7 +91,8 @@ func testDWARF(t *testing.T, buildmode string, expectDWARF bool, env ...string) exe = filepath.Join(tmpDir, "go.o") } - if runtime.GOOS == "darwin" { + darwinSymbolTestIsTooFlaky := true // Turn this off, it is too flaky -- See #32218 + if runtime.GOOS == "darwin" && !darwinSymbolTestIsTooFlaky { if _, err = exec.LookPath("symbols"); err == nil { // Ensure Apple's tooling can parse our object for symbols. out, err = exec.Command("symbols", exe).CombinedOutput() |