From aea1259a7288d71736273b494e60bd424ea1946c Mon Sep 17 00:00:00 2001 From: David Chase Date: Sun, 28 Feb 2021 21:48:20 -0500 Subject: cmd/link: disable flaky Darwin "symbols" test About one run out of 3 it fails on my laptop, and I am tired of having to be a nanny for my tests just because of this one flaky test. This has been a problem for months. Updates #32218. Change-Id: I2871d4c6f47e9432d189ed7bdcda8f9c0871cfc5 Reviewed-on: https://go-review.googlesource.com/c/go/+/297469 Trust: David Chase Run-TryBot: David Chase TryBot-Result: Go Bot Reviewed-by: Cherry Zhang --- src/cmd/link/dwarf_test.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/cmd/link/dwarf_test.go b/src/cmd/link/dwarf_test.go index db710bed6a..d0284ad4f5 100644 --- a/src/cmd/link/dwarf_test.go +++ b/src/cmd/link/dwarf_test.go @@ -91,7 +91,8 @@ func testDWARF(t *testing.T, buildmode string, expectDWARF bool, env ...string) exe = filepath.Join(tmpDir, "go.o") } - if runtime.GOOS == "darwin" { + darwinSymbolTestIsTooFlaky := true // Turn this off, it is too flaky -- See #32218 + if runtime.GOOS == "darwin" && !darwinSymbolTestIsTooFlaky { if _, err = exec.LookPath("symbols"); err == nil { // Ensure Apple's tooling can parse our object for symbols. out, err = exec.Command("symbols", exe).CombinedOutput() -- cgit v1.2.3-54-g00ecf