diff options
| author | Giovanni Bajo <rasky@develer.com> | 2020-03-22 09:28:21 +0100 |
|---|---|---|
| committer | Giovanni Bajo <rasky@develer.com> | 2020-03-22 08:42:38 +0000 |
| commit | 787e7b048cff392d1cb68c57c99ff71602997475 (patch) | |
| tree | 8e85917ec24cee6a154217e9ec024ac9f2aeafbd /.gitattributes | |
| parent | 2910c5b4a01a573ebc97744890a07c1a3122c67a (diff) | |
| download | go-787e7b048cff392d1cb68c57c99ff71602997475.tar.gz go-787e7b048cff392d1cb68c57c99ff71602997475.zip | |
build: force all Windows batch files to CRLF
Batch files should use CRLF endings. LF endings mostly
work but in some situations they cause random errors like
goto commands failing for mysterious reasons. See
golang.org/issue/37791 for more information.
Next CL triggered one of such bug (a label was not being
recognized), so prepare for it by converting to CRLF.
This CL also touches all existing batch files to force git
to update the line endings (unfortunately, changing
.gitattributes only has effect next time the file is checked
out or modified).
Fixes #37791
Updates #9281
Change-Id: I6f9a114351cb7ac9881914400aa210c930eb8cc1
Reviewed-on: https://go-review.googlesource.com/c/go/+/96495
Run-TryBot: Giovanni Bajo <rasky@develer.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
Diffstat (limited to '.gitattributes')
| -rw-r--r-- | .gitattributes | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/.gitattributes b/.gitattributes index 07953cae39..bcea0290f4 100644 --- a/.gitattributes +++ b/.gitattributes @@ -8,3 +8,9 @@ # See golang.org/issue/9281 * -text + +# The only exception is Windows files that must absolutely be CRLF or +# might not work. Batch files are known to have multiple bugs when run +# with LF endings. See golang.org/issue/37791 for more information. + +*.bat text eol=crlf |