aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIan Jackson <ijackson@chiark.greenend.org.uk>2024-04-24 11:51:54 +0100
committerIan Jackson <ijackson@chiark.greenend.org.uk>2024-04-25 15:22:32 +0100
commit2308e88a9a9e308f28b9a60d9efed6ad3cd603fb (patch)
treea2ec7187a718ca918480dd747874ceada2e80803
parentd5a3b832b902d8cfa21d8f1c5721f0070fe3fd53 (diff)
downloadarti-2308e88a9a9e308f28b9a60d9efed6ad3cd603fb.tar.gz
arti-2308e88a9a9e308f28b9a60d9efed6ad3cd603fb.zip
Add temporary allows for some dead code warnings
-rw-r--r--crates/tor-dirmgr/src/storage.rs2
-rw-r--r--crates/tor-proto/src/circuit/sendme.rs1
-rw-r--r--crates/tor-proto/src/crypto/cell.rs1
-rw-r--r--crates/tor-proto/src/crypto/handshake.rs1
4 files changed, 5 insertions, 0 deletions
diff --git a/crates/tor-dirmgr/src/storage.rs b/crates/tor-dirmgr/src/storage.rs
index 834c7814e..524a85ed9 100644
--- a/crates/tor-dirmgr/src/storage.rs
+++ b/crates/tor-dirmgr/src/storage.rs
@@ -281,6 +281,7 @@ pub(crate) trait Store: Send + 'static {
/// Mark the consensus generated from `cmeta` as no longer pending.
fn mark_consensus_usable(&mut self, cmeta: &ConsensusMeta) -> Result<()>;
/// Remove the consensus generated from `cmeta`.
+ #[allow(dead_code)] // TODO #1383 do we want to keep this anyway
fn delete_consensus(&mut self, cmeta: &ConsensusMeta) -> Result<()>;
/// Read all of the specified authority certs from the cache.
@@ -328,6 +329,7 @@ pub(crate) trait Store: Send + 'static {
///
/// It's not an error if it's not present.
#[cfg(feature = "bridge-client")]
+ #[allow(dead_code)] // TODO #1383 is lack of call sites indication of a bug?
fn delete_bridgedesc(&mut self, bridge: &BridgeConfig) -> Result<()>;
}
diff --git a/crates/tor-proto/src/circuit/sendme.rs b/crates/tor-proto/src/circuit/sendme.rs
index 691e87d57..c7e0ab2b6 100644
--- a/crates/tor-proto/src/circuit/sendme.rs
+++ b/crates/tor-proto/src/circuit/sendme.rs
@@ -81,6 +81,7 @@ where
/// Helper: parametrizes a window to determine its maximum and its increment.
pub(crate) trait WindowParams {
/// Largest allowable value for this window.
+ #[allow(dead_code)] // TODO #1383 failure to ever use this is probably a bug
fn maximum() -> u16;
/// Increment for this window.
fn increment() -> u16;
diff --git a/crates/tor-proto/src/crypto/cell.rs b/crates/tor-proto/src/crypto/cell.rs
index 0cbc96db7..55ce46017 100644
--- a/crates/tor-proto/src/crypto/cell.rs
+++ b/crates/tor-proto/src/crypto/cell.rs
@@ -82,6 +82,7 @@ where
}
/// Represents a relay's view of the crypto state on a given circuit.
+#[allow(dead_code)] // TODO #1383 ????
pub(crate) trait RelayCrypt {
/// Prepare a RelayCellBody to be sent towards the client.
fn originate(&mut self, cell: &mut RelayCellBody);
diff --git a/crates/tor-proto/src/crypto/handshake.rs b/crates/tor-proto/src/crypto/handshake.rs
index 5d2eb01dc..b6e3da0ee 100644
--- a/crates/tor-proto/src/crypto/handshake.rs
+++ b/crates/tor-proto/src/crypto/handshake.rs
@@ -101,6 +101,7 @@ pub(crate) trait ServerHandshake {
///
/// On success, return a key generator and a server handshake message
/// to send in reply.
+ #[allow(dead_code)] // TODO #1383 ????
fn server<R: RngCore + CryptoRng, REPLY: AuxDataReply<Self>, T: AsRef<[u8]>>(
rng: &mut R,
reply_fn: &mut REPLY,