summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2020-02-06Fix a couple more long warning linesNick Mathewson
These are not a problem with 2-space indentation, but cocci will start getting confused when clang-format wraps them with 4-space indentation.
2020-02-06circuitbuild: expect bug message that clang-format will generate.Nick Mathewson
clang-format wants to put no space here, so we need to tell the test to expect a lack of a space.
2020-02-06Wrap columnar tables in "clang-format off/on"Nick Mathewson
These tables have aligned comments, so we don't want clang-format to mess with them.
2020-02-06Use parentheses to avoid mis-indentations of stringified macro argsNick Mathewson
clang-format sometimes thinks that "#name" should be written as "# name" if it appears at the start of a line. Using () appears to suppress this, while confusing Coccinelle.
2020-02-06maps: do not include _ as part of expected prefix in macros.Nick Mathewson
Doing this makes our macro usage a little clear IMO, and also avoids having to use an unadorned "new" within a macro. (Clang-format seems to think that "new" means we're doing C++, and so it generates some output that checkSpace.pl doesn't care for.)
2020-02-06Remove senseless CHECK_PRINTF()s from util_bug.cNick Mathewson
These belong in util_bug.h (and they already are there). Their presence made clang-format misindent these functions in a way that checkSpace.pl dislikes.
2020-02-06log_test_helpers: remove semicolons from end of macrosNick Mathewson
We want our code to require semicolons after use of these macros, so that our code formatters and/or analysis tools don't get confused.
2020-02-06Use smaller CPP error messagesNick Mathewson
Clang-format wants to split these messages across multiple lines, which confuses the heck out of coccinelle.
2020-02-06onion_queue.c: use TAILQ_HEAD less confusingly.Nick Mathewson
When we use macro inline, clang-format likes to break it in the middle, which makes checkSpace get confused.
2020-02-06prob_distr: use "clang-format off" to avoid wide lines for URLsNick Mathewson
2020-02-06Use a compile-time assert in control_events.hNick Mathewson
(The original idiom here led clang-format to generating a too-wide line.)
2020-02-06Merge branch 'bug33103'Nick Mathewson
2020-02-06test: Missing hs_init() in some hs_control testsDavid Goulet
Without the hs_init(), the caches are not initialized and the previous commit was causing an assert due to the missing caches. But regardless of that, those tests were not initializing but were calling hs_free_all(). Signed-off-by: David Goulet <dgoulet@torproject.org>
2020-02-06hs-v3: Remove descriptor when we remove client authorizationDavid Goulet
When the ONION_CLIENT_AUTH_REMOVE command is given to tor, now also remove the descriptor associated with the client authorization credentials. Fixes #33148 Signed-off-by: David Goulet <dgoulet@torproject.org>
2020-02-05Fix a memory leak in handling GETINFO.Nick Mathewson
Fixes bug 33103; bugfix on 0.4.3.1-alpha.
2020-02-04Merge branch 'tor-github/pr/1704'George Kadianakis
2020-02-04Merge branch 'tor-github/pr/1700'George Kadianakis
2020-02-04address: Fix comments in address.hteor
And improve inline function spacing, and function declaration spacing. Comment-only change.
2020-02-03hs-v3: Purge ephemeral client auth on NEWNYMDavid Goulet
Fixes #33139. Signed-off-by: David Goulet <dgoulet@torproject.org>
2020-01-30Merge branch 'tor-github/pr/1687'David Goulet
2020-01-30Merge branch 'tor-github/pr/1692'David Goulet
2020-01-30Merge branch 'tor-github/pr/1697'David Goulet
2020-01-30hs-v2: Turn logs into protocol warningDavid Goulet
All of those can be triggered remotely so change them to protocol warnings. Fixes #32706 Signed-off-by: David Goulet <dgoulet@torproject.org>
2020-01-30Merge branch 'bug32673_035'Nick Mathewson
2020-01-30Merge branch 'bug33093_logging_035'Nick Mathewson
2020-01-30Do not set "once" when calling tor_bug_occurred_ from BUG().Nick Mathewson
The "once" flag makes tor_bug_occurred_() say that future instances of the warning will be suppressed -- but that's not something that BUG() does. Fixes bug 33095; bugfix on 0.4.1.1-alpha.
2020-01-29bump to 0.4.1.8Nick Mathewson
2020-01-30Merge branch 'maint-0.4.0' into maint-0.4.1teor
2020-01-30Merge branch 'maint-0.3.5' into maint-0.4.0teor
2020-01-30Merge remote-tracking branch 'tor-github/pr/1634' into maint-0.4.1teor
2020-01-30Merge remote-tracking branch 'tor-github/pr/1614' into maint-0.3.5teor
2020-01-29buf_read_from_tls: Return ERROR_MISC, not WANTWRITE, on BUG().Nick Mathewson
Fixes bug 32673; bugfix on 0.3.0.4-alpha. We introduced these checks in ee5471f9aab5526 to help diagnose 21369, but we used "-1" when "TOR_TLS_ERROR_MISC" would have been correct. Found by opara. I don't think that this is actually getting triggered in the wild, but if it were, it could cause nasty behavior: spurious WANTREAD/WANTWRITE returns have a way of turning into CPU-eating busy-loops.
2020-01-29Change BUG() messages in buf_flush_to_tls() to IF_BUG_ONCE()Nick Mathewson
We introduced these BUG() checks in b0ddaac07428a06 to prevent a recurrence of bug 23690. But there's a report of the BUG() message getting triggered and filling up the disk. Let's change it to IF_BUG_ONCE(). Fixes bug 33093; bugfix on 0.3.2.2-alpha.
2020-01-29mainloop: Simplify ip_address_changed()teor
Simplify ip_address_changed() by removing redundant checks (all exits are relays, and need to rebuild their descriptor when their IP addresses change). Rewrite the function comment, and rename the argument, so the function is easier to understand and use. Closes 33091.
2020-01-29connection: Improve function commentsteor
Improve the function comments on connection_finished_connecting(), to describe what the function actually does. Part of 33091.
2020-01-28Use print() function in both Python 2 and Python 3cclauss
2020-01-24tests for ticket 33039Taylor Yu
2020-01-24fix leak in GETCONFTaylor Yu
Fix a memory leak introduced by refactoring of control reply formatting code. Fixes bug 33039; bugfix on 0.4.3.1-alpha.
2020-01-22Bump to 0.4.3.1-alpha-devNick Mathewson
2020-01-22Merge branch 'tor-github/pr/1677'David Goulet
2020-01-22Lower log level of standard error messages from PT's.Alexander Færøy
This patch lowers the log level of error messages from PT processes from warning to debug. See: https://bugs.torproject.org/33005
2020-01-22dir_connection_t: Explain dirconn_direct betterteor
Direct connections can use a DirPort or ORPort. Indirect connections must use a multi-hop Tor circuit. Comment-only changes.
2020-01-21Bump to 0.4.3.1-alphaNick Mathewson
2020-01-20Merge branch 'tor-github/pr/1675'David Goulet
2020-01-20Merge branch 'tor-github/pr/1668'David Goulet
2020-01-20config: Make clients tell dual-stack exits they prefer IPv6teor
Make Tor clients tell dual-stack exits that they prefer IPv6 connections. This change is equivalent to setting the PreferIPv6 flag on SOCKSPorts (and most other listener ports). Tor Browser has been setting this flag for some time, and we want to remove a client distinguisher at exits. Also update the man page, putting all the IP flags in their non-default forms. Closes ticket 32637.
2020-01-20Merge remote-tracking branch 'tor-github/pr/1673'teor
2020-01-20test/nodelist: Remove ROUTERSTATUS_FORMAT_NO_CONSENSUS_METHODteor
When we removed obsolete consensus methods in 32695, we also removed ROUTERSTATUS_FORMAT_NO_CONSENSUS_METHOD, so we need to remove it from the routerstatus format tests. Part of 20218.
2020-01-20Merge branch 'ticket20218_rebased_squashed' into ticket20218_mergedteor
* ticket 32695 removed networkstatus_consensus_has_ipv6(), keep that change in master. * ticket 20218 modifies the function name and comment for routerstatus_has_visibly_changed(), keep that change in ticket20218_rebased_squashed.
2020-01-20Rename test to match new identifier.Nick Mathewson
7apu2bq3rhoylwmucxizk54afw5jyda7pho4j5zdcqpwkufke7zdzwad.onion