| Age | Commit message (Collapse) | Author |
|---|
|
|
|
This change refactors find_dl_schedule() to only call dependent functions
as needed. In particular, directory_fetches_from_authorities() only needs
to be called on clients.
Stopping spurious directory_fetches_from_authorities() calls on every
download on public relays has the following impacts:
* fewer address resolution attempts, particularly those mentioned in 21789
* fewer descriptor rebuilds
* fewer log messages, particularly those limited in 20610
Fixes 23470 in 0.2.8.1-alpha.
The original bug was introduced in commit 35bbf2e as part of prop210.
|
|
|
|
|
|
|
|
These items were listed in testing_tor_network_defaults, but had the
same defaults as with the regular settings.
Closes ticket 22532.
|
|
OpenBSD doesn't like tricks where you use a too-wide sscanf argument
for a too-narrow array, even when you know the input string
statically. The fix here is just to use bigger buffers.
Fixes 15582; bugfix on a3dafd3f58bb312 in 0.2.6.2-alpha.
|
|
Fixes #23481
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
|
|
|
|
|
Also fix an indentation issue.
Closes #23480
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
|
Part of #23480.
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
|
|
|
|
|
17750 made unused download schedules automatically reset.
But we should make that explicit.
|
|
But when clients are just starting, make them try each bridge a few times
before giving up on it.
These changes make the bridge download schedules more explicit: before
17750, they relied on undocumented behaviour and specific schedule
entries. (And between 17750 and this fix, they were broken.)
Fixes 23347, not in any released version of tor.
|
|
We were always incrementing bridge download statuses on each attempt,
but we were using the "increment on failure" functions to do it.
And we never incremented them on failure.
No behaviour change.
|
|
The download schedule tells Tor to wait 15 minutes before downloading
bridge descriptors. But 17750 made Tor ignore that and start immediately.
Since we fixed 17750, Tor waits 15 minutes for bridge client bootstrap,
like the schedule says.
This fixes the download schedule to start immediately, and to try each
bridge 3 times in the first 30 seconds. This should make bridge bootstraps
more reliable.
Fixes 23347.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
So, move the get_options() call.
|
|
Requires chutney master 50f64ea or later.
Implements ticket 22437.
|
|
It is possible that two descriptor upload requests are launched in a very
short time frame which can lead to the second request finishing before the
first one and where that first one will make the HSDir send back a 400
malformed descriptor leading to a warning.
To avoid such, cancel all active directory connections for the specific
descriptor we are about to upload.
Note that this race is still possible on the HSDir side which triggers a log
info to be printed out but that is fine.
Fixes #23457
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
|
|
|
|
|
Add magic comments recognized by default -Wimplicit-fallthrough=3
or break, as required.
|
|
Add magic comments recognized by default -Wimplicit-fallthrough=3
Follow-up to e5f464, fixes Ticket 22446 for 32 bit.
[nick notes: Backport from 0.3.1.3-alpha.]
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
When option validation or transition is happening, there are no
"current options" -- only "old options" and "maybe new options".
Looking at get_options() is likely a mistake, so have a nonfatal
assertion let us know if we do that.
Closes 22281.
|
|
|
|
Closes #23304
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
|
Closes #23462
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
|
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
|
|
|
Our unit tests will need this, so that they can simulate advancing
time without getting libevent involved.
|
|
Because we can get a RENDEZVOUS2 cell before the INTRODUCE_ACK, we need to
correctly handle the circuit purpose REND_JOINED that is not change its
purpose when we get an INTRODUCE_ACK and simply close the intro circuit
normally.
Fixes #23455
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
|
|
|
|
