| Age | Commit message (Collapse) | Author |
|---|
|
The DoS heartbeat now contains the number of rejected INTRODUCE2 cell that the
relay has seen.
Closes #31371
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
|
This required a small refactoring so we could count properly the INTRO2
sending disallow.
Part of #31371
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
|
|
|
|
|
Also gives make_path_absolute() const args.
Obviously correct fixes to already reviewed code.
|
|
|
|
Closes #32343
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
|
|
|
|
|
Obviously correct fixes to already reviewed code.
No changes file required: not in any released version of tor.
|
|
When picking an intro point from the service descriptor, the client failed to
lookup the failure cache.
It made an HS v2 client re-pick bad intro points for which we already know it
won't work in the first place.
Based on Neel Chauhan original patch.
Fixes #25568
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
|
|
|
|
|
The options validation is now a callback.
Bugfix on 31241; not in any released version of tor.
|
|
|
|
|
|
|
|
|
|
|
|
If a file doesn't use the file command (either \file or @file),
Doxygen won't try to process it.
|
|
If a file doesn't use the file command (either \file or @file),
Doxygen won't try to process it.
|
|
If a file doesn't use the file command (either \file or @file),
Doxygen won't try to process it.
|
|
If a file doesn't use the file command (either \file or @file),
Doxygen won't try to process it.
|
|
If a file doesn't use the file command (either \file or @file),
Doxygen won't try to process it.
|
|
If a file doesn't use the file command (either \file or @file),
Doxygen won't try to process it.
These declarations also turned up a doxygen warning for
proto_socks.c; I fixed that too.
|
|
If a file doesn't use the file command (either \file or @file),
Doxygen won't try to process it.
These declarations also turned up a doxygen warning for
crypto_ope.c; I fixed that too.
|
|
This is an automated commit, generated by this command:
./scripts/maint/rename_c_identifier.py \
confparse.h confmgt.h \
confparse.c confmgt.c \
CONFPARSE_PRIVATE CONFMGT_PRIVATE \
TOR_CONFPARSE_H TOR_CONFMGT_H
|
|
This will break compilation until includes etc are fixed.
|
|
Since these are needed by every module that is _configurable_, they
belong in lib/conf, not lib/confmgt.
|
|
|
|
|
|
|
|
In the unit tests.
Fixes a regression to bug 31334; bug not in any released version of tor.
|
|
|
|
|
|
This function is used by controllers to set options. I refactored
it a bit when refactoring options validation, so it needs to get
tested.
|
|
options_validate_cb() derives DataDirectory (which we use) from
DataDirectory_option (which the user sets). I want to add a test
that will call options_validate_cb(), but it will fail unless it
derives the same value.
|
|
I'll need this for testing options_trial_assign().
|
|
|
|
|
|
|
|
This eliminates duplicated code. The options_validate() function
itself is now tests-only.
|
|
Unlike legacy_validate_fn_t, these callbacks have separation of
duties, into:
* early normalization and computation.
* validation
* transition checking
* late normalization and computation
Only the first and last steps get mutable objects. Only the
transition-checking step gets to see the previous values of this
object.
|
|
The former foo_validate() functions are now toplevel
legacy_validate_fn callbacks. The new foo_validate() functions now
call them.
This change lets us remove the old shared_random disk state
validation callback entirely.
|
|
As we turn our monolithic configuration objects into suites of
smaller module-specific configuration objects, we will want each one
to be able to provide its own verification callbacks. That means
that instead of invoking these verification callbacks directly, we will
want to call them via the configuration manager object.
|
|
The current API of this callback mixes responsibilities, including:
* validation
* transition checking
* processing (modifying) the configuration object.
These will have to be disentangled piece by piece, so for now, we'll
have "legacy" validate functions as well.
This is an automated commit, generated by this command:
./scripts/maint/rename_c_identifier.py \
validate_fn_t legacy_validate_fn_t \
validate_fn legacy_validate_fn
|
|
Now that we no longer use it anywhere, we can remove this variable
from the test data structure.
|
|
This input was inessential, and none of the tests actually depended
on it or tested anything about it (as can be seen from the fact that
tests all still pass when it's removed).
I tried to generate this commit with a coccinelle script, but it had
trouble parsing a lot of options_validate as it stands. Instead, I
did a search-and-replace to replace "tdata->old_opt," with "NULL,".
|
|
I'm about to mess with their lists of callbacks, and I don't want to
proliferate lists where we say "NULL, NULL, NULL, ..."
|
|
|
