summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2020-03-30Merge branch 'maint-0.4.3'David Goulet
2020-03-30hs-v3: Relax severity of a log message when decoding descriptors.George Kadianakis
Make it LOG_PROTOCOL_WARN and also add the expiration timestamp in there to ease debugging in the future.
2020-03-30Merge branch 'tor-github/pr/1775'David Goulet
2020-03-30Use a macro to make our hs_opts checking terser.Nick Mathewson
2020-03-30Use SECTION_HEADER, not "HiddenServiceDir".Nick Mathewson
Add a nonfatal assertion about a branch that should be unreachable.
2020-03-30Update expected log messages in tests to new format.Nick Mathewson
2020-03-30Derive hidden service configuration from hs_opts_t.Nick Mathewson
This simplifies our parsing code by about 150 lines, and makes the functions more straightforward.
2020-03-30Start using confmgt logic to parse HS configuration.Nick Mathewson
This patch doesn't actually use the results of the parsed object to create the service configuration: subsequent patches will do that. This patch just introduces the necessary configuration tables and starts using them to validate the configuration. As of this writing, this patch breaks tests. I'll likely fix that in a rebase later on: the current error messages for failures to parse options are a regression, so I've opened #33640 for that.
2020-03-30Use config_lines_partition() to parse hs config sections.Nick Mathewson
2020-03-27fix typo in struct addr_policy_t commentRoger Dingledine
2020-03-27correct tor_addr_family() function commentRoger Dingledine
kind of a losing game to remember to update that comment when we add another possible family, but hey, maybe it will be a while until we add one more.
2020-03-27spell consensus more right in commentsRoger Dingledine
2020-03-27fix typo in log messageRoger Dingledine
2020-03-26Merge remote-tracking branch 'tor-github/pr/1780/head'Nick Mathewson
2020-03-26Merge branch 'maint-0.4.3'David Goulet
2020-03-26Merge branch 'tor-github/pr/1794' into maint-0.4.3David Goulet
2020-03-25Merge branch 'bug33651'Nick Mathewson
2020-03-23Merge branch 'maint-0.4.3'George Kadianakis
2020-03-23Merge branch 'tor-github/pr/1788' into maint-0.4.3George Kadianakis
2020-03-23Merge remote-tracking branch 'tor-github/pr/1797/head'Nick Mathewson
2020-03-21Add some comments about future relay IPv6 workteor
Comments about 33681.
2020-03-21parseconf: Add ORPort and DirPort auto teststeor
These tests don't actually trigger bug 32588, but they do increase the coverage of the auto port config code. Tests for 32588.
2020-03-21Merge branch 'bug32588_043' into bug32588_masterteor
2020-03-21Merge branch 'bug32588_042' into bug32588_043teor
Merge static function declaration deletions from bug32588_042 and maint-0.4.3 in app/config/config.c.
2020-03-21Merge branch 'bug32588_041' into bug32588_042teor
2020-03-21Merge branch 'bug32588_035' into bug32588_041teor
Merge tests from maint-0.4.1 with new tests from bug32588_035 in test_router.c.
2020-03-21Add a test for the localhost case.Nick Mathewson
2020-03-21Extend test to handle router_get_advertised_ipv6_or_apNick Mathewson
2020-03-21Add a test for router_get_advertised_or_port_by_af().Nick Mathewson
2020-03-21Add tests for get_first_advertised_{addr,port}_by_type_af()Nick Mathewson
2020-03-21router: Refactor IPv6 ORPort function logicteor
Return early when there is no suitable IPv6 ORPort. Show the address and port on error, using a convenience function. Code simplification and refactoring. Cleanup after 32588.
2020-03-21router: Stop advertising incorrect auto IPv6 ORPortsteor
When IPv6 ORPorts are set to "auto", tor relays and bridges would advertise an incorrect port in their descriptor. This may be a low-severity memory safety issue, because the published port number may be derived from uninitialised or out-of-bounds memory reads. Fixes bug 32588; bugfix on 0.2.3.9-alpha.
2020-03-21relay: Set some output arguments in stubsteor
Fixes part of bug 33674; not in any released version of tor.
2020-03-20Merge branch 'maint-0.4.3'Nick Mathewson
2020-03-20relay/dirauth: Set some output arguments in stubsteor
And document how some functions set their output arguments. Fixes bug 33674; bugfix on 0.4.3.1-alpha.
2020-03-20Set *have_low_ports_out from stub port_parse_ports_relay().Nick Mathewson
Previously we just ignored this option, which would leave it unset, and cause an assertion failure later on when running with the User option. Fixes bug 33668; bugfix on 0.4.3.1-alpha.
2020-03-20Merge branch 'maint-0.4.3'teor
2020-03-20dirauth: Remove a duplicate macro definitionteor
Obviously correct changes to already-reviewed code.
2020-03-20Merge branch 'maint-0.4.3'teor
2020-03-20Merge branch 'maint-0.4.2' into maint-0.4.3teor
2020-03-20Merge branch 'maint-0.4.1' into maint-0.4.2teor
2020-03-19Merge branch 'ticket33643_skip_035' into ticket33643_skip_041Nick Mathewson
2020-03-19Add a TOR_SKIP_TESTCASES environment variable for suppressing tests.Nick Mathewson
For example, "TOR_SKIP_TESTCASES=crypto/.. ./src/test/test" will run the tests and suppress all the "crypto/" tests. You could get the same effect by running "./src/test/test :crypto/..", but that can be harder to arrange from CI. Part of a fix/workaround for 33643.
2020-03-19Fix erroneous spaces in circuitmux_ewma.cNeel Chauhan
2020-03-19Merge branch 'tor-github/pr/1778'George Kadianakis
2020-03-19Actually log post-bootstrap directory dl totals.Nick Mathewson
Fixes bug 33651; bug not in any released Tor.
2020-03-19Merge remote-tracking branch 'tor-github/pr/1807/head'Nick Mathewson
2020-03-19Merge branch 'tor-github/pr/1792'George Kadianakis
2020-03-19hs-v3: Improve accessor semantic of client cached objectDavid Goulet
Add an inline helper function that indicates if the cached object contains a decrypted descriptor or not. The descriptor object is NULL if tor is unable to decrypt it (lacking client authorization) and some actions need to be done only when we have a decrypted object. This improves code semantic. Fixes #33458 Signed-off-by: David Goulet <dgoulet@torproject.org>
2020-03-19coverity: Silence spurious unreachable warningteor
Closes bug 33641; not in any released version of tor.