Age | Commit message (Collapse) | Author |
|
Many of the 'truncated command' paths in fetch_from_buf_socks() were
not reached by the tests. This new unit test tries to check them
exhaustively.
|
|
No other code changes.
|
|
|
|
|
|
Fixes #23159.
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
|
|
|
The confparse field has type UINT, which corresponds to an int
type. We had uint32_t.
This shouldn't cause trouble in practice, since int happens to
4-bytes wide on every platform where an authority is running. It's
still wrong, though.
|
|
The correct type for a STRING confparse value is char *, not const
char *.
|
|
These should have been int, but we had listed them as unsigned.
That's an easy mistake to make, since "int" corresponds with either
INT or UINT in the configuration file.
This bug cannot have actually caused a problem in practice, since we
check those fields' values on load, and ensure that they are in
range 0..INT32_MAX.
|
|
New approach, suggested by Taylor: During testing builds, we
initialize a union member of an appropriate pointer type with the
address of the member field we're trying to test, so we can make
sure that the compiler doesn't warn.
My earlier approach invoked undefined behavior.
|
|
|
|
Also demote a log message that can occur under natural causes
(if the circuit subsystem is missing descriptors/consensus etc.).
The HS subsystem will naturally retry to connect to intro points,
so no need to make that log user-facing.
|
|
So we can track them more easily in the logs and match any open/close/free
with those identifiers.
Part of #23645
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
|
This removes the "nickname" of the cannibalized circuit last hop as it is
useless. It now logs the n_circ_id and global identifier so we can match it
with other logging statement.
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
|
Prior to the log statement, the circuit n_circ_id value is zeroed so keep a
copy so we can log it at the end.
Part of #23645
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
|
Part of #23645
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
|
|
|
This fixes a clang warning.
|
|
|
|
|
|
|
|
Fixes #23539.
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
|
|
|
Just making sure that added padding does not screw up cell parsing.
|
|
|
|
|
|
setup_capture_of_logs() doesn't actually suppress warnings :p
|
|
|
|
|
|
|
|
Relays send it, and we may as well let them. Part of our fix for
22805.
|
|
Also, allow channel_is_client() to take a const channel.
|
|
|
|
The is_first_hop field should have been called used_create_fast,
but everywhere that we wanted to check it, we should have been
checking channel_is_client() instead.
|
|
The diff is confusing, but were two static scheduler functions that
needed moving to static comment block.
No code change. Thanks dgoulet for original commit
|
|
Closes 23552. Thanks dgoulet for original impl
|
|
|
|
|
|
|
|
Fixes bug 21800; bugfix on 0.2.9.x
|
|
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
|
Fixes #23581
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
|
Fixes #23610
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
|
|
|
|
|
|
|
The clock_skew_warning() refactoring allowed calls from
or_state_load() to control_event_bootstrap_problem() to occur prior
bootstrap phase 0, causing an assertion failure. Initialize the
bootstrap status prior to calling clock_skew_warning() from
or_state_load().
|
|
or_state_load() was using an incorrect sign convention when calling
clock_skew_warning() to warn about state file clock skew. This caused
the wording of the warning to be incorrect about the direction of the
skew.
|
|
|
|
When we remove an intro point from the service list, log info about it and
some useful data.
Signed-off-by: David Goulet <dgoulet@torproject.org>
|