summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2016-09-06Split tor_parse_{some_int} testing into separate fn. Code movement only.Nick Mathewson
2016-09-06Merge remote-tracking branch 'teor/bug20012'Nick Mathewson
2016-09-06Merge remote-tracking branch 'teor/feature20069'Nick Mathewson
2016-09-06Merge remote-tracking branch 'public/ticket20002'Nick Mathewson
2016-09-06checkSpace.pl now forbids more identifiers.Nick Mathewson
The functions it warns about are: assert, memcmp, strcat, strcpy, sprintf, malloc, free, realloc, strdup, strndup, calloc. Also, fix a few lingering instances of these in the code. Use other conventions to indicate _intended_ use of assert and malloc/realloc/etc.
2016-09-06Merge remote-tracking branch 'sebastian/bug20065'Nick Mathewson
2016-09-06Fix an indentation issue in rend_config_servicesteor
2016-09-06Fix a comment typo in smartlist_get_most_frequent_()teor (Tim Wilson-Brown)
2016-09-06Add hs-ipv6 to the chutney IPv6 teststeor
Requires a recent version of chutney. Also remove bridges+hs, as it's somewhat redundant.
2016-09-06Give useful error if authority_signing_key doesn't existSebastian Hahn
2016-09-05Appease make check-spacesAndrea Shepard
2016-09-05Fix BUG warning with stack trace from config/parse_port_config__listenaddressNick Mathewson
2016-09-01Fix memory leaks in the shared random tests.Nick Mathewson
Please remember to test your code with --enable-expensive-hardening. :)
2016-08-31Actually, always monotime_init() in the unit tests.Nick Mathewson
2016-08-31Initialize monotonic timer code before using it in the testsNick Mathewson
2016-08-31It is not a bug to attempt to base32_decode a non-base32 stringNick Mathewson
(Rationale: it isn't a bug to try this for a base16 or base64 string. It's just a bad input that we're detecting.)
2016-08-31Detect and suppress bug message from zlib compression bomb testNick Mathewson
2016-08-31Require specific messages for remaining link-handshake failure casesNick Mathewson
2016-08-31Always log [bug] warnings from the unit tests.Nick Mathewson
We should consider them bugs. If they are happening intentionally, we should use the log_test_helpers code to capture and suppress them. But having them off-by-default has potential to cause programming errors.
2016-08-31Do not call tor_tls_server_info_callback(NULL) from tests.Nick Mathewson
This isn't valid behavior, and it causes a crash when you run the unit tests at --debug. I've added an IF_BUG_ONCE() check for this case.
2016-08-31Work even harder not to suppress logging messages unless we mean to.Nick Mathewson
2016-08-31Document and clean log_test_helpers.c a bitNick Mathewson
In addition to documentation, this commit makes a function static, and removes a weird single-point-of-return-ism, and notes a thing I should fix.
2016-08-31Use setup_full_capture_of_logs() where appropriate.Nick Mathewson
2016-08-31setup_capture_of_logs: no longer suppress log messagesNick Mathewson
Previously setup_capture_of_logs would prevent log messages from going to the console entirely. That's a problem, since sometimes log messages are bugs! Now setup_capture_of_logs() acts sensibly. If you really do need to keep a message from going to the console entirely, there is setup_full_capture_of_logs(). But only use that if you're prepared to make sure that there are no extraneous messages generated at all.
2016-08-31Improvements to test_link_handshake: check specific error messagesNick Mathewson
Otherwise it's too easy to lose our test coverage.
2016-08-31Fix all "BUG" warnings created from link-handshake tests.Nick Mathewson
2016-08-31Another log testing helper helper, for matching partial strings.Nick Mathewson
2016-08-31Don't warn on unlink(bw_accounting) when errno == ENOENTNick Mathewson
Patch from pastly; fixes bug 19964.
2016-08-31Fix a deref-before-null-check complaintNick Mathewson
Found by coverity scan; this is CID 1372329. Also, reindent some oddly indented code.
2016-08-31Stop inadvertently upgrading client intro connections to ntorteor
Also stop logging the intro point details on error by default. Fixes #20012, introduced with ntor in tor 0.2.4.8-alpha.
2016-08-29We no longer need to tag UseNTorHandshake as deprecated, since it is obsoleteNick Mathewson
2016-08-29Merge remote-tracking branch 'teor/reject-tap-v6'Nick Mathewson
2016-08-26test: Fix shared random unit test for big endianDavid Goulet
Copying the integer 42 in a char buffer has a different representation depending on the endianess of the system thus that unit test was failing on big endian system. This commit introduces a python script, like the one we have for SRV, that computes a COMMIT/REVEAL from scratch so we can use it as a test vector for our encoding unit tests. With this, we use a random value of bytes instead of a number fixing the endianess issue and making the whole test case more solid with an external tool that builds the COMMIT and REVEAL according to the spec. Fixes #19977 Signed-off-by: David Goulet <dgoulet@torproject.org>
2016-08-26prop272: When voting, include no non-Valid relays in consensusNick Mathewson
Implements ticket 20002, and part of proposal 272.
2016-08-26Avoid asserts in oos/kill_conn_list unit testAndrea Shepard
2016-08-26Fix OOS comparator fixAndrea Shepard
2016-08-25Fix duplicated if condition in connection.cDavid Goulet
Furthermore, fix a test that could returned an uninitialized value. Signed-off-by: David Goulet <dgoulet@torproject.org>
2016-08-25Merge remote-tracking branch 'andrea/ticket18640_v3'Nick Mathewson
2016-08-24bump to 0.2.9.2-alpha-devNick Mathewson
2016-08-24make check-spaces fixesNick Mathewson
2016-08-24Bump to 0.2.9.2-alphaNick Mathewson
2016-08-24Merge branch 'maint-0.2.8'Nick Mathewson
2016-08-24Fix path selection on firewalled clientsteor
Signed-off-by: teor <teor2345@gmail.com>
2016-08-24Merge branch 'maint-0.2.8'Nick Mathewson
2016-08-24Merge branch 'maint-0.2.7' into maint-0.2.8Nick Mathewson
2016-08-24Replace Tonga with Bifroest.Isis Lovecruft
* FIXES #19728: https://bugs.torproject.org/19728 * CLOSES #19690: https://bugs.torproject.org/19690
2016-08-24Add a stub for rend_service_allow_direct_connectionteor
It always returns 0. It should be replaced with the Single Onion version from #17178 when both are merged.
2016-08-24Client & HS ignore UseNTorHandshake, all non-HS handshakes use ntorteor (Tim Wilson-Brown)
Rely on onion_populate_cpath to check that we're only using TAP for the rare hidden service cases. Check and log if handshakes only support TAP when they should support ntor.
2016-08-24Improve comments in circuit_get_cpath_*teor (Tim Wilson-Brown)
2016-08-24Client & HS make sure every hop in every non-HS path supports ntorteor (Tim Wilson-Brown)
When a client connects to an intro point not in the client's consensus, or a hidden service connects to a rend point not in the hidden service's consensus, we are stuck with using TAP, because there is no ntor link specifier.
7apu2bq3rhoylwmucxizk54afw5jyda7pho4j5zdcqpwkufke7zdzwad.onion