aboutsummaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2013-06-13Don't queue more cells as a middle relay than the spec allows to be in flightAndrea Shepard
2013-06-13Define SEEK_SET for platforms that lack it.Nick Mathewson
2013-06-13If we write the annotation but not the microdescriptor, rewind.Nick Mathewson
This fixes bug 9047 (and some parts of 9031, 8922, 8883 that weren't fixed in 8822). Bugfix on 0.2.2.6-alpha.
2013-06-13Merge remote-tracking branch 'public/bug8822' into maint-0.2.4Nick Mathewson
2013-06-12Merge remote-tracking branch 'andrea/bug8639_v3' into maint-0.2.4Nick Mathewson
2013-06-12Make all consumers of microdesc_t.body tolerate NULLNick Mathewson
This is another fix to try to mitigate recurrences of 8031/8822.
2013-06-12Unmap the microdescriptor cache before replacing it.Nick Mathewson
This is a reprise of the fix in bdff7e3299d78; 6905c1f6 reintroduced that bug. Briefly: windows doesn't seem to like deleting a mapped file. I tried adding the PROT_SHARED_DELETE flag to the createfile all, but that didn't actually fix this issue. Fortunately, the unit test I added in 4f4fc63fea0589a4fa03f3859dc27860cdde75af should prevent us from making this particular screw-up again. This patch also tries to limit the crash potential of a failure to write by a little bit, although it could do a better job of retaining microdescriptor bodies. Fix for bug 8822, bugfix on 0.2.4.12-alpha.
2013-06-12Revert "Use the FILE_SHARE_DELETE flag for CreateFile on a mapping"Nick Mathewson
This reverts commit 884a0e269c382f9e927d8c8b1ef4ef9d2d48379d. I'm reverting this because it doesn't actually make the problem go away. It appears that instead we need to do unmap-then-replace.
2013-06-12Merge remote-tracking branch 'public/bug2077_share_delete' into maint-0.2.4Nick Mathewson
2013-06-12Use the FILE_SHARE_DELETE flag for CreateFile on a mappingNick Mathewson
A comment by rransom on #8795 taken together with a comment by doorss recorded on #2077 suggest that *every* attempt to replace the md cache will fail on Vista/Win7 if we don't have the FILE_SHARE_DELETE flag passed to CreateFile, and if we try to replace the file ourselves before unmapping it. I'm adding the FILE_SHARE_DELETE, since that's this simplest fix. Broken indexers (the favored #2077 hypothesis) could still cause trouble here, but at least this patch should make us stop stepping on our own feet. Likely fix for #2077 and its numerous duplicates. Bugfix on 0.2.2.6-alpha, which first had a microdescriptor cache that would get replaced before remapping it.
2013-06-12Expand microdesc cache testsNick Mathewson
Is it possible that *every* attempt to replace the microdesc cache on windows 7 is going to fail because of our lack of FILE_SHARE_DELETE while opening the file? If so, this test will catch #2077 and let us know when it's fixed.
2013-06-10Merge remote-tracking branch 'origin/maint-0.2.3' into maint-0.2.4Nick Mathewson
2013-06-10Merge branch 'bug9017' into maint-0.2.3Nick Mathewson
2013-06-10Fix (Open?)BSD fast-connect bug with optimistic data.Nick Mathewson
There's an assertion failure that can occur if a connection has optimistic data waiting, and then the connect() call returns 0 on the first attempt (rather than -1 and EINPROGRESS). That latter behavior from connect() appears to be an (Open?)BSDism when dealing with remote addresses in some cases. (At least, I've only seen it reported with the BSDs under libevent, even when the address was 127.0.0.1. And we've only seen this problem in Tor with OpenBSD.) Fixes bug 9017; bugfix on 0.2.3.1-alpha, which first introduced optimistic data. (Although you could also argue that the commented-out connection_start_writing in 155c9b80 back in 2002 is the real source of the issue.)
2013-06-05Merge remote-tracking branch 'origin/maint-0.2.3' into maint-0.2.4Nick Mathewson
2013-06-05Merge remote-tracking branch 'origin/maint-0.2.2' into maint-0.2.3Nick Mathewson
2013-06-05Update to the June 2013 GeoIP database.Karsten Loesing
2013-05-31When launching a resolve request on behalf of an AF_UNIX control, omit the ↵Andrea Shepard
address field of the new entry connection. Fixes bug 8639.
2013-05-21Downgrade the unexpected sendme cell warnings for 0.2.4Nick Mathewson
See discussion on #8093
2013-05-20Copy-paste description of PathBias params from man page to or.h commentAndrea Shepard
2013-05-20Merge remote-tracking branch 'origin/maint-0.2.3' into maint-0.2.4Nick Mathewson
2013-05-20Merge remote-tracking branch 'origin/maint-0.2.2' into maint-0.2.3Nick Mathewson
2013-05-17Fix bug 8846: better log message on IP version confusionNick Mathewson
2013-05-15Fix unit tests to pass after fix for #8879Nick Mathewson
2013-05-15Fix socks5 handshake for username/password authRoger Dingledine
The fix for bug 8117 exposed this bug, and it turns out real-world applications like Pidgin do care. Bugfix on 0.2.3.2-alpha; fixes bug 8879.
2013-05-13Update to the May 2013 GeoIP database.Karsten Loesing
2013-05-10Merge bug5595-v2-squashed into maint-0.2.4Andrea Shepard
2013-05-09Add some unit tests for fp_pair_map_t to test/containers.c based on the ↵Andrea Shepard
strmap tests
2013-05-09Rephrase comment in trusted_dirs_load_certs_from_string() to reflect 5595 fixAndrea Shepard
2013-05-09Make warning in authority_cert_dl_failed() LD_BUG per NickM code reviewAndrea Shepard
2013-05-09Use tor_asprintf() and clean up string handling in ↵Andrea Shepard
authority_certs_fetch_missing()
2013-05-09Clean up ugly constants in connection_dir_download_cert_failed(), and fix a ↵Andrea Shepard
broken one
2013-05-09Avoid duplicate downloads by (fp,sk) and by fp for authority certs when ↵Andrea Shepard
bootstrapping
2013-05-09When downloading certificates, distinguish requesting by identity digest ↵Andrea Shepard
from requesting by ID digest, signing key pair; fixes bug 5595
2013-05-09Implement fp_pair_map_tAndrea Shepard
2013-05-09Merge remote-tracking branch 'origin/maint-0.2.3' into maint-0.2.4Nick Mathewson
2013-05-09Don't run off the end of the array-of-freelistsNick Mathewson
This is a fix for bug 8844, where eugenis correctly notes that there's a sentinel value at the end of the list-of-freelists that's never actually checked. It's a bug since the first version of the chunked buffer code back in 0.2.0.16-alpha. This would probably be a crash bug if it ever happens, but nobody's ever reported something like this, so I'm unsure whether it can occur. It would require write_to_buf, write_to_buf_zlib, read_to_buf, or read_to_buf_tls to get an input size of more than 32K. Still, it's a good idea to fix this kind of thing!
2013-05-08Fix bug 8845: check the right length of memory in aes unit testsNick Mathewson
This couldn't actually be a buffer overrun unless AES somehow turned into memcpy, but still it's good to fix it.
2013-05-05Use a clearer idiom for node identity in router_counts_toward_thresholdsNick Mathewson
2013-05-05Fix 8833: crash bug from using NULL node->ri in dirserv.cNick Mathewson
It appears that moria1 crashed because of one instance of this (the one in router_counts_toward_thresholds). The other instance I fixed won't actually have broken anything, but I think it's more clear this way. Fixes bug 8833; bugfix on 0.2.4.12-alpha.
2013-04-24Merge remote-tracking branch 'public/bug6026' into maint-0.2.4Nick Mathewson
2013-04-24Increase the pathbias state file miscounting version check.Mike Perry
We now know the bug is present in 0.2.4.12-alpha too. It should be fixed in 0.2.4.13-alpha, though.
2013-04-24Bug 8235: Fix scaling adjustments.Mike Perry
We need to subtract both the current built circuits *and* the attempted circuits from the attempt count during scaling, since *both* have already been counted there.
2013-04-18Add a boolean to flag-thresholds for "we have enough measured bandwidth"Nick Mathewson
Implements #8711.
2013-04-18Merge remote-tracking branch 'public/bug8716_023' into maint-0.2.4Nick Mathewson
2013-04-18Merge remote-tracking branch 'public/bug8719' into maint-0.2.4Nick Mathewson
2013-04-18Remove a double-newlineNick Mathewson
2013-04-18Merge branch 'less_charbuf_rebased' into maint-0.2.4Nick Mathewson
Conflicts: src/or/dirserv.c src/or/dirserv.h src/test/test_dir.c
2013-04-18Add unit test for encoding ntor key in routerinfoNick Mathewson
2013-04-18Remove the unused pk3 variable from test_dir_formatsNick Mathewson
7apu2bq3rhoylwmucxizk54afw5jyda7pho4j5zdcqpwkufke7zdzwad.onion