| Age | Commit message (Collapse) | Author | |
|---|---|---|---|
| 2017-06-28 | ed25519: Also check that retval in the ref10 implementation. | George Kadianakis | |
| 2017-06-28 | ed25519: Check retval of unpack_negative_vartime in donna. | George Kadianakis | |
| 2017-06-27 | Merge branch 'maint-0.3.1' | Nick Mathewson | |
| 2017-06-27 | Return "304 not modified" if a client already have the most recent consensus. | Alexander Færøy | |
| This makes our directory code check if a client is trying to fetch a document that matches a digest from our latest consensus document. See: https://bugs.torproject.org/22702 | |||
| 2017-06-27 | Set published_out for consensus cache entries in ↵ | Alexander Færøy | |
| spooled_resource_estimate_size(). This patch ensures that the published_out output parameter is set to the current consensus cache entry's "valid after" field. See: https://bugs.torproject.org/22702 | |||
| 2017-06-27 | Merge branch 'asn_bug22006_final_squashed' | Nick Mathewson | |
| 2017-06-27 | no newlines in log messages. | Nick Mathewson | |
| 2017-06-27 | whitespace fix | Nick Mathewson | |
| 2017-06-27 | Merge branch 'asn_bug22006_final_squashed' | Nick Mathewson | |
| 2017-06-27 | ed25519: Dirauths validate router ed25519 pubkeys before pinning. | George Kadianakis | |
| 2017-06-27 | ed25519: Add unittests for ed25519 pubkey validation. | George Kadianakis | |
| 2017-06-27 | ed25519: Add func that checks for torsion component in pubkeys. | George Kadianakis | |
| See https://lists.torproject.org/pipermail/tor-dev/2017-April/012213.html . | |||
| 2017-06-27 | Merge branch 'maint-0.3.0' into maint-0.3.1 | Nick Mathewson | |
| 2017-06-27 | Merge branch 'maint-0.3.1' | Nick Mathewson | |
| 2017-06-27 | Merge branch 'maint-0.2.9' into maint-0.3.0 | Nick Mathewson | |
| 2017-06-27 | Merge branch 'maint-0.2.8' into maint-0.2.9 | Nick Mathewson | |
| 2017-06-27 | Merge branch 'maint-0.2.7-redux' into maint-0.2.8 | Nick Mathewson | |
| 2017-06-27 | Merge branch 'maint-0.2.6' into maint-0.2.7-redux | Nick Mathewson | |
| 2017-06-27 | Merge branch 'maint-0.2.5' into maint-0.2.6 | Nick Mathewson | |
| 2017-06-27 | Merge branch 'maint-0.2.4' into maint-0.2.5 | Nick Mathewson | |
| 2017-06-27 | Fix an errant memset() into the middle of a struct in cell_pack(). | Nick Mathewson | |
| This mistake causes two possible bugs. I believe they are both harmless IRL. BUG 1: memory stomping When we call the memset, we are overwriting two 0 bytes past the end of packed_cell_t.body. But I think that's harmless in practice, because the definition of packed_cell_t is: // ... typedef struct packed_cell_t { TOR_SIMPLEQ_ENTRY(packed_cell_t) next; char body[CELL_MAX_NETWORK_SIZE]; uint32_t inserted_time; } packed_cell_t; So we will overwrite either two bytes of inserted_time, or two bytes of padding, depending on how the platform handles alignment. If we're overwriting padding, that's safe. If we are overwriting the inserted_time field, that's also safe: In every case where we call cell_pack() from connection_or.c, we ignore the inserted_time field. When we call cell_pack() from relay.c, we don't set or use inserted_time until right after we have called cell_pack(). SO I believe we're safe in that case too. BUG 2: memory exposure The original reason for this memset was to avoid the possibility of accidentally leaking uninitialized ram to the network. Now remember, if wide_circ_ids is false on a connection, we shouldn't actually be sending more than 512 bytes of packed_cell_t.body, so these two bytes can only leak to the network if there is another bug somewhere else in the code that sends more data than is correct. Fortunately, in relay.c, where we allocate packed_cell_t in packed_cell_new() , we allocate it with tor_malloc_zero(), which clears the RAM, right before we call cell_pack. So those packed_cell_t.body bytes can't leak any information. That leaves the two calls to cell_pack() in connection_or.c, which use stack-alocated packed_cell_t instances. In or_handshake_state_record_cell(), we pass the cell's contents to crypto_digest_add_bytes(). When we do so, we get the number of bytes to pass using the same setting of wide_circ_ids as we passed to cell_pack(). So I believe that's safe. In connection_or_write_cell_to_buf(), we also use the same setting of wide_circ_ids in both calls. So I believe that's safe too. I introduced this bug with 1c0e87f6d8c7a0abdadf1b5cd9082c10abc7f4e2 back in 0.2.4.11-alpha; it is bug 22737 and CID 1401591 | |||
| 2017-06-27 | Merge branch 'maint-0.3.1' | Nick Mathewson | |
| 2017-06-27 | Merge branch 'bug22719_031' into maint-0.3.1 | Nick Mathewson | |
| 2017-06-26 | Merge branch 'maint-0.3.1' | Nick Mathewson | |
| 2017-06-26 | Merge branch 'bug22105_031' into maint-0.3.1 | Nick Mathewson | |
| 2017-06-26 | Merge branch 'maint-0.3.1' | Nick Mathewson | |
| 2017-06-26 | Patch for 22720 from huyvq: exit(1) more often | Nick Mathewson | |
| See changes file for full details. | |||
| 2017-06-26 | Merge branch 'maint-0.3.1' | Nick Mathewson | |
| 2017-06-26 | Merge branch 'bug22212_squashed' into maint-0.3.1 | Nick Mathewson | |
| 2017-06-26 | Demote a log message due to libevent delays. | Mike Perry | |
| This is a side-effect of being single-threaded. The worst cases of this are actually Bug #16585. | |||
| 2017-06-26 | Merge branch 'maint-0.3.1' | Nick Mathewson | |
| 2017-06-26 | Fix a coverity warning about a no-op assert with-64 bit size_t | Nick Mathewson | |
| This is CID 1403400 | |||
| 2017-06-26 | Try a little harder to make sure we never call tor_compress_process wrong. | Nick Mathewson | |
| 2017-06-24 | Log even more to try to debug 22719 | Nick Mathewson | |
| 2017-06-24 | Add an additional log message to try to diagnose #22719 | Nick Mathewson | |
| 2017-06-23 | Merge remote-tracking branch 'isis/bug4019' | Nick Mathewson | |
| 2017-06-23 | Merge branch 'bug3056_squashed' | Nick Mathewson | |
| 2017-06-23 | Improve clarity, safety, and rate of dns spoofing log msg | Nick Mathewson | |
| Closes ticket 3056. | |||
| 2017-06-22 | Merge branch 'maint-0.3.0' into maint-0.3.1 | Nick Mathewson | |
| 2017-06-22 | Merge branch 'maint-0.3.1' | Nick Mathewson | |
| 2017-06-22 | Combine our "don't do this if no consensus" entryguards checks | Nick Mathewson | |
| Suggested by asn on 22400 review. | |||
| 2017-06-22 | whitespace fix | Nick Mathewson | |
| 2017-06-22 | Merge remote-tracking branch 'rl1987/bug22461' | Nick Mathewson | |
| 2017-06-22 | Merge remote-tracking branch 'public/bug7890' | Nick Mathewson | |
| 2017-06-22 | config: Fix duplicate error message for nonlocal SocksPorts. | Isis Lovecruft | |
| If `validate_only` is true, then just validate the configuration without warning about it. This way, we only emit warnings when the listener is actually opened. (Otherwise, every time we parse the config we will might re-warn and we would need to keep state; whereas the listeners are only opened once.) * FIXES #4019. | |||
| 2017-06-21 | make assign_onionskin_to_cpuworker failure case more clear | Roger Dingledine | |
| now it looks like the other time we call it | |||
| 2017-06-21 | Merge branch 'callgraph_reduction_v2' | Nick Mathewson | |
| 2017-06-21 | Extract channel_do_open_actions() from non-open _change_state cases | Nick Mathewson | |
| This reduces the size of the largest SCC in the callgraph by 30 functions, from 58 to 28. | |||
| 2017-06-21 | Merge branch 'maint-0.3.1' | Nick Mathewson | |
| 2017-06-21 | Merge branch 'bug22356_029' into maint-0.3.1 | Nick Mathewson | |
 |
index : tor | |
| Transit encryption and privacy out of the box | The Tor Project |
| aboutsummaryrefslogtreecommitdiff |