aboutsummaryrefslogtreecommitdiff
path: root/src/test
AgeCommit message (Collapse)Author
2016-06-11Merge branch 'bug19180_easy_squashed'Nick Mathewson
2016-06-11Add clang's -Wstring-conversion, and fix the one place it hitsNick Mathewson
2016-06-11Add -Wmissing-variable-declarations, with attendant fixesNick Mathewson
This is a big-ish patch, but it's very straightforward. Under this clang warning, we're not actually allowed to have a global variable without a previous extern declaration for it. The cases where we violated this rule fall into three roughly equal groups: * Stuff that should have been static. * Stuff that was global but where the extern was local to some other C file. * Stuff that was only global when built for the unit tests, that needed a conditional extern in the headers. The first two were IMO genuine problems; the last is a wart of how we build tests.
2016-06-11Add the -Wextra-semi warning from clang, and fix the cases where it triggersNick Mathewson
2016-06-11Resolve some warnings from OSX clang.Nick Mathewson
2016-06-11Use autoconf, not gcc version, to decide which warnings we haveNick Mathewson
This gives more accurate results under Clang, which can only help us detect more warnings in more places. Fixes bug 19216; bugfix on 0.2.0.1-alpha
2016-06-11Enable -Woverlength-strings for GCC>=4.6 on MOST of the code.Nick Mathewson
IMO it's fine for us to make exceptions to this rule in the unit tests, but not in the code at large.
2016-06-11Use -Wdouble-promotion in GCC >= 4.6Nick Mathewson
This warning triggers on silently promoting a float to a double. In our code, it's just a sign that somebody used a float by mistake, since we always prefer double.
2016-06-11Add -Wfloat-conversion for GCC >= 4.9Nick Mathewson
This caught quite a few minor issues in our unit tests and elsewhere in our code.
2016-06-11Enable -Wnull-dereference (GCC >=6.1), and fix the easy casesNick Mathewson
This warning, IIUC, means that the compiler doesn't like it when it sees a NULL check _after_ we've already dereferenced the variable. In such cases, it considers itself free to eliminate the NULL check. There are a couple of tricky cases: One was the case related to the fact that tor_addr_to_in6() can return NULL if it gets a non-AF_INET6 address. The fix was to create a variant which asserts on the address type, and never returns NULL.
2016-06-09Reduce make check-spaces noiseAndrea Shepard
2016-06-06Repair test_crypto_openssl_version with LibreSSLNick Mathewson
2016-06-06Check tor_sscanf return value in test_crypto.cNick Mathewson
Coverity noticed that we check tor_sscanf's return value everywhere else.
2016-06-02Use tor_sscanf, not sscanf, in test_crypto.cNick Mathewson
Fixes the 0.2.9 instance of bug #19213, which prevented mingw64 from working. This case wasn't in any released Tor.
2016-06-02Merge branch 'maint-0.2.8'Nick Mathewson
2016-06-02Merge branch 'maint-0.2.7' into maint-0.2.8Nick Mathewson
2016-06-02Use tor_sscanf, not sscanf, in test_util.c.Nick Mathewson
Fixes the 0.2.7 case of bug #19213, which prevented mingw64 from working.
2016-05-30Let's not even talk about those errors, ok?Nick Mathewson
2016-05-30Wait, we had sprintf() in our unit tests?? FOR SHAME!Nick Mathewson
2016-05-30Replace nearly all XXX0vv comments with smarter onesNick Mathewson
So, back long ago, XXX012 meant, "before Tor 0.1.2 is released, we had better revisit this comment and fix it!" But we have a huge pile of such comments accumulated for a large number of released versions! Not cool. So, here's what I tried to do: * 0.2.9 and 0.2.8 are retained, since those are not yet released. * XXX+ or XXX++ or XXX++++ or whatever means, "This one looks quite important!" * The others, after one-by-one examination, are downgraded to plain old XXX. Which doesn't mean they aren't a problem -- just that they cannot possibly be a release-blocking problem.
2016-05-27Merge remote-tracking branch 'arma/task19035-fixedup'Nick Mathewson
2016-05-27Disable GET /tor/bytes.txt and GETINFO dir-usageRoger Dingledine
Remove support for "GET /tor/bytes.txt" DirPort request, and "GETINFO dir-usage" controller request, which were only available via a compile-time option in Tor anyway. Feature was added in 0.2.2.1-alpha. Resolves ticket 19035.
2016-05-25Merge branch 'maint-0.2.8'Nick Mathewson
2016-05-25Merge branch 'bug18668_028' into maint-0.2.8Nick Mathewson
2016-05-25Merge branch 'maint-0.2.8'Nick Mathewson
2016-05-24Make sure that libscrypt_scrypt actually exists before using it.Nick Mathewson
Previously, if the header was present, we'd proceed even if the function wasn't there. Easy fix for bug 19161. A better fix would involve trying harder to find libscrypt_scrypt.
2016-05-20Prevent ASAN from registering a SIGSEGV handlercypherpunks
AddressSanitizer's (ASAN) SIGSEGV handler overrides the backtrace handler and prevents it from printing its backtrace. The output of ASAN is different from what 'bt_test.py' expects and causes backtrace test failures. The 'allow_user_segv_handler' option allows applications to set their own SIGSEGV handler but is not supported by older GCC versions. These older GCC versions do support the 'handle_segv' which prevents ASAN from setting its SIGSEGV handler.
2016-05-19Remove round_int64_to_next_multiple_of: It is now unused.Nick Mathewson
2016-05-19Merge branch 'maint-0.2.8'Nick Mathewson
2016-05-19Merge remote-tracking branch 'teor/fix18809-warnings' into maint-0.2.8Nick Mathewson
2016-05-19Merge branch 'maint-0.2.8'Nick Mathewson
2016-05-19Merge remote-tracking branch 'public/bug19073' into maint-0.2.8Nick Mathewson
2016-05-19Fix unused-but-set-variable warnings in the connection unit teststeor (Tim Wilson-Brown)
No behaviour change - just remove the variables
2016-05-19Merge branch 'maint-0.2.8'Nick Mathewson
2016-05-19Fix a compilation error in test_dir.cNick Mathewson
2016-05-19Merge branch 'maint-0.2.8'Nick Mathewson
2016-05-19Merge branch 'bug18809_028_squashed' into maint-0.2.8Nick Mathewson
2016-05-19Add unit tests for networkstatus_consensus_is_bootstrappingteor (Tim Wilson-Brown)
2016-05-19Restore and improve download schedule unit teststeor (Tim Wilson-Brown)
2016-05-19Update unit tests for multiple bootstrap connectionsteor (Tim Wilson-Brown)
2016-05-18Fix a bad sizeof() in test_crypto.c. Harmless. Spotted by coverity.Nick Mathewson
2016-05-17Remove duplicate siging_key_cert fields.Nick Mathewson
With the fix for #17150, I added a duplicate certificate here. Here I remove the original location in 0.2.8. (I wouldn't want to do that in 027, due to the amount of authority-voting-related code drift.) Closes 19073.
2016-05-17Merge remote-tracking branch 'teor/bug18963-remember-v2'Nick Mathewson
2016-05-17Merge branch 'maint-0.2.8'Nick Mathewson
2016-05-16Initialize networking _before_ initializing libevent in the testsNick Mathewson
This prevents WSANOTINITIALISED errors and fixes bug 18668. Bugfix on 0.2.8.1-alpha -- 1bac468882fd732460d8a25735131 specifically.
2016-05-16Fix memory leak in test_crypto_aes_ctr_testvecNick Mathewson
2016-05-16Windows lacks truncate(3).Nick Mathewson
Fix the new crypto tests, which used truncate(3).
2016-05-16Merge branch 'crypto_unit_tests_v2_squashed'Nick Mathewson
2016-05-16Cover all our DH code, and/or mark it unreachable.Nick Mathewson
2016-05-16At long last, unit tests for degenerate DH public keys.Nick Mathewson
Apparently, we detect and reject them correctly. Aren't you glad?
7apu2bq3rhoylwmucxizk54afw5jyda7pho4j5zdcqpwkufke7zdzwad.onion