Age | Commit message (Collapse) | Author |
|
|
|
|
|
Coverity wants us to free everything that we are potentially
allocating, even stuff where allocating it would be a bug. Adding
a smartlist_free() here will fix the warning.
Fixes bug 31452; bugfix on 16a0b7ed6779bf72a8a471c, which is not in
any released Tor. This is CID 1447292.
|
|
When we consider all circuits in "waiting for guard" state to be promoted to
an "open" state, we were considering all circuits, even the one marked for
close.
This ultiamtely triggers a "circuit_has_opened()" called on the circuit that
is marked for close which then leads to possible undesirable behaviors within
a subsystem.
For instance, the HS subsystem would be unable to find the authentication key
of the introduction point circuit leading to a BUG() warning and a duplicate
mark for close on the circuit.
This commit also adds a unit test to make sure we never select marked for
close circuits when upgrading its guard state from waiting for guard to open.
Fixes #30871
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
|
|
|
|
|
node_has_preferred_descriptor()
|
|
I am very glad to have written this script.
|
|
|
|
|
|
|
|
|
|
Capture the warning for the unhandled circuit purpose test case, both
to clean up the test log and to confirm that it gets logged.
|
|
Check that route_len_for_purpose() (helper for new_route_len())
correctly fails a non-fatal bug assertion if it encounters an
unhandled circuit purpose when it is called with exit node info.
|
|
|