aboutsummaryrefslogtreecommitdiff
path: root/src/test/test_address.c
AgeCommit message (Collapse)Author
2021-10-04net: Reject invalid characters in port rangesc
Fixes issue #22469 where port strings such as '0x00' get accepted, not because the string gets converted to hex, but because the string is silently truncated past the invalid character 'x'. This also causes issues for strings such as '0x01-0x02' which look like a hex port range, but in reality gets truncated to '0', which is definitely not what a user intends. Warn and reject such port strings as invalid. Also, since we're throwing that "malformed port" warning a lot in the function, wrap it up in a nice goto. Fixes #22469
2021-03-12Update copyrights to 2021, using "make update-copyright"Nick Mathewson
2020-11-12Fix typos.Samanta Navarro
Typos found with codespell. Please keep in mind that this should have impact on actual code and must be carefully evaluated: src/core/or/lttng_circuit.inc - ctf_enum_value("CONTROLER", CIRCUIT_PURPOSE_CONTROLLER) + ctf_enum_value("CONTROLLER", CIRCUIT_PURPOSE_CONTROLLER)
2020-07-14addr: Use tor_addr_t instead of uint32_t for IPv4David Goulet
This changes a LOT of code but in the end, behavior is the same. Unfortunately, many functions had to be changed to accomodate but in majority of cases, to become simpler. Functions are also removed specifically those that were there to convert an IPv4 as a host format to a tor_addr_t. Those are not needed anymore. The IPv4 address field has been standardized to "ipv4_addr", the ORPort to "ipv4_orport" (currently IPv6 uses ipv6_orport) and DirPort to "ipv4_dirport". This is related to Sponsor 55 work that adds IPv6 support for relays and this work is needed in order to have a common interface between IPv4 and IPv6. Closes #40043. Signed-off-by: David Goulet <dgoulet@torproject.org>
2020-06-30node: Rename addrs_in_same_network_family()David Goulet
New name reflects that the function is only used to compare router addresses in order to learn if they are in the same network. The network check is /16 and /32 respectively for IPv4 and IPv6. Related to #40009 Signed-off-by: David Goulet <dgoulet@torproject.org>
2020-04-30net: Make all address bytes functions take uint8_t *teor
Part of 33817.
2020-01-08It's 2020. Update the copyright dates with "make update-copyright"Nick Mathewson
2019-09-19test: test dirserv_router_has_valid_address() with DirAllowPrivateAddressesteor
Part of 31793.
2019-09-19test: refactor dirserv_router_has_valid_address() teststeor
Cleanup after 31793.
2019-09-19test: dirserv_router_has_valid_address() with zero-family addressesteor
Sometimes tor doesn't initialise an address, so its family is zero. Failing test for 31793. Future commits will fix the code.
2019-08-26test_address: parenthesize macro arguments.Nick Mathewson
It's good style to always add parentheses when using macro arguments, in case somebody someday provides an argument that contains an operator you don't expect, or causes the expression to parse differently.
2019-08-26In tests, make sure that "ri" is freed on all paths.Nick Mathewson
In Tor's tests, the tt_*() macros can call "goto done" on failure. When that happens, we need to make sure that all of our allocated memory still gets freed, or else Coverity will complain.
2019-08-26Add test for dirserv_router_has_valid_address()Neel Chauhan
2019-02-19Downgrade some LOG_ERR messages in the address/* tests to warningsNick Mathewson
Fixes bug 29530, where the LOG_ERR messages were occurring when we had no configured network, and so we were failing the unit tests because of the recently-merged #28668. Bug not in any released Tor.
2019-01-23Merge branch 'ticket28668_035' into ticket28668_040Nick Mathewson
2019-01-23If address/get_if_addrs6 can't findipv6, log WARN, not ERRNick Mathewson
Fixes 29160, and allows 28668 (treating ERR logs as test failures) to procede.
2019-01-16Bump copyright date to 2019Nick Mathewson
2019-01-16Bump copyright date to 2019.Nick Mathewson
2018-11-02Update address tests to avoid offending coverity.Nick Mathewson
2018-10-31Add test for nodes_in_same_family()Neel Chauhan
2018-08-21Remove duplicate include in src/test/test_address.cNeel Chauhan
2018-08-17In addrs_in_same_network_family(), choose IP subnet size based on IP typeNeel Chauhan
2018-07-05Fix every include path changed in the previous commit (automated)Nick Mathewson
I am very glad to have written this script.
2018-06-27rectify include paths (automatic) for address.hNick Mathewson
2018-06-20Run rectify_include_paths.pyNick Mathewson
2018-06-20Update copyrights to 2018.Nick Mathewson
2018-02-21Revert 4438ef32's changes to test_address.cNick Mathewson
Apparently some versions of the mac sdk care about the ordering of net/if.h wrt other headers. Fixes bug 25319; bug not in any released tor.
2018-02-20Remove a bunch of other redundant #includesNick Mathewson
Folks have found two in the past week or so; we may as well fix the others. Found with: \#!/usr/bin/python3 import re def findMulti(fname): includes = set() with open(fname) as f: for line in f: m = re.match(r'^\s*#\s*include\s+["<](\S+)[>"]', line) if m: inc = m.group(1) if inc in includes: print("{}: {}".format(fname, inc)) includes.add(m.group(1)) import sys for fname in sys.argv[1:]: findMulti(fname)
2017-12-08Convert the rest of src/common's headers to use FREE_AND_NULLNick Mathewson
2017-09-15Run our #else/#endif annotator on our source code.Nick Mathewson
2017-08-24apply ahf's test_assert_null.cocciNick Mathewson
2017-08-24apply ahf's test_assert_int.cocciNick Mathewson
2017-08-24Fix operator usage in src/test/*.cAlexander Færøy
This patch fixes the operator usage in src/test/*.c to use the symbolic operators instead of the normal C comparison operators. This patch was generated using: ./scripts/coccinelle/test-operator-cleanup src/test/*.[ch]
2017-03-15Run the copyright update script.Nick Mathewson
2016-11-16fixup! Add expect_log_msg_containing_either3() and ↵teor
expect_log_msg_containing_either4() Fix typos: * extra '(' * use assert_log_predicate (without 3 or 4 at the end) Tidy whitespace. Wrap long lines.
2016-11-16Add all four error messages to test_address_get_if_addrs6_list_no_internal()Neel Chauhan
2016-11-16Add all four error messages to test_address_get_if_addrs6_list_internal()Neel Chauhan
2016-09-09make check-spacesNick Mathewson
2016-09-09Fix cases where the tests were doing closesocket() on a non-socketNick Mathewson
These seem to have caused warnings on windows. Hmmm.
2016-09-08Placate "make check-spaces"Nick Mathewson
2016-09-08Simplify log_test_helpers interfaceNick Mathewson
Previously, you needed to store the previous log severity in a local variable, and it wasn't clear if you were allowed to call these functions more than once.
2016-09-08Tolerate another failure mode of get_if_addres6_list in testsNick Mathewson
2016-08-31Use setup_full_capture_of_logs() where appropriate.Nick Mathewson
2016-07-28Fix a huge pile of -Wshadow warnings.Nick Mathewson
These appeared on some of the Jenkins platforms. Apparently some GCCs care when you shadow globals, and some don't.
2016-07-17Keep make check-spaces happyAndrea Shepard
2016-07-06Capture the LOG_ERR messages in our tests that had logged errors.Nick Mathewson
(It's confusing for the test to write an expected error to stdout, and then tell the user "OK".)
2016-02-27Update the copyright year.Nick Mathewson
2016-02-23Add missing check to test_address_get_if_addrs_ifaddrs. Bug 18378Nick Mathewson
2016-02-01Merge branch 'maint-0.2.7'Nick Mathewson
(We already had a fix for the address test freebsd issues)
2016-02-01Try to fix address tests on FreeBSDNick Mathewson
In jails, there is not always a localhost. Bugfix not on any released Tor.
7apu2bq3rhoylwmucxizk54afw5jyda7pho4j5zdcqpwkufke7zdzwad.onion