summaryrefslogtreecommitdiff
path: root/src/or
AgeCommit message (Collapse)Author
2016-05-11Merge branch 'bug18761_028_squashed' into maint-0.2.8Nick Mathewson
2016-05-11Log find_rp_for_intro_() failures at LOG_PROTOCOL_WARN.Nick Mathewson
Closes ticket 18761. Also fix a whitespace issue.
2016-05-10Switch between fallback and authority when auth cert fetch failsteor (Tim Wilson-Brown)
2016-05-10Use the consensus download schedule for authority certificatesteor (Tim Wilson-Brown)
Previously, we were using the generic schedule for some downloads, and the consensus schedule for others. Resolves ticket 18816; fix on fddb814fe in 0.2.4.13-alpha.
2016-05-05Refactor router_pick_directory_server_impl to use node functionsteor (Tim Wilson-Brown)
No behavioural change This makes the use of the node explicit in the function, rather than hiding the node lookup in fascist_firewall_allows_rs.
2016-05-05Comment-only change to clarify routerstatus_t IPv4 byte orderteor (Tim Wilson-Brown)
2016-05-05Rename skip_or and skip_dir to avoid confusionteor (Tim Wilson-Brown)
Variable rename only
2016-05-05Merge branch 'feature18483-028-v2-squashed' into maint-0.2.8Nick Mathewson
2016-05-05Only choose directory DirPorts on relaysteor (Tim Wilson-Brown)
2016-05-05Make clients only select directories with reachable ORPortsteor (Tim Wilson-Brown)
This makes sure clients will only select relays which support begindir over ORPort.
2016-05-05Make clients always use begindir for directory requeststeor (Tim Wilson-Brown)
This improves client anonymity and avoids directory header tampering. The extra load on the authorities should be offset by the fallback directories feature. This also simplifies the fixes to #18809.
2016-05-05Make directory node selection more reliableteor (Tim Wilson-Brown)
Delete an unnecessary check for non-preferred IP versions. Allows clients which can't reach any directories of their preferred IP address version to get directory documents. Patch on #17840 in 0.2.8.1-alpha.
2016-05-04Merge branch 'bug18921_squashed' into maint-0.2.8Nick Mathewson
2016-05-04Choose the correct address for one-hop connectionsteor (Tim Wilson-Brown)
After #17840 in 0.2.8.1-alpha, we incorrectly chose an IPv4 address for all DIRIND_ONEHOP directory connections, even if the routerstatus didn't have an IPv4 address. This likely affected bridge clients with IPv6 bridges. Resolves #18921.
2016-05-04Merge branch 'bug18710_025' into maint-0.2.8Nick Mathewson
2016-05-04Fix dnsserv.c assertion when no supported questions are requested.Scott Dial
The problem is that "q" is always set on the first iteration even if the question is not a supported question. This set of "q" is not necessary, and will be handled after exiting the loop if there if a supported q->type was found. [Changes file by nickm] lease enter the commit message for your changes. Lines starting
2016-05-02(cherry-picked by nickm, with changes file from isis.)s0rlxmh0
2016-04-26April 2016 fallbacks for 0.2.8-rcteor (Tim Wilson-Brown)
2016-04-07Turn TestingClientBootstrap* into non-testing optionsDavid Goulet
This changes simply renames them by removing "Testing" in front of them and they do not require TestingTorNetwork to be enabled anymore. Fixes #18481 Signed-off-by: David Goulet <dgoulet@ev0ke.net>
2016-04-05quiet debug logs from periodic_event_dispatch()Roger Dingledine
Stop blasting twelve lines per second from periodic_event_dispatch() at loglevel debug. Resolves ticket 18729; fix on 0.2.8.1-alpha.
2016-04-01Merge branch 'bug18133_027' into maint-0.2.8Nick Mathewson
2016-04-01fix indentationNick Mathewson
2016-04-01Merge remote-tracking branch 'karsten/task-18460-2' into maint-0.2.8Nick Mathewson
2016-03-28Fix my dumb unreleased bug in 18673Nick Mathewson
2016-03-28Fix memory leak in TestingEnableCellStatsEventNick Mathewson
Only when we were actually flushing the cell stats to a controller would we free them. Thus, they could stay in RAM even after the circuit was freed (eg if we didn't have any controllers). Fixes bug 18673; bugfix on 0.2.5.1-alpha.
2016-03-28Fix memory leaks that stopped chutney working with asanNick Mathewson
2016-03-28Fix memory-counting error in rephist.c. Bug 18651. (Now with actual patch)Nick Mathewson
2016-03-26Do not treat "DOCDOC" as doxygen.Nick Mathewson
2016-03-26Whitespace fixesNick Mathewson
2016-03-26Fix all doxygen warnings (other than missing docs)Nick Mathewson
2016-03-26Clarify excess consensus connection cleanup by adding commentsteor (Tim Wilson-Brown)
Comment-only change
2016-03-25Include IPv6 consensus downloads in dirreq stats.Karsten Loesing
Fixes #18460.
2016-03-24use a clearer argument for connection_ap_make_link()Roger Dingledine
that function calls it argument "want_onehop", so it makes more sense to pass that boolean into it.
2016-03-24remove the extraneous dir_port variableRoger Dingledine
we already are using "port" to describe the place we're going to ask to connect to.
2016-03-24remove a redundant check about whether dirport is 0Roger Dingledine
2016-03-24revert the or_connection and dir_connection flagsRoger Dingledine
They incorrectly summarized what the function was planning to do, leading to wrong behavior like making an http request to an orport, or making a begindir request to a dirport. This change backs out some of the changes made in commit e72cbf7a, and most of the changes made in commit ba6509e9. This patch resolves bug 18625. There more changes I want to make after this one, for code clarity.
2016-03-24Fix broken directory request to the DirPortDavid Goulet
Commit e72cbf7a4 introduced a change to directory_initiate_command_rend() that made tor use the ORPort when making a directory request to the DirPort. The primary consequence was that a relay couldn't selftest its DirPort thus failing to work and join the network properly. The main issue was we were always considering an anonymized connection to be an OR connection which is not true. Fixes #18623 Signed-off-by: David Goulet <dgoulet@ev0ke.net>
2016-03-24Merge branch 'bug18517_squashed'Nick Mathewson
2016-03-24Always allow OR connections to bridges on private addressesteor (Tim Wilson-Brown)
Regardless of the setting of ExtendAllowPrivateAddresses. This fixes a bug with pluggable transports that ignore the (potentially private) address in their bridge line. Fixes bug 18517; bugfix on 23b088907f in tor-0.2.8.1-alpha.
2016-03-24Merge remote-tracking branch 'teor/bug18351'Nick Mathewson
2016-03-24Merge remote-tracking branch 'teor/bug18489'Nick Mathewson
2016-03-24Check if fallbacks support extrainfo descriptors before requesting themteor (Tim Wilson-Brown)
When requesting extrainfo descriptors from a trusted directory server, check whether it is an authority or a fallback directory which supports extrainfo descriptors. Fixes bug 18489; bugfix on 90f6071d8d in tor-0.2.4.7-alpha. Reported by "atagar", patch by "teor".
2016-03-24Code indentation whitespace-only fixteor (Tim Wilson-Brown)
2016-03-24Clarify ReachableAddress log messagesteor (Tim Wilson-Brown)
Make it clearer that they are about outgoing connection attempts. Specify the options involved where they were missing from one log message. Clarify a comment.
2016-03-24Downgrade IP version warnings to avoid filling logsteor (Tim Wilson-Brown)
Downgrade logs and backtraces about IP versions to info-level. Only log backtraces once each time tor runs. Assists in diagnosing bug 18351; bugfix on c3cc8e16e in tor-0.2.8.1-alpha. Reported by "sysrqb" and "Christian", patch by "teor".
2016-03-22Merge remote-tracking branch 'public/bug18253'Nick Mathewson
2016-03-21remove extraneous breaksRoger Dingledine
commit edeba3d4 removed a switch, but left the "break" lines in from that switch. fortunately the resulting behavior was not wrong, since there was an outer switch that it was ok to break from.
2016-03-21fix indentation after #18332 patchesRoger Dingledine
no actual changes here -- but the new indenting makes it clear that the fixes in #18332 were not as good as they should have been. the next commit will deal with that.
2016-03-21Merge branch 'maint-0.2.7'Nick Mathewson
2016-03-21Use nth consistently in dircollate.h.Nick Mathewson
Documentation-only patch. Issue 17668.T6.