summaryrefslogtreecommitdiff
path: root/src/or
AgeCommit message (Collapse)Author
2014-09-15Clean up a clangalyzer warning in directory_remove_invalidNick Mathewson
"At this point in the code, msg has been set to a string constant. But the tor code checks that msg is not NULL, and the redundant NULL check confuses the analyser[...] To avoid this spurious warning, the patch initialises msg to NULL." Patch from teor. another part of 13157.
2014-09-13fix typo in commentRoger Dingledine
2014-09-11Whitespace cleanups in transports/test_ptNick Mathewson
2014-09-11Merge remote-tracking branch 'origin/maint-0.2.5'Nick Mathewson
2014-09-11Reduce log severity for unused ClientTransportPlugin linesRoger Dingledine
Tor Browser includes several ClientTransportPlugin lines in its torrc-defaults file, leading every Tor Browser user who looks at her logs to see these notices and wonder if they're dangerous. Resolves bug 13124; bugfix on 0.2.5.3-alpha.
2014-09-11Merge remote-tracking branch 'public/bug13104_025'Nick Mathewson
2014-09-10Avoid divide by zero and NaNs in scale_array_elements_to_u64Nick Mathewson
Patch from teor; part of 13104
2014-09-10Merge remote-tracking branch 'origin/maint-0.2.5'Nick Mathewson
2014-09-10In routerlist_assert_ok(), check r2 before taking &(r2->cache_info)Nick Mathewson
Technically, we're not allowed to take the address of a member can't exist relative to the null pointer. That makes me wonder how any sane compliant system implements the offsetof macro, but let's let sleeping balrogs lie. Fixes 13096; patch on 0.1.1.9-alpha; patch from "teor", who was using clang -fsanitize=undefined-trap -fsanitize-undefined-trap-on-error -ftrapv
2014-09-10Merge remote-tracking branch 'yawning/bug_8402'Nick Mathewson
2014-09-10Merge remote-tracking branch 'public/bug12908_025' into maint-0.2.5Nick Mathewson
2014-09-10Mark StrictE{ntry,xit}Nodes as obsolete.Nick Mathewson
2014-09-09Fix issues brought up in nickm's review.Yawning Angel
* Update pt_get_proxy_uri() documentation. * proxy_supported is now unsigned. * Added a changes file.
2014-09-09Add unittests for finding the third quartile of a set.George Kadianakis
2014-09-09Merge remote-tracking branch 'asn/bug13064'Nick Mathewson
2014-09-09Remove client-side bad directory logicSebastian Hahn
Implements the second half of #13060.
2014-09-09Remove dirauth support for the BadDirectory flagSebastian Hahn
Implements the first half of #13060. The second half will be to remove client support, too.
2014-09-09Merge branch 'bug12899_squashed'Nick Mathewson
2014-09-09Remove support for naming directory authoritiesSebastian Hahn
This implements the meat of #12899. This commit should simply remove the parts of Tor dirauths used to check whether a relay was supposed to be named or not, it doesn't yet convert to a new mechanism for reject/invalid/baddir/badexiting relays.
2014-09-09Merge remote-tracking branch 'origin/maint-0.2.5'Nick Mathewson
2014-09-09Merge remote-tracking branch 'andrea/bug12160_025' into maint-0.2.5Nick Mathewson
2014-09-09Merge remote-tracking branch 'public/bug12700_024' into maint-0.2.5Nick Mathewson
2014-09-09Merge remote-tracking branch 'origin/maint-0.2.5'Nick Mathewson
2014-09-09Clean up the MVSC nmake files so they work again.Nick Mathewson
Fixes bug 13081; bugfix on 0.2.5.1-alpha. Patch from "NewEraCracker."
2014-09-09Merge remote-tracking branch 'origin/maint-0.2.5'Nick Mathewson
2014-09-09Add more escaped() calls in directory.cNick Mathewson
Patch from teor to fix 13071.
2014-09-08Merge remote-tracking branch 'origin/maint-0.2.5'Nick Mathewson
2014-09-08Expand the event_mask field in controller conns to 64 bitsNick Mathewson
Back in 078d6bcd, we added an event number 0x20, but we didn't make the event_mask field big enough to compensate. Patch by "teor". Fixes 13085; bugfix on 0.2.5.1-alpha.
2014-09-06Evaluate TestingDirAuthVoteGuard only after filling all rs elements.George Kadianakis
2014-09-05Correctly update channel local mark when address of incoming connection ↵Andrea Shepard
changes after handshake; fixes bug #12160
2014-09-04Fix add_fingerprint_to_dir() doc and signatureSebastian Hahn
This function never returns non-null, but its usage doesn't reflect that. Let's make it explicit. This will be mostly overridden by later commits, so no changes file here.
2014-09-04Remove the AuthDirRejectUnlisted config optionSebastian Hahn
This is in preparation for a big patch series removing the entire Naming system from Tor. In its wake, the approved-routers file is being deprecated, and a replacement option to allow only pre-approved routers is not being implemented.
2014-09-03Fix a couple of small memory leaks on failure cases.Nick Mathewson
[CID 1234702, 1234703]
2014-09-02Don't list relays w/ bw estimate of 0 in the consensusSebastian Hahn
This implements a feature from bug 13000. Instead of starting a bwauth run with this wrong idea about their bw, relays should do the self-test and then get measured.
2014-09-02Don't delay uploading a new desc if bw estimate was 0Sebastian Hahn
When a tor relay starts up and has no historical information about its bandwidth capability, it uploads a descriptor with a bw estimate of 0. It then starts its bw selftest, but has to wait 20 minutes to upload the next descriptor due to the MAX_BANDWIDTH_CHANGE_FREQ delay. This change should mean that on average, relays start seeing meaningful traffic a little quicker, since they will have a higher chance to appear in the consensus with a nonzero bw. Patch by Roger, changes file and comment by Sebastian.
2014-09-02Another clang analyzer complaint wrt HT_GENERATENick Mathewson
We're calling mallocfn() and reallocfn() in the HT_GENERATE macro with the result of a product. But that makes any sane analyzer worry about overflow. This patch keeps HT_GENERATE having its old semantics, since we aren't the only project using ht.h. Instead, define a HT_GENERATE2 that takes a reallocarrayfn.
2014-09-02Merge remote-tracking branch 'origin/maint-0.2.5'Nick Mathewson
2014-09-02Fix a number of clang analyzer false-positivesNick Mathewson
Most of these are in somewhat non-obvious code where it is probably a good idea to initialize variables and add extra assertions anyway. Closes 13036. Patches from "teor".
2014-09-01Avoid unsigned/sign compare warning from last patch.Nick Mathewson
2014-09-01Bounds check while looping over a fixed size table or arrayPhilip Van Hoof
(Edited to use existing ARRAY_LENGTH macro --nickm)
2014-08-29Merge remote-tracking branch 'origin/maint-0.2.5'Nick Mathewson
2014-08-29Merge remote-tracking branch 'arma/bug12996b' into maint-0.2.5Nick Mathewson
2014-08-29Downgrade "Unexpected onionskin length after decryption" warningRoger Dingledine
It's now a protocol-warn, since there's nothing relay operators can do about a client that sends them a malformed create cell. Resolves bug 12996; bugfix on 0.0.6rc1.
2014-08-29Merge remote-tracking branch 'origin/maint-0.2.5'Nick Mathewson
2014-08-29Improve "Tried to establish rendezvous on non-OR or non-edge circuit"Nick Mathewson
Instead of putting it all in one warning message, log what exactly was wrong with the circuit. Resolves ticket 12997.
2014-08-29Introduce full coverage tests for module routerset.c.dana koch
This is using the paradigm introduced for test_status.c.
2014-08-28Merge remote-tracking branch 'origin/maint-0.2.5'Nick Mathewson
2014-08-28Resume expanding abbreviations for command-line optionsRoger Dingledine
The fix for bug 4647 accidentally removed our hack from bug 586 that rewrote HashedControlPassword to __HashedControlSessionPassword when it appears on the commandline (which allowed the user to set her own HashedControlPassword in the torrc file while the controller generates a fresh session password for each run). Fixes bug 12948; bugfix on 0.2.5.1-alpha.
2014-08-26Merge remote-tracking branch 'public/bug10163'Nick Mathewson
2014-08-25Remove the assigned-but-unused chosen_named_idx local variableNick Mathewson
It had been used in consensus method 1. But now that 13 is the minimum (see #10163), we don't need it around. Found by sysrqb.
7apu2bq3rhoylwmucxizk54afw5jyda7pho4j5zdcqpwkufke7zdzwad.onion