summaryrefslogtreecommitdiff
path: root/src/or
AgeCommit message (Collapse)Author
2017-09-21hs: Avoid possible double circuit close on errorDavid Goulet
Fixes #23610 Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-09-20Avoid assertion failure for state file clock skewTaylor Yu
The clock_skew_warning() refactoring allowed calls from or_state_load() to control_event_bootstrap_problem() to occur prior bootstrap phase 0, causing an assertion failure. Initialize the bootstrap status prior to calling clock_skew_warning() from or_state_load().
2017-09-20Use correct sign for state file clock skewTaylor Yu
or_state_load() was using an incorrect sign convention when calling clock_skew_warning() to warn about state file clock skew. This caused the wording of the warning to be incorrect about the direction of the skew.
2017-09-20Use correct name for authtype 3 in a comment.Nick Mathewson
2017-09-20hs: Log the intro point when we clean it upDavid Goulet
When we remove an intro point from the service list, log info about it and some useful data. Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-09-20circuit: Log n_circ_id and global identifierDavid Goulet
When we can, log the n circuit id and global identifier for origin circuit. Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-09-20Merge branch 'bug23080'Nick Mathewson
2017-09-20Fix a comment that misunderstood is_canonicalNick Mathewson
is_canonical doesn't mean "am I connected to the one true address of this relay"; it means "does this relay tell me that the address I'm connected to belong to it." The point is to prevent TCP-based MITM, not to prevent the relay from multi-homing. Related to 22890.
2017-09-20Warn on ExtORPort USERADDR that is missing or 0.Nick Mathewson
Diagnoses violations on #23080.
2017-09-20Merge remote-tracking branch 'dgoulet/ticket23305_032_01'Nick Mathewson
2017-09-20Merge branch 'maint-0.3.1'Nick Mathewson
2017-09-20Merge branch 'maint-0.3.0' into maint-0.3.1Nick Mathewson
2017-09-20Merge branch 'maint-0.2.9' into maint-0.3.0Nick Mathewson
2017-09-20Merge branch 'maint-0.2.8' into maint-0.2.9Nick Mathewson
2017-09-20Remove longclaw's IPv6 address, as it will soon changeteor
Authority IPv6 addresses were originally added in 0.2.8.1-alpha. This leaves 3/8 directory authorities with IPv6 addresses, but there are also 52 fallback directory mirrors with IPv6 addresses. Resolves 19760.
2017-09-19sched: reorder code to fit comment bodies; comment typosMatt Traudt
Closes 23560
2017-09-19fix typos/etc found while starting to look at schedulerRoger Dingledine
2017-09-19sched: Allow the new sched to react to new consMatt Traudt
2017-09-19Add a BASE32_DIGEST_LEN defineDavid Goulet
Use this value instead of hardcoded values of 32 everywhere. This also addresses the use of REND_DESC_ID_V2_LEN_BASE32 in hs_lookup_last_hid_serv_request() for the HSDir encoded identity digest length which is accurate but semantically wrong. Fixes #23305. Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-09-19Merge remote-tracking branch 'teor/minor-comments'Nick Mathewson
2017-09-19Avoid a compilation warning on macOS in scheduler_ev_add()teor
This warning is caused by a different tv_usec data type on macOS compared to the system on which the patch was developed. Fixes 23575 on 0.3.2.1-alpha.
2017-09-19Improve comments around connection_or_client_used()teor
2017-09-19Improve comments formatting in connection.cteor
2017-09-18Correct what-is-deprecated-when commentsNick Mathewson
2017-09-18Merge remote-tracking branch 'public/ticket19704'Nick Mathewson
2017-09-18Add a cast so that 32-bit compilation goes without errorstor-0.3.2.1-alphaNick Mathewson
2017-09-18sched: BUG() on event_add() and log_warn next_runDavid Goulet
It is highly unlikely to happen but if so, we need to know and why. The warning with the next_run values could help. Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-09-18sched: Don't cast to int32_t the monotime_diff_msec() resultDavid Goulet
When the KIST schedule() is called, it computes a diff value between the last scheduler run and the current monotonic time. If tha value is below the run interval, the libevent even is updated else the event is run. It turned out that casting to int32_t the returned int64_t value for the very first scheduler run (which is set to 0) was creating an overflow on the 32 bit value leading to adding the event with a gigantic usec value. The scheduler was simply never running for a while. First of all, a BUG() is added for a diff value < 0 because if the time is really monotonic, we should never have a now time that is lower than the last scheduler run time. And we will try to recover with a diff value to 0. Second, the diff value is changed to int64_t so we avoid this "bootstrap overflow" and future casting overflow problems. Fixes #23558 Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-09-18Merge branch 'maint-0.3.1'Nick Mathewson
2017-09-18Merge branch 'maint-0.3.0' into maint-0.3.1Nick Mathewson
2017-09-18Merge branch 'maint-0.2.8' into maint-0.2.9Nick Mathewson
2017-09-18Fix log-uninitialized-stack bug in rend_service_intro_established.Nick Mathewson
Fixes bug 23490; bugfix on 0.2.7.2-alpha. TROVE-2017-008 CVE-2017-0380
2017-09-18Fix log-uninitialized-stack bug in rend_service_intro_established.Nick Mathewson
Fixes bug 23490; bugfix on 0.2.7.2-alpha. TROVE-2017-008 CVE-2017-0380
2017-09-15kist_no_kernel_support is unused when we didn't detect it.Nick Mathewson
So, remove it.
2017-09-15Replace accumulated C ;;s with ;sNick Mathewson
I don't know where these came from.
2017-09-15Merge branch 'scan-build-032'Nick Mathewson
2017-09-15Run our #else/#endif annotator on our source code.Nick Mathewson
2017-09-15Split some long #if lines to make the #endif annotator happyNick Mathewson
2017-09-15Merge branch 'maint-0.3.1'Nick Mathewson
Resolve conflict with 23532 code.
2017-09-15kist: Cast, then do operations on int32.Nick Mathewson
Otherwise integer overflows can happen. Remember, doing a i32xi32 multiply doesn't actually produce a 64-bit output. You need to do i64xi32 or i64xi64. Coverity found this as CID 1417753
2017-09-15Make netinet/tcp include conditional too: windows lacks it.Nick Mathewson
2017-09-15fix some 32-bit warnings about printf argumentsNick Mathewson
2017-09-15Merge branch 'remove_allow_dotexit_v2'Nick Mathewson
2017-09-15Remove AllowDotExit.Nick Mathewson
It's been deprecated since 0.2.9.2-alpha. Closes ticket 23426.
2017-09-15wrap a wide commentNick Mathewson
2017-09-15Merge remote-tracking branch 'dgoulet/ticket12541_032_02'Nick Mathewson
2017-09-15Merge remote-tracking branch 'dgoulet/ticket19254_032_01'Nick Mathewson
2017-09-15sched: add comment about how we determine if a socket should writeMatt Traudt
2017-09-15sched: add more per-socket limit documentation; int fixMatt Traudt
2017-09-15sched: Revert IF_BUG_ONCE() to tor_assert()David Goulet
Signed-off-by: David Goulet <dgoulet@torproject.org>