aboutsummaryrefslogtreecommitdiff
path: root/src/or
AgeCommit message (Collapse)Author
2018-04-09Add a comment explaining why we do a certain redundant checkNick Mathewson
Closes ticket 25291.
2018-04-06Merge branch 'isolate_libevent_2_squashed'Nick Mathewson
2018-04-05fix confusing commentRoger Dingledine
presumably introduced by copy-and-paste mistake
2018-04-05Move responsibility for threadpool reply-handler events to workqueueNick Mathewson
This change makes cpuworker and test_workqueue no longer need to include event2/event.h. Now workqueue.c needs to include it, but that is at least somewhat logical here.
2018-04-05Wrap the function we use to run the event loop.Nick Mathewson
Doing this lets us remove the event2/event.h header from a few more modules, particularly in the tests. Part of work on 23750.
2018-04-05Add wrappers for event_base_loopexit and event_base_loopbreak.Nick Mathewson
2018-04-05Add an API for a scheduled/manually activated event in the mainloopNick Mathewson
Using this API lets us remove event2/event.h usage from half a dozen modules, to better isolate libevent. Implements part of ticket 23750.
2018-04-05Merge remote-tracking branch 'public/split_relay_crypto'Nick Mathewson
2018-04-05Switch to use should_record_bridge_info()Neel Chauhan
Both in geoip_note_client_seen() and options_need_geoip_info(), switch from accessing the options directly to using the should_record_bridge_info() helper function. Fixes #25290 Signed-off-by: David Goulet <dgoulet@torproject.org>
2018-04-04Merge branch 'maint-0.3.3'Nick Mathewson
2018-04-04Merge branch 'bug21394_029_redux' into maint-0.3.3Nick Mathewson
2018-04-04Bug 21394 touchup: Increase DNS attempts to 3Dhalgren
Also don't give up on a resolver as quickly if multiple are configured.
2018-04-03Merge remote-tracking branch 'fristonio/ticket-25645'Nick Mathewson
2018-04-03ticket(25645): remove unused variable n_possible from channel_get_for_extend()Deepesh Pathak
2018-04-02protover: Change protover_all_supported() to return only unsupported.Isis Lovecruft
Previously, if "Link=1-5" was supported, and you asked protover_all_supported() (or protover::all_supported() in Rust) if it supported "Link=3-999", the C version would return "Link=3-999" and the Rust would return "Link=6-999". These both behave the same now, i.e. both return "Link=6-999".
2018-04-02protover: Change protover_all_supported() to return only unsupported.Isis Lovecruft
Previously, if "Link=1-5" was supported, and you asked protover_all_supported() (or protover::all_supported() in Rust) if it supported "Link=3-999", the C version would return "Link=3-999" and the Rust would return "Link=6-999". These both behave the same now, i.e. both return "Link=6-999".
2018-04-02Remove an unnecessary event2 include.Nick Mathewson
The rest, are, unfortunately, necessary for now.
2018-04-02Merge branch 'maint-0.3.3'Nick Mathewson
2018-04-02use channel_is_client for create cell countsRoger Dingledine
When a relay is collecting internal statistics about how many create cell requests it has seen of each type, accurately count the requests from relays that temporarily fall out of the consensus. (To be extra conservative, we were already ignoring requests from clients in our counts, and we continue ignoring them here.) Fixes bug 24910; bugfix on 0.2.4.17-rc.
2018-04-02dir auths no longer vote Guard if they're not voting V2DirRoger Dingledine
Directory authorities no longer vote in favor of the Guard flag for relays that don't advertise directory support. Starting in Tor 0.3.0.1-alpha, Tor clients have been avoiding using such relays in the Guard position, leading to increasingly broken load balancing for the 5%-or-so of Guards that don't advertise directory support. Fixes bug 22310; bugfix on 0.3.0.6.
2018-04-01misc tiny fixesRoger Dingledine
2018-03-29Fix CID 1433643Taylor Yu
Add a missing lock acquisition around access to queued_control_events in control_free_all(). Use the reassign-and-unlock strategy as in queued_events_flush_all(). Fixes bug 25675. Coverity found this bug, but only after we recently added an access to flush_queued_event_pending.
2018-03-29Merge branch 'maint-0.3.3'Nick Mathewson
2018-03-29Merge branch 'bug25617_029' into maint-0.3.3Nick Mathewson
2018-03-29Mark controller-initiated DNS lookups as permitted to do DNS.Nick Mathewson
Fixes bug 25617; bugfix on 0.2.9.3-alpha.
2018-03-28Merge remote-tracking branch 'public/bug25512'Nick Mathewson
2018-03-28Merge remote-tracking branch 'asn-github/t-25432'Nick Mathewson
2018-03-28Merge branch 'maint-0.3.3'Nick Mathewson
2018-03-28Merge remote-tracking branch 'dgoulet/bug24767_033_03' into maint-0.3.3Nick Mathewson
2018-03-28Merge branch 'maint-0.3.3'Nick Mathewson
2018-03-28Allow IPv6 address strings to be used as hostnames in SOCKS5 requestsrl1987
2018-03-27Merge branch 'maint-0.3.3'Nick Mathewson
2018-03-27Fix CID 1430932Taylor Yu
Coverity found a null pointer reference in nodelist_add_microdesc(). This is almost certainly impossible assuming that the routerstatus_t returned by router_get_consensus_status_by_descriptor_digest() always corresponds to an entry in the nodelist. Fixes bug 25629.
2018-03-27Fix CID 1430932Taylor Yu
Coverity found a null pointer reference in nodelist_add_microdesc(). This is almost certainly impossible assuming that the routerstatus_t returned by router_get_consensus_status_by_descriptor_digest() always corresponds to an entry in the nodelist. Fixes bug 25629.
2018-03-27test: Add unittest for the OR connection failure cacheGeorge Kadianakis
Signed-off-by: David Goulet <dgoulet@torproject.org>
2018-03-27relay: Avoid connecting to down relaysDavid Goulet
If we failed to connect at the TCP level to a relay, note it down and refuse to connect again for another 60 seconds. Fixes #24767 Signed-off-by: David Goulet <dgoulet@torproject.org>
2018-03-27Merge branch 'maint-0.3.3'Nick Mathewson
2018-03-27Merge branch 'bug25213_033' into maint-0.3.3Nick Mathewson
2018-03-26Merge branch 'bug24658-rm-curve25519-header' into bug24658-mergeNick Mathewson
2018-03-26Merge branch 'maint-0.3.3'Nick Mathewson
2018-03-26Merge remote-tracking branch 'dgoulet/bug24904_033_01' into maint-0.3.3Nick Mathewson
2018-03-26Merge branch 'maint-0.3.3'Nick Mathewson
2018-03-26Merge branch 'bug24903_029' into maint-0.3.3Nick Mathewson
2018-03-26Make extend_info_from_node() more picky about node contentsNick Mathewson
This update is needed to make it consistent with the behavior of node_awaiting_ipv6(), which doesn't believe in the addresses from routerinfos unless it actually plans to use those routerinfos. Fixes bug 25213; bugfix on b66b62fb7525cac1e1 in 0.3.3.1-alpha, which tightened up the definition of node_awaiting_ipv6().
2018-03-26When extending a circuit's path length, clear onehop_tunnel.Nick Mathewson
There was a nonfatal assertion in pathbias_should_count that would trigger if onehop_tunnel was set, but the desired_path_length was greater than 1. This patch fixes that. Fixes bug 24903; bugfix on 0.2.5.2-alpha.
2018-03-24Document a requirement for cells to be encrypted.Nick Mathewson
2018-03-23Merge branch 'maint-0.3.3'Nick Mathewson
2018-03-23Fix windows compilation warnings in hs_service.cNick Mathewson
These were breaking jenkins builds. Bugfix on 5804ccc9070dc54; bug not in any released Tor.
2018-03-23Clear all control.c flags on control_free_all()Nick Mathewson
Fixes bug 25512.
2018-03-23Merge remote-tracking branch 'fristonio/ticket-24740'Nick Mathewson