summaryrefslogtreecommitdiff
path: root/src/or/rendservice.c
AgeCommit message (Collapse)Author
2012-01-07clean up a comment that confused arturoRoger Dingledine
2011-12-27Don't close HS service-side rend circs on timeoutRobert Ransom
2011-12-20Add explicit cast to make gcc happyNick Mathewson
2011-12-20Adjust n_intro_points_wanted when a service's intro points are closedRobert Ransom
2011-12-20Extract function to determine how many intros an intro point has handledRobert Ransom
2011-12-01Don't segfault when checking whether a not-yet-used intro point should expireRobert Ransom
Found by katmagic. Bugfix on the #3460 branch, not yet in any release.
2011-11-30Merge branch 'feature2553-v4-rebased'Nick Mathewson
2011-11-30Add ifdefs to disable #3332 assertionsRobert Ransom
2011-11-30appease "make check-spaces"Nick Mathewson
2011-11-30First chunk of support for bridges on IPv6Linus Nordberg
Comments below focus on changes, see diff for added code. New type tor_addr_port_t holding an IP address and a TCP/UDP port. New flag in routerinfo_t, ipv6_preferred. This should go in the node_t instead but not now. Replace node_get_addr() with - node_get_prim_addr() for primary address, i.e. IPv4 for now - node_get_pref_addr() for preferred address, IPv4 or IPv6. Rename node_get_addr_ipv4h() node_get_prim_addr_ipv4h() for consistency. The primary address will not allways be an IPv4 address. Same for node_get_orport() -> node_get_prim_orport(). Rewrite node_is_a_configured_bridge() to take all OR ports into account. Extend argument list to extend_info_from_node and extend_info_from_router with a flag indicating if we want to use the routers primary address or the preferred address. Use the preferred address in as few situtations as possible for allowing clients to connect to bridges over IPv6.
2011-11-29Merge remote-tracking branch 'rransom-tor/bug3460-v4'Nick Mathewson
Conflicts: src/or/rendservice.c
2011-11-27Correct documentation comments for fields formerly named accepted_introsRobert Ransom
2011-11-27Rename accepted_intros fieldsRobert Ransom
2011-11-17Fix a couple of memory leaks in rend_add_service spotted by coverityNick Mathewson
2011-11-09Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson
2011-11-07Include HiddenServiceDir in some warning messagesRobert Ransom
2011-10-31Ignore timestamps of INTRODUCE2 cellsRobert Ransom
2011-10-30Move the real INTRODUCE2 replay-detection cache into rend_intro_point_tRobert Ransom
2011-10-30Make introduction points expireRobert Ransom
2011-10-30Allow intro points to expire somewhat gracefullyRobert Ransom
The Right Way to expire an intro point is to establish a new one to replace it, publish a new descriptor that doesn't list any expiring intro points, and *then*, once our upload attempts for the new descriptor have ended (whether in success or failure), close the expiring intro points. Unfortunately, we can't find out when the new descriptor has actually been uploaded, so we'll have to settle for a five-minute timer. There should be no significant behaviour changes due to this commit (only a log-message change or two), despite the rather massive overhaul, so this commit doesn't include a changes/ file. (The commit that teaches intro_point_should_expire_now to return non-zero gets a changes/ file, though.)
2011-10-30Use SMARTLIST_FOREACH_BEGIN and _END, not a for loopRobert Ransom
2011-10-30Correct bogus commentsRobert Ransom
The behaviour of rend_services_introduce here is likely as bogus as the comments were.
2011-10-30Use a more meaningful variable nameRobert Ransom
2011-10-30Determine whether an intro point was in the last HS desc in a sane wayRobert Ransom
2011-10-30Record which intro points were listed in the last HS descRobert Ransom
2011-10-30Record the number of INTRODUCE2 cells each intro point has receivedRobert Ransom
2011-10-30Correct a log messageRobert Ransom
2011-10-30Record the time at which each intro point was first publishedRobert Ransom
2011-10-30Improve a commentRobert Ransom
2011-10-30Allow different HSes to maintain different numbers of intro pointsRobert Ransom
2011-10-20Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson
2011-10-18Free rend_data and intro_key when extra intro circs become general-purposeRobert Ransom
2011-10-11Fix names of functions that convert strings to addrsNick Mathewson
Now let's have "lookup" indicate that there can be a hostname resolution, and "parse" indicate that there wasn't. Previously, we had one "lookup" function that did resolution; four "parse" functions, half of which did resolution; and a "from_str()" function that didn't do resolution. That's confusing and error-prone! The code changes in this commit are exactly the result of this perl script, run under "perl -p -i.bak" : s/tor_addr_port_parse/tor_addr_port_lookup/g; s/parse_addr_port(?=[^_])/addr_port_lookup/g; s/tor_addr_from_str/tor_addr_parse/g; This patch leaves aton and pton alone: their naming convention and behavior is is determined by the sockets API. More renaming may be needed.
2011-09-11Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson
2011-09-10Demote 'INTRODUCE2 cell is too {old,new}' message to info levelRobert Ransom
2011-09-10Demote HS 'replay detected' log message for DH public keys to info levelRobert Ransom
2011-09-10Merge remote-tracking branch 'rransom-tor/typo-fix-ohkah8Ah'Nick Mathewson
2011-09-10Fix log message typo.Robert Ransom
2011-09-09Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson
Conflicts: configure.in src/or/circuitbuild.c
2011-09-09Merge remote-tracking branch 'public/enhance_replay_detection' into maint-0.2.2Nick Mathewson
2011-09-09Check for replays in PK-encrypted part of intro cell, not just in the g^x valueNick Mathewson
2011-07-19Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson
2011-07-19Specify text or binary mode in every start_writing_to_stdio_file callRobert Ransom
2011-07-15Fix bug in upload/download of hsdesc with microdescsNick Mathewson
Previously we were using router_get_by_id(foo) to test "do we have a descriptor that will let us make an anonymous circuit to foo". But that isn't right for microdescs: we should have been using node_t. Fixes bug 3601; bugfix on 0.2.3.1-alpha.
2011-07-07Kill redundant checks around routerset_contains_*()Nick Mathewson
All of the routerset_contains*() functions return 0 if their routerset_t argument is NULL. Therefore, there's no point in doing "if (ExcludeNodes && routerset_contains*(ExcludeNodes...))", for example. This patch fixes every instance of if (X && routerstatus_contains*(X,...)) Note that there are other patterns that _aren't_ redundant. For example, we *don't* want to change: if (EntryNodes && !routerstatus_contains(EntryNodes,...)) Fixes #2797. No bug here; just needless code.
2011-06-15Merge remote-tracking branch 'rransom-tor/bug3332-v2'Nick Mathewson
2011-06-14Assert that HS operations are not performed using single-hop circuitsRobert Ransom
(with fixes by Nick Mathewson to unbreak the build)
2011-06-14Make the get_options() return constNick Mathewson
This lets us make a lot of other stuff const, allows the compiler to generate (slightly) better code, and will make me get slightly fewer patches from folks who stick mutable stuff into or_options_t. const: because not every input is an output!
2011-06-14Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson
2011-06-14Make ControlSocketsGroupWritable work with User.Jérémy Bobbio
Original message from bug3393: check_private_dir() to ensure that ControlSocketsGroupWritable is safe to use. Unfortunately, check_private_dir() only checks against the currently running user… which can be root until privileges are dropped to the user and group configured by the User config option. The attached patch fixes the issue by adding a new effective_user argument to check_private_dir() and updating the callers. It might not be the best way to fix the issue, but it did in my tests. (Code by lunar; changelog by nickm)