aboutsummaryrefslogtreecommitdiff
path: root/src/or/dnsserv.c
AgeCommit message (Collapse)Author
2011-01-15Add missing check for hostname answer_len in dnsserv sizeNick Mathewson
This is checked elsewhere too, but let's be RFC-conformant.
2011-01-15Always nul-terminate the result passed to evdns_server_add_ptr_replyNick Mathewson
In dnsserv_resolved(), we carefully made a nul-terminated copy of the answer in a PTR RESOLVED cell... then never used that nul-terminated copy. Ouch. Surprisingly this one isn't as huge a security problem as it could be. The only place where the input to dnsserv_resolved wasn't necessarily nul-terminated was when it was called indirectly from relay.c with the contents of a relay cell's payload. If the end of the payload was filled with junk, eventdns.c would take the strdup() of the name [This part is bad; we might crash there if the cell is in a bad part of the stack or the heap] and get a name of at least length 495[*]. eventdns.c then rejects any name of length over 255, so the bogus data would be neither transmitted nor altered. [*] If the name was less than 495 bytes long, the client wouldn't actually be reading off the end of the cell. Nonetheless this is a reasonably annoying bug. Better fix it. Found while looking at bug 2332, reported by doorss. Bugfix on 0.2.0.1-alpha.
2011-01-03Bump copyright statements to 2011Nick Mathewson
2010-02-27Update Tor Project copyright yearsNick Mathewson
2009-05-04Update copyright to 2009.Karsten Loesing
2009-02-11Port some mostly cosmetic eventdns changes from libeventNick Mathewson
svn:r18492
2009-01-06Make outgoing DNS requests respect OutboundBindAddress.Nick Mathewson
Fixes the bug part of bug 789. svn:r17983
2009-01-04Remove svn $Id$s from our source, and remove tor --version --version.Nick Mathewson
The subversion $Id$ fields made every commit force a rebuild of whatever file got committed. They were not actually useful for telling the version of Tor files in the wild. svn:r17867
2008-12-22Add DOCDOC comments for all undocumented functions. Add missing *s to other ↵Nick Mathewson
comments so that they will get recognized as doxygen. svn:r17729
2008-12-18Downlgrade tweak, and answer lots of XXX021s. No actual code fixes in this ↵Nick Mathewson
patch. svn:r17686
2008-11-07fix wide linesNick Mathewson
svn:r17198
2008-10-29Work better with tools that resist DNS poisoning by using the 0x20 hack: ↵Nick Mathewson
make DNSPort replies perserve case. svn:r17170
2008-09-05Refactor use of connection_new so that we get more verifiable typesafety.Nick Mathewson
svn:r16785
2008-08-07 r17666@tombo: nickm | 2008-08-07 15:12:30 -0400Nick Mathewson
Make tor_addr_from_sockaddr also give away the port in a useful format svn:r16458
2008-08-05 r17641@31-33-44: nickm | 2008-08-05 16:07:53 -0400Nick Mathewson
Initial conversion of uint32_t addr to tor_addr_t addr in connection_t and related types. Most of the Tor wire formats using these new types are in, but the code to generate and use it is not. This is a big patch. Let me know what it breaks for you. svn:r16435
2008-07-24 r17346@aud-055: nickm | 2008-07-24 15:37:19 +0200Nick Mathewson
Make generic address manipulation functions work better. Switch address policy code to use tor_addr_t, so it can handle IPv6. That is a good place to start. svn:r16178
2008-02-22 r14399@tombo: nickm | 2008-02-22 14:09:38 -0500Nick Mathewson
More 64-to-32 fixes. Partial backport candidate. still not done. svn:r13680
2008-02-15 r14181@tombo: nickm | 2008-02-15 16:48:17 -0500Nick Mathewson
Fix all but 2 DOCDOC items; defer many XXX020s (particularly those where fixing them would fix no bugs at the risk of introducing some bugs). svn:r13529
2008-02-12 r18051@catbus: nickm | 2008-02-12 15:20:43 -0500Nick Mathewson
Re-tune mempool parametes based on testing on peacetime: use smaller chuncks, free them a little more aggressively, and try very hard to concentrate allocations on fuller chunks. Also, lots of new documentation. svn:r13484
2008-02-07Update some copyright notices: it is now 2008.Nick Mathewson
svn:r13412
2008-02-05 r17913@catbus: nickm | 2008-02-05 16:11:33 -0500Nick Mathewson
Correctly register failures in connection_add() in dnsserv_launch_request() svn:r13387
2008-01-14 r17612@catbus: nickm | 2008-01-14 13:46:04 -0500Nick Mathewson
Oops; fix compile svn:r13131
2008-01-14 r17611@catbus: nickm | 2008-01-14 13:44:16 -0500Nick Mathewson
add some missing checks for failing return values. svn:r13130
2007-12-12clean up copyrights, and assign 2007 copyrights to The Tor Project, IncRoger Dingledine
svn:r12786
2007-09-05 r14327@Kushana: nickm | 2007-09-04 20:06:04 -0400Nick Mathewson
Better comment in dnsserv.c svn:r11376
2007-07-25 r13908@catbus: nickm | 2007-07-25 18:55:47 -0400Nick Mathewson
Patch from Robert Hogan: set conn->dns_server_port correctly so that we can close dns server ports when they change, thus avoiding crashes and dangling references and other sources of unhappiness. svn:r10933
2007-07-10 r13676@catbus: nickm | 2007-07-10 13:41:24 -0400Nick Mathewson
Man. I thought I removed that code. svn:r10785
2007-07-10 r13666@catbus: nickm | 2007-07-10 13:10:00 -0400Nick Mathewson
Get the RESOLVE controller code working. svn:r10781
2007-07-10 r13637@catbus: nickm | 2007-07-06 14:24:27 -0400Nick Mathewson
fix copy-paste error in config message src/or/config.c . Apply initial (but pared-down) version of launch-resolve-via-controller patch from Robert Hogan. svn:r10780
2007-07-05 r13453@kushana: nickm | 2007-06-20 10:01:37 -0400Nick Mathewson
Fix a type error in the last checkin. svn:r10738
2007-07-05 r13452@kushana: nickm | 2007-06-20 09:52:55 -0400Nick Mathewson
Patch from Robert Hogan: Generate STREAM NEW events for dnsport requests and tunneled directory connections. Log when we are testing for hijacking. svn:r10737
2007-06-17 r13471@catbus: nickm | 2007-06-17 11:59:25 -0400Nick Mathewson
Report address and por correctly on requests to dnsport. (Patch from Robert Hogan.) svn:r10641
2007-06-13 r13401@catbus: nickm | 2007-06-13 15:50:16 -0400Nick Mathewson
Add dnsport connection to the global connection list. (Bug found by mwenge.) svn:r10592
2007-06-05 r13266@catbus: nickm | 2007-06-05 16:38:08 -0400Nick Mathewson
Patch from peter palfrader: control interface via unix domain socket svn:r10504
2007-06-02 r13143@catbus: nickm | 2007-06-01 16:43:40 -0400Nick Mathewson
Try to fix some mipspro compiler warnings. There will still be some left. svn:r10444
2007-05-31 r13117@catbus: nickm | 2007-05-31 19:40:32 -0400Nick Mathewson
Patch from Tup: treat RESOLVED_TYPE_ERROR_TRANSIENT as a SERVERFAILED, and RESOLVED_TYPE_ERROR as NOTEXIST. Generate transient/nontransient errors more sensibly. Set flags better on DNS replies. svn:r10427
2007-05-29 r13050@catbus: nickm | 2007-05-29 13:31:11 -0400Nick Mathewson
Resolve all but 3 DOCDOCs. svn:r10393
2007-05-25 r12958@catbus: nickm | 2007-05-25 14:19:29 -0400Nick Mathewson
Fix more dnsport bugs: set state correctly, and actually cache the answers. svn:r10328
2007-05-24 r12942@catbus: nickm | 2007-05-24 16:31:22 -0400Nick Mathewson
Well, that was easier than I thought it would be. Tor is now a DNS proxy as well as a socks proxy. Probably some bugs remain, but since it A) has managed to resolve one address for me successfully, and B) will not affect anybody who leaves DNSPort unset, it feel like a good time to commit. svn:r10317