Age | Commit message (Collapse) | Author |
|
config_parse_interval() and config_parse_msec_interval() were checking
whether the variable "ok" (a pointer to an int) was null, rather than
derefencing it. Both functions are static, and all existing callers
pass a valid pointer to those static functions. The callers do check
the variables (also confusingly named "ok") whose addresses they pass
as the "ok" arguments, so even if the pointer check were corrected to
be a dereference, it would be redundant.
Fixes #22103.
|
|
I'm doing this to storagedir to used config_line_t.
|
|
|
|
This was introducd in 4d83999213712c7 in 0.3.0.3-alpha. This is bug
21682.
|
|
I broke "GETCONF *Port" in 20956, when I made SocksPort a
subordinate option of the virtual option SocksPortLines, so that I
could make SocksPort and __SocksPort provide qthe same
functionality. The problem was that you can't pass a subordinate
option to GETCONF.
So, this patch fixes that by letting you fetch subordinate options.
It won't always be meaningful to consider these options
out-of-context, but that can be the controller-user's
responsibility to check.
Closes ticket 21300.
|
|
|
|
|
|
|
|
|
|
|
|
Also, collapse all the config_assign*() options into a flags
argument, since having two boolean arguments was already confusing.
|
|
|
|
|
|
This caught quite a few minor issues in our unit tests and elsewhere
in our code.
|
|
|
|
|
|
|
|
Because in 95 years, we or our successors will surely care about
enforcing the BSD license terms on this code. Right?
|
|
Bugfix on 1293835440dd4debf6fbfc66e755d9b9384aa362, which implemented
6752: Not in any released tor.
|
|
|
|
These were previously allowed only in the initial position:
--help, -h , --version, --digests, --list-torrc-options
|
|
Patch from CharlieB for ticket #9214
|
|
|
|
Also lower maximum interval without directory requests, and raise
maximum download tries.
Implements #6752.
|
|
Conflicts:
doc/tor.1.txt
src/or/circuitbuild.c
src/or/config.c
src/or/or.h
|
|
Without this patch, there's no way to know what went wrong when we
fail to parse a torrc line entirely (that is, we can't turn it into
a K,V pair.) This patch introduces a new function that yields an
error message on failure, so we can at least tell the user what to
look for in their nonfunctional torrc.
(Actually, it's the same function as before with a new name:
parse_config_line_from_str is now a wrapper macro that the unit
tests use.)
Fixes bug 7950; fix on 0.2.0.16-alpha (58de695f9062576f) which first
introduced the possibility of a torrc value not parsing correctly.
|
|
|
|
|
|
|
|
This helps us split up one of our larger files, and sets the stage
for refactoring the configuration backend a little
|