aboutsummaryrefslogtreecommitdiff
path: root/src/or/command.c
AgeCommit message (Collapse)Author
2011-11-21Merge branch 'bug4360'Nick Mathewson
2011-11-20Log more loudly on a bad cert from an authority.Nick Mathewson
Clock skew made this situation way too frequent so we demoted it to "protocol_warn", but when there's an authority, it should really just be warn.
2011-11-15Make certificate skew into a protocol warningNick Mathewson
2011-11-03Even when we can't answer an AUTH_CHALLENGE, send NETINFO.Nick Mathewson
Fixes bug 4368; fix on 0.2.3.6-alpha; bug found by "frosty".
2011-11-03Fix bug 4367: correctly detect auth_challenge cells we can't useNick Mathewson
Found by frosty_un, bugfix on 0.2.3.6-alpha, fix suggested by arma.
2011-10-31normalize the name of the CERTS cellRoger Dingledine
2011-10-28Merge branch 'bug4343'Nick Mathewson
2011-10-28Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson
Conflicts: src/or/command.c
2011-10-28Discard all cells on a marked connectionNick Mathewson
Fix for bug 4299
2011-10-28"Authetnicate" is not the usual spellingNick Mathewson
2011-10-28Fix a double-free that would occur on an invalid cert in a CERTS cellNick Mathewson
We would stash the certs in the handshake state before checking them for validity... and then if they turned out to be invalid, we'd give an error and free them. Then, later, we'd free them again when we tore down the connection. Fixes bug 4343; fix on 0.2.3.6-alpha.
2011-10-27Merge branch 'maint-0.2.2_secfix' into master_secfixSebastian Hahn
Conflicts: src/common/tortls.c src/or/connection_or.c src/or/dirserv.c src/or/or.h
2011-10-26Merge branch 'maint-0.2.1_secfix' into maint-0.2.2_secfixSebastian Hahn
Conflicts: src/or/connection_or.c
2011-10-26Reject create cells on outgoing OR connections from bridgesRobert Ransom
2011-10-26Don't use any OR connection which sent us a CREATE_FAST cell for an EXTENDRobert Ransom
Fix suggested by Nick Mathewson.
2011-10-26manually backport a5232e0c4cRoger Dingledine
2011-10-26Do not tread vpadding cell as versions cell. Not in any released version.Nick Mathewson
2011-10-23Double-check that we really can get RSA keys from ID/Auth certsNick Mathewson
Addresses issue 4287; issue not in any released Tor.
2011-10-23Fix memory leak in prop176 codeNick Mathewson
This fixes part of bug4252. Bug not in any released version.
2011-10-11Fix a bunch of whitespace errorsNick Mathewson
2011-10-10Add some points to make it easy to turn off v3 supportNick Mathewson
2011-10-10Quiet two notices, and spelling mistake cleanupSebastian Hahn
2011-10-10Add more log statements for protocol/internal failuresNick Mathewson
2011-10-10Remove auth_challenge field from or_handshake_state_tNick Mathewson
We didn't need to record this value; it was already recorded implicitly while computing cell digests for later examination in the authenticate cells.
2011-10-10spec conformance: allow only one cert of each typeNick Mathewson
2011-10-10Give tor_cert_get_id_digests() fail-fast behaviorNick Mathewson
Right now we can take the digests only of an RSA key, and only expect to take the digests of an RSA key. The old tor_cert_get_id_digests() would return a good set of digests for an RSA key, and an all-zero one for a non-RSA key. This behavior is too error-prone: it carries the risk that we will someday check two non-RSA keys for equality and conclude that they must be equal because they both have the same (zero) "digest". Instead, let's have tor_cert_get_id_digests() return NULL for keys we can't handle, and make its callers explicitly test for NULL.
2011-10-10Make more safe_str usage happen for new logs in command.cNick Mathewson
2011-10-10Set up network parameters on non-authenticated incoming connectionsNick Mathewson
Also add some info log messages for the steps of the v3 handshake. Now my test network bootstraps!
2011-10-10Make sure we stop putting cells into our hash at the right time.Nick Mathewson
2011-10-10Bugfixes for authenticate handling and generationNick Mathewson
2011-10-10Fix log message about what cells we are sendingNick Mathewson
2011-10-10Hook up all of the prop176 code; allow v3 negotiations to actually workNick Mathewson
2011-10-10Make tor_tls_cert_is_valid check key lengthsNick Mathewson
2011-10-10Implement cert/auth cell readingNick Mathewson
2011-10-10Cell types and states for new OR handshakeNick Mathewson
Also, define all commands > 128 as variable-length when using v3 or later link protocol. Running into a var cell with an unrecognized type is no longer a bug.
2011-05-30Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson
The conflicts were mainly caused by the routerinfo->node transition. Conflicts: src/or/circuitbuild.c src/or/command.c src/or/connection_edge.c src/or/directory.c src/or/dirserv.c src/or/relay.c src/or/rendservice.c src/or/routerlist.c
2011-05-30Merge branch 'bug3045' into maint-0.2.2Nick Mathewson
Conflicts: src/or/circuitbuild.c
2011-05-28Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson
2011-05-23Fix GCC 4.6's new -Wunused-but-set-variable warnings.Nick Mathewson
Most instances were dead code; for those, I removed the assignments. Some were pieces of info we don't currently plan to use, but which we might in the future. For those, I added an explicit cast-to-void to indicate that we know that the thing's unused. Finally, one was a case where we were testing the wrong variable in a unit test. That one I fixed. This resolves bug 3208.
2011-05-15Log descriptions of nodes, not just nicknames.Nick Mathewson
This patch introduces a few new functions in router.c to produce a more helpful description of a node than its nickame, and then tweaks nearly all log messages taking a nickname as an argument to call these functions instead. There are a few cases where I left the old log messages alone: in these cases, the nickname was that of an authority (whose nicknames are useful and unique), or the message already included an identity and/or an address. I might have missed a couple more too. This is a fix for bug 3045.
2011-02-28Revert bug1074_launch_authconn* branch: needs more design, less crashingNick Mathewson
2011-02-25Add a missing constNick Mathewson
2011-02-25Merge branch 'bug1074_launch_conn_on_skew'Nick Mathewson
Fixed conflict on rename of router_get_by_digest->router_get_by_id_digest Conflicts: src/or/command.c
2011-02-25whitespace fixupNick Mathewson
2011-02-25Fix for #1074 previous revAltF4
Changed tor_addr_from_ipv4n to tor_addr_from_ipv4h and changed descriptor_digest to identity_digest
2011-02-25Fix for #1074 "Part 3"AltF4
Changed received_netinfo_from_trusted_dir into a tristate in order to keep track of whether we have already tried contacting a trusted dir. So we don't send multiple requests if we get a bunch of skews.
2011-02-25Sebastian's Changes to #1074AltF4
Fixes some small mistakes with AltF4's #1074 fix
2011-02-25Fix time skew values from untrusted sourcesAltF4
Now when we receive a large time skew from a source which isn't a trusted dir, we go contact a trusted dir to trigger a NETINFO cell.
2011-01-03Merge remote branch 'origin/maint-0.2.2'Nick Mathewson
2011-01-03Merge remote branch 'origin/maint-0.2.1' into maint-0.2.2Nick Mathewson
Conflicts: src/or/routerparse.c
7apu2bq3rhoylwmucxizk54afw5jyda7pho4j5zdcqpwkufke7zdzwad.onion