summaryrefslogtreecommitdiff
path: root/src/feature/dirauth
AgeCommit message (Collapse)Author
2021-03-15Merge branch 'maint-0.3.5' into maint-0.4.4Nick Mathewson
2021-03-15Fix detection of point to insert signatures on a pending consensus.Nick Mathewson
We were looking for the first instance of "directory-signature " when instead the correct behavior is to look for the first instance of "directory-signature " at the start of a line. Unfortunately, this can be exploited as to crash authorities while they're voting. Fixes #40316; bugfix on 0.2.2.4-alpha. This is TROVE-2021-002, also tracked as CVE-2021-28090.
2020-10-27Merge branch 'tor-gitlab/mr/176' into maint-0.4.4David Goulet
2020-10-23Update required/recommended protocol lists more systematicallyNick Mathewson
First I began with a set of candidates: The client's _required_ list starts with all the protocols supported by every release in 0.2.9-stable through current master. The client's _required_ list starts with all the protocols supported by every release in 0.3.5-stable through current master. Everybody's _recommended_ list starts with all the protocols supported by every release in 0.3.5-stable through current master. Then I removed the protocol versions that we do not actually want to require or recommend: DirCache=1 (deprecated) HSDir=1, HSIntro=1-3, HSRend=1 (deprecated) (All HS* protocol requirements for clients) Link=1-3 (deprecated) LinkAuth=1 (obsolete) Relay=1 (obsolete)
2020-10-22Turn ConsensusParams into a LinelistRoger Dingledine
Make it possible to specify multiple ConsensusParams torrc lines. Now directory authority operators can for example put the main ConsensusParams config in one torrc file and then add to it from a different torrc file. Closes ticket 40164.
2020-10-18Update required/recommended protocol versions.Nick Mathewson
Cons=1 is the old format of consensuses, without ed25519 keys. It is no longer required or recommended. Cons=2 is the new format of consensuses, with ed25519 keys. It is now required. (Similarly for Desc=1,2 and Microdesc=1,2) No supported client or relay versions should be affected by this change, since these versions are supported by clients and relays running 0.2.9 and later. It will only take effect once enough authorities vote for it. Closes ticket 40162.
2020-10-18Split required/recommended protocol lists into multiple linesNick Mathewson
This should make diffs easier to read.
2020-06-17Update the list of recommended protocol versions to match >=0.3.5.Nick Mathewson
Since Tor 0.2.9 has been unsupported since January, 0.3.5 is the oldest supported version, and its features constitute the oldest recommended feature-set. This patch updates these recommendations: DirCache=2 Support for consensus diffs. New in 0.3.1.1-alpha. HSDir=2 Support for v3 onion service descriptors. New in 0.3.0.4-alpha. HSIntro=4 Support for Ed25519 intropoint authentication keys. New in 0.3.0-4-alpha. HSRend=2 Support for rendezvous cells longer than 20 bytes. New in 0.2.9.4-alpha. Link=5 Link padding and link padding negotiation. New in 0.3.3.2-alpha. LinkAuth=3 Ed25519 link authentication. New in 0.3.0.1-alpha.
2020-06-17Spelling fix: "RECCOMEND" => "RECOMMEND".Nick Mathewson
2020-05-21Check for NULL from tor_dup_ip()rl1987
2020-05-21Bail out of format_networkstatus_vote if fmt_addr32() failed.rl1987
Something is fishy if we cannot put IP address string into dir-vote line.
2020-05-21Check that fmt_addr32() returned non-empty string before putting it into ↵rl1987
documents
2020-05-07Merge remote-tracking branch 'tor-github/pr/1880/head'Nick Mathewson
2020-05-06Merge branch 'maint-0.4.3'Nick Mathewson
2020-05-06Merge branch 'maint-0.4.2' into maint-0.4.3Nick Mathewson
2020-05-06Merge branch 'maint-0.4.1' into maint-0.4.2Nick Mathewson
2020-05-06Merge branch 'bug34078_prelim_035' into bug34078_prelim_041Nick Mathewson
2020-05-06Replace a "fall through" comment that was outside a switch.Nick Mathewson
2020-05-05config: New file resolve_addr.{c|h}David Goulet
Move a series of function from config.c into that new file which is related to address resolving. Part of #33789 Signed-off-by: David Goulet <dgoulet@torproject.org>
2020-05-04Merge branch 'maint-0.4.3'Nick Mathewson
2020-05-04Merge branch 'maint-0.4.1' into maint-0.4.2Nick Mathewson
2020-04-30Merge branch 'bug34077_042' into bug34077_043Nick Mathewson
2020-04-30Merge branch 'bug34077_041' into bug34077_042Nick Mathewson
2020-04-30Fix a GCC 10.0.1 compilation warning.Nick Mathewson
Fixes 34077 for 0.4.1; bugfix on 0.4.0.3-alpha. (Specifically, GCC first gives this warning for 9eeff921ae7b786d960ea4286d5bba56)
2020-04-07Merge branch 'pr1838_squashed'teor
2020-03-27spell consensus more right in commentsRoger Dingledine
2020-03-26Add a SUBSYS_DECLARE_LOCATION() to every subsystem.Nick Mathewson
2020-03-20Merge branch 'maint-0.4.3'Nick Mathewson
2020-03-20relay/dirauth: Set some output arguments in stubsteor
And document how some functions set their output arguments. Fixes bug 33674; bugfix on 0.4.3.1-alpha.
2020-03-20Merge branch 'maint-0.4.3'teor
2020-03-20dirauth: Remove a duplicate macro definitionteor
Obviously correct changes to already-reviewed code.
2020-03-16Merge branch 'maint-0.4.3'Nick Mathewson
2020-03-16Merge branch 'ticket32672_042_squashed_w_test' into maint-0.4.3Nick Mathewson
2020-03-16Merge branch 'ticket32672_041_squashed' into ticket32672_042_squashed_w_testNick Mathewson
2020-03-16Reject 0.2.9 and 0.4.0 in dirserv_rejects_tor_version()Neel Chauhan
2020-03-05Merge branch 'clang_format_prep_3'Nick Mathewson
2020-03-03Comment updates from review.Nick Mathewson
2020-03-03Make voting_schedule.h work correctly when dirauth-mode is disabled.Nick Mathewson
2020-03-03Stop using all dirauth-only options in shared_random_client.cNick Mathewson
This is not as clean a patch as I would like: see the comment on ASSUME_AUTHORITY_SCHEDULING. This issue here is that the unit tests sometimes assume that we are going to be looking at the dirauth options and behaving like a dirauth, but without setting the options to turn is into one. This isn't an issue for actually running Tor, as far as I can tell with chutney.
2020-02-24Dirauth-specific function to get voting interval.Nick Mathewson
2020-02-24Extract most of dirauth_sched_get_next_valid_after_time()Nick Mathewson
Most of this function was about recreating a voting schedule on demand if it didn't exist yet or was not up-to-date. I've made that into its own function.
2020-02-24Rename voting_schedule_*() functions.Nick Mathewson
This is an automated commit, generated by this command: ./scripts/maint/rename_c_identifier.py \ voting_schedule_recalculate_timing dirauth_sched_recalculate_timing \ voting_schedule_get_start_of_next_interval voting_sched_get_start_of_interval_after \ voting_schedule_get_next_valid_after_time dirauth_sched_get_next_valid_after_time
2020-02-24Move one voting schedule fn into networkstatus.cNick Mathewson
The 'voting_schdule_get_start_of_next_interval' function isn't actually dirauth-specific.
2020-02-24Move voting_schedule.[ch] to src/feature/dirauth/Nick Mathewson
2020-02-20Merge branch 'maint-0.4.3'Nick Mathewson
2020-02-20Merge remote-tracking branch 'tor-github/pr/1719/head' into maint-0.4.3Nick Mathewson
2020-02-20dirvote: Improve the posted vote log messageteor
Cleanup after 4631.
2020-02-19dirvote: Remove an incorrect log messageteor
Cleanup after 4631.
2020-02-18dirauth: Update disabled dirvote_add_vote()teor
Update the function that handles directory authority votes when the dirauth module is disabled. Part of 4631.
2020-02-18dirauth: Refactor dirvote_add_vote()teor
Refactor dirvote_add_vote() by splitting some code out into static functions. Cleanup after 4631.