summaryrefslogtreecommitdiff
path: root/src/common
AgeCommit message (Collapse)Author
2011-05-23Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson
2011-05-22Unbreak the build on libevent 1.x systemsRobert Ransom
2011-05-23Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson
Conflicts: src/common/Makefile.am src/or/control.c
2011-05-23Merge branch 'feature3049-v2' into maint-0.2.2Nick Mathewson
Conflicts: src/common/Makefile.am
2011-05-23The first argument for a libevent callback should be evutil_socket_tNick Mathewson
2011-05-23Appease make check-spaces wrt procmon.hNick Mathewson
2011-05-21Merge branch 'maint-0.2.2'Roger Dingledine
2011-05-20what's up with this trailing whitespaceRoger Dingledine
2011-05-20Fix some commentsRobert Ransom
2011-05-20Implement __OwningControllerProcess optionRobert Ransom
Implements part of feature 3049.
2011-05-16Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson
2011-05-16Merge remote-tracking branch 'origin/maint-0.2.1' into maint-0.2.2Nick Mathewson
Fixed trivial conflict due to headers moving into their own .h files from or.h. Conflicts: src/or/or.h
2011-05-16squash! Add crypto_pk_check_key_public_exponent functionNick Mathewson
Rename crypto_pk_check_key_public_exponent to crypto_pk_public_exponent_ok: it's nice to name predicates s.t. you can tell how to interpret true and false.
2011-05-16Add crypto_pk_check_key_public_exponent functionRobert Ransom
2011-05-15Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson
2011-05-15Increase the length of the buffer in smartlist_string_num_isin().Nick Mathewson
This was harmless, since we only used this for checking for lists of port values, but it's the principle of the thing. Fixes 3175; bugfix on 0.1.0.1-rc
2011-05-15Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson
2011-05-15Make check_private_dir check for group ownership as appropriateNick Mathewson
2011-05-15Fix up some comment issues spotted by rransomNick Mathewson
2011-05-15Add a new flag to check_private_dir to make it _not_ change permissionsNick Mathewson
We'll need this for checking permissions on the directories that hold control sockets: if somebody says "ControlSocket ~/foo", it would be pretty rude to do a chmod 700 on their homedir.
2011-05-15Add a function to pull off the final component of a pathNick Mathewson
2011-05-15Make check_private_dir accept g+rx dirs if told to do so.Nick Mathewson
2011-05-15Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson
2011-05-15Merge remote-tracking branch 'origin/maint-0.2.1' into maint-0.2.2Nick Mathewson
Conflicts: src/or/networkstatus.c
2011-05-15Fixup whitespace issues from 3122 commitNick Mathewson
2011-05-15Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson
2011-05-15Merge remote-tracking branch 'origin/maint-0.2.1' into maint-0.2.2Nick Mathewson
2011-05-15Another doc tweak on tor_memcmp: <b>b</b>, not <b>.Nick Mathewson
2011-05-15minor tweaks to 4b19730c8234dRoger Dingledine
2011-05-15Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson
Conflicts: src/or/connection_edge.c
2011-05-13New smartlist function to see if two lists of strings are equal.Nick Mathewson
We'll use this to detect changes in CSV options.
2011-05-13Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson
Conflicts: src/or/config.c src/or/dirserv.c src/or/or.h
2011-05-13Add a new "tor_sockaddr_to_str()" functionNick Mathewson
It does what it says on the tin. It turns out I'll want this in a couple of places.
2011-05-12Improve a documentation commentRobert Ransom
2011-05-12Fix comment typoRobert Ransom
2011-05-11Merge remote-tracking branch 'public/bug3122_memcmp_022' into bug3122_memcmp_023Nick Mathewson
Conflicts in various places, mainly node-related. Resolved them in favor of HEAD, with copying of tor_mem* operations from bug3122_memcmp_022. src/common/Makefile.am src/or/circuitlist.c src/or/connection_edge.c src/or/directory.c src/or/microdesc.c src/or/networkstatus.c src/or/router.c src/or/routerlist.c src/test/test_util.c
2011-05-11Re-apply the automated conversion to 0.2.2 to make handle any memcmps that ↵Nick Mathewson
snuck in
2011-05-11Merge remote-tracking branch 'public/3122_memcmp_squashed' into ↵Nick Mathewson
bug3122_memcmp_022 Conflicts throughout. All resolved in favor of taking HEAD and adding tor_mem* or fast_mem* ops as appropriate. src/common/Makefile.am src/or/circuitbuild.c src/or/directory.c src/or/dirserv.c src/or/dirvote.c src/or/networkstatus.c src/or/rendclient.c src/or/rendservice.c src/or/router.c src/or/routerlist.c src/or/routerparse.c src/or/test.c
2011-05-11Hand-conversion and audit phase of memcmp transitionNick Mathewson
Here I looked at the results of the automated conversion and cleaned them up as follows: If there was a tor_memcmp or tor_memeq that was in fact "safe"[*] I changed it to a fast_memcmp or fast_memeq. Otherwise if there was a tor_memcmp that could turn into a tor_memneq or tor_memeq, I converted it. This wants close attention. [*] I'm erring on the side of caution here, and leaving some things as tor_memcmp that could in my opinion use the data-dependent fast_memcmp variant.
2011-05-11Automated conversion of memcmp to tor_memcmp/tor_mem[n]eqNick Mathewson
This commit is _exactly_ the result of perl -i -pe 's/\bmemcmp\(/tor_memcmp\(/g' src/*/*.[ch] perl -i -pe 's/\!\s*tor_memcmp\(/tor_memeq\(/g' src/*/*.[ch] perl -i -pe 's/0\s*==\s*tor_memcmp\(/tor_memeq\(/g' src/*/*.[ch] perl -i -pe 's/0\s*!=\s*tor_memcmp\(/tor_memneq\(/g' src/*/*.[ch] git checkout src/common/di_ops.[ch] git checkout src/or/test.c git checkout src/common/test.h
2011-05-11Add a "di_ops.h" include to util.hNick Mathewson
2011-05-11Add a data-independent variant of memcmp and a d-i memeq function.Nick Mathewson
The tor_memcmp code is by Robert Ransom, and the tor_memeq code is by me. Both incorporate some ideas from DJB's stuff.
2011-05-10Fix comment typoRobert Ransom
2011-05-05Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson
2011-05-05Fix up some check-spaces issuesNick Mathewson
2011-04-28Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson
2011-04-28Correct the logic from f14754fbd for tor_gmtime_rJohn Brooks
2011-04-28Detect and handle NULL returns from (gm/local)time_rNick Mathewson
These functions can return NULL for otherwise-valid values of time_t. Notably, the glibc gmtime manpage says it can return NULL if the year if greater than INT_MAX, and the windows MSDN gmtime page says it can return NULL for negative time_t values. Also, our formatting code is not guaranteed to correctly handle years after 9999 CE. This patch tries to correct this by detecting NULL values from gmtime/localtime_r, and trying to clip them to a reasonable end of the scale. If they are in the middle of the scale, we call it a downright error. Arguably, it's a bug to get out-of-bounds dates like this to begin with. But we've had bugs of this kind in the past, and warning when we see a bug is much kinder than doing a NULL-pointer dereference. Boboper found this one too.
2011-04-27Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson
2011-04-27Merge remote-tracking branch 'origin/maint-0.2.1' into maint-0.2.2Nick Mathewson
Conflicts: src/common/torint.h
7apu2bq3rhoylwmucxizk54afw5jyda7pho4j5zdcqpwkufke7zdzwad.onion