summaryrefslogtreecommitdiff
path: root/src/common
AgeCommit message (Collapse)Author
2009-03-21Actually do that memarea_strndup fix right. Not only must you not examine ↵Nick Mathewson
unmapped ram, but you also must not copy it. From lark. svn:r19095
2009-03-21fix from lark: make memarea_strndup() work even at the end of a mmap chunk. ↵Nick Mathewson
Bug was harmless for now, I think. svn:r19094
2009-03-18Add some asserts to try to catch bug 930Nick Mathewson
svn:r19074
2009-03-09doxygen tweakRoger Dingledine
svn:r18818
2009-03-03Actually use tor_sscanf() to parse untrusted input.Nick Mathewson
svn:r18761
2009-03-03Add a simple locale-independent no-surprises sscanf replacement.Nick Mathewson
tor_sscanf() only handles %u and %s for now, which will make it adequate to replace sscanf() for date/time/IP parsing. We want this to prevent attackers from constructing weirdly formed descriptors, cells, addresses, HTTP responses, etc, that validate under some locales but not others. svn:r18760
2009-03-02Add and use set/get_uint64 on onion tags. [bug 604; backportable]Nick Mathewson
It seems that 64-bit Sparc Solaris demands 64-bit-aligned access to uint64_t, but does not 64-bit-align the stack-allocated char array we use for cpuworker tags. So this patch adds a set/get_uint64 pair, and uses them to access the conn_id field in the tag. svn:r18743
2009-02-09Use prctl to reenable core dumps when we have setuid to a non-root user.Nick Mathewson
svn:r18449
2009-02-09Remove some deadcode and use tor_inet_aton uniformly.Nick Mathewson
svn:r18422
2009-01-23Fix typo found by Justin Coffi on or-talkNick Mathewson
svn:r18258
2009-01-22Support 64-bit time_t. Patch from Matthias Drochner. Partial backport ↵Nick Mathewson
candidate. svn:r18234
2009-01-21Make sure that even in the weird fiddly paths that lead to init_keys,Nick Mathewson
crypto_global_init gets called. Also have it be crypto_global_init that calls crypto_seed_rng, so we are not dependent on OpenSSL's RAND_poll in these fiddly cases. Should fix bug 907. Bugfix on 0.0.9pre6. Backport candidate. svn:r18210
2009-01-21Fix an error in tor_addr_parse that kept us from having a hidden service or ↵Nick Mathewson
a bridge live at an IPv6 address. svn:r18206
2009-01-21Fix warning on panther compile, and bug 913. Backport candidate.Nick Mathewson
svn:r18203
2009-01-20Add a better (non-locale-having) ctypes implementation to avoid protocol and ↵Nick Mathewson
parsing mismatches on different platforms. svn:r18189
2009-01-13Fix up (I hope) most ot the things that coverity suddenly claimed were ↵Nick Mathewson
REVERSE_INULL. This is what we get for bragging about being down to 0 issues. svn:r18096
2009-01-13Fix a leak memory on the failing case of test_memeq_hexNick Mathewson
svn:r18094
2009-01-10Fix a harmless-to-us bug in ht.h.Nick Mathewson
There was a field that _HT_FOI_INSERT was never setting. Everything that calls _HT_FOI_INSERT was setting it via tor_malloc_zero, but that's fragile. svn:r18064
2009-01-06Note a problem in the interface tor_addr_to_sockaddr.Nick Mathewson
svn:r17982
2009-01-04Another fun openbsd warning fix. On ioerror's computer at least, they ↵Nick Mathewson
redefined an unsigned field in zlib.h to be signed. I am quite sure this makes me more secure somehow. svn:r17892
2009-01-04OpenBSD malloc.h believes that you should be able to detect headers with ↵Nick Mathewson
autoconf, or build without warnings, but not both. So never include malloc.h on OpenBSD. Backport candidate. svn:r17891
2009-01-04Fix the oldest bug in a while: stop accepting 1.2.3 as a valid IPv4 address ↵Nick Mathewson
on any platform. svn:r17887
2009-01-04Remove svn $Id$s from our source, and remove tor --version --version.Nick Mathewson
The subversion $Id$ fields made every commit force a rebuild of whatever file got committed. They were not actually useful for telling the version of Tor files in the wild. svn:r17867
2009-01-02Only set sin_len/sin6_len when they exist.Nick Mathewson
svn:r17851
2009-01-02Try harder to make sure we zero-out the extraneous sockaddr fields and that ↵Nick Mathewson
we set sockaddr_len. Conceivably a backport candidate, though nothing has yet been sen to break. svn:r17849
2008-12-30Remove some code that is #ifdefed out, and that we no longer seem to use, if ↵Nick Mathewson
we ever did. svn:r17827
2008-12-29Use a consistent naming standard for header file guard macros, taking care ↵Nick Mathewson
not to collide with any system headers. This tripped us up on Android. svn:r17805
2008-12-29Use RSA_generate_key_ex where available.Nick Mathewson
svn:r17804
2008-12-29Fix bug in recent address.c patch: actually set the value of address * to ↵Nick Mathewson
0.0.0.0 as we did before. This makes CMP_EXACT comparisons with bitmask 0 work on address * again. svn:r17801
2008-12-27Fix compilation under gethostbyname-based systems.Nick Mathewson
svn:r17800
2008-12-26Refactor tor_addr_t manipulation functions so that as few as possible look ↵Nick Mathewson
at the tor_addr_t representation. svn:r17790
2008-12-26get_interface_addr6(), and by extension get_interface_addr(), were pretty ↵Nick Mathewson
borked. Copying a tor_addr_t from a sockaddr_storage using memcpy is a poor notion. svn:r17789
2008-12-26Refactor tor_addr_compare_masked() so that CMP_SEMANTIC makes more sense, ↵Nick Mathewson
and has decent semantics for maskbits; and so that CMP_EXACT works right for bits==0. svn:r17788
2008-12-26Document our Bloom filter parameter choices.Nick Mathewson
svn:r17785
2008-12-26Add more missing documentation, and correct an error in container.c ↵Nick Mathewson
documentation: Don't introduce two parameters called n when you're calling an algorithm O(n). svn:r17783
2008-12-25some fixes i found in my sandboxRoger Dingledine
svn:r17771
2008-12-23Document most undocumented variables.Nick Mathewson
svn:r17754
2008-12-23Properly zero-out addresses when setting them. Probably this was not ↵Nick Mathewson
hurting anything. svn:r17749
2008-12-22Make freelist_len in memarea.c static; document a few variables.Nick Mathewson
svn:r17741
2008-12-22Add DOCDOC entries for undocumented static and global variables.Nick Mathewson
svn:r17739
2008-12-22Fix most DOCDOCs remaining and/or added by redox.Nick Mathewson
svn:r17734
2008-12-22Add DOCDOC comments for all undocumented functions. Add missing *s to other ↵Nick Mathewson
comments so that they will get recognized as doxygen. svn:r17729
2008-12-22Fix all of the doxygen warnings not pertaining to missing documentation.Nick Mathewson
svn:r17727
2008-12-19Move in-addr.arpa parsing and generation into address.c, and simplify the ↵Nick Mathewson
code that does it elsewhere. Incidentally, this lets exit servers answer requests for ip6.arpa addresses. svn:r17707
2008-12-19Expose hex_decode_digit from util.cNick Mathewson
svn:r17706
2008-12-18Replace calls to time(NULL) that occur on the order of once per read, one ↵Nick Mathewson
per write, or once per cell with calls to a function that looks at a cached value of time. This is tricksy to benchmark, since it will only help on systems where time() is a syscall and syscalls are relatively slow. svn:r17690
2008-12-18One log.c XXX021 was a misunderstanding. Also, clip log messages passed to ↵Nick Mathewson
syslog to their maximum length when there is a maximum. svn:r17688
2008-12-18Downlgrade tweak, and answer lots of XXX021s. No actual code fixes in this ↵Nick Mathewson
patch. svn:r17686
2008-12-18Ben confirms that the MUST in rfc2631 is only for compatibility with X9.42, ↵Nick Mathewson
and isn't actually a security thing. svn:r17685
2008-12-18Log an error on win32 if directory listing fails.Nick Mathewson
svn:r17684