summaryrefslogtreecommitdiff
path: root/src/common/util.c
AgeCommit message (Collapse)Author
2011-01-03Merge remote branch 'origin/maint-0.2.2'Nick Mathewson
2011-01-03Merge remote branch 'origin/maint-0.2.1' into maint-0.2.2Nick Mathewson
Conflicts: src/common/test.h src/or/test.c
2011-01-03Bump copyright statements to 2011Nick Mathewson
2010-12-19Merge branch 'maint-0.2.2'Roger Dingledine
2010-12-15Merge remote branch fix_security_bug_021 into fix_security_bug_022Nick Mathewson
Conflicts: src/common/memarea.c src/or/or.h src/or/rendclient.c
2010-12-13Have all of our allocation functions and a few others check for underflowNick Mathewson
It's all too easy in C to convert an unsigned value to a signed one, which will (on all modern computers) give you a huge signed value. If you have a size_t value of size greater than SSIZE_T_MAX, that is way likelier to be an underflow than it is to be an actual request for more than 2gb of memory in one go. (There's nothing in Tor that should be trying to allocate >2gb chunks.)
2010-12-01Fix connecting the stdin of tor-fw-helper to /dev/nullSteven Murdoch
This wasn't working due to the parameters of dup2 being in the wrong order. As a result, tor-fw-helper was inheriting the stdin of Tor.
2010-11-20Obviate need for doing a CLOEXEC on pipes: just close them before execNick Mathewson
2010-11-20Initial work to set CLOEXEC on all possible fdsNick Mathewson
Still to go: some pipes, all stdio files.
2010-10-15Remove the unused old fuzzy-time codeNick Mathewson
2010-10-13Merge branch 'nodes'Nick Mathewson
2010-10-11Merge remote branch 'sjmurdoch/bug1903'Nick Mathewson
2010-10-11Make tor_sscanf handle %xNick Mathewson
2010-10-10Add a unit test for tor_spawn_backgroundSteven Murdoch
- Test sucessfully starting a process - Test failing to find the executable
2010-10-10Update documentation for tor_spawn_backgroundSteven Murdoch
- Include description of stdout_read, stderr_read, and argv
2010-10-10Fix issues in nickm's review of log_from_pipe for bug #1903Steven Murdoch
- Replace sscanf with tor_sscanf - Replace use of strstr with equivalent call to strcmpstart
2010-10-10Fix nickm's comments on logging for bug #1903Steven Murdoch
- Use log_warn rather than log_err for bad but survivable events
2010-10-10Note icky constructs mentioned in bug #1903Steven Murdoch
- To be dealt with as part of bug #2029
2010-10-04Fix issues in nickm's review of format_helper_exit_status for bug #1903Steven Murdoch
- Responsibility of clearing hex_errno is no longer with caller - More conservative bounds checking - Length requirement of hex_errno documented - Output format documented
2010-10-01Implement a few more node-based functionsNick Mathewson
Some of these functions only work for routerinfo-based nodes, and as such are only usable for advisory purposes. Fortunately, our uses of them are compatible with this limitation.
2010-10-01Initialize fd values in tor_port_check_forwarding to -1Nick Mathewson
2010-09-30Merge branch 'tor-fw-squashed2'Nick Mathewson
Conflicts: src/common/util.c
2010-09-30Fix space and formatting issuesNick Mathewson
2010-09-30#if-out the fw-helper code in util.c when building on windowsNick Mathewson
2010-09-30Start tor-fw-helper in the background, and log whatever it outputsSteven Murdoch
2010-09-30Fix check-spacesSebastian Hahn
2010-09-27Merge remote branch 'public/bug1954' into maint-0.2.2Nick Mathewson
2010-09-24Consistency issues in load_windows_system_library patch. Thanks SebastianNick Mathewson
2010-09-24Note that the torrc format doesn't need nl at endSebastian Hahn
2010-09-23Tweak continuation-and-comment logicNick Mathewson
I think there was a read-off-the-end-of-the-buffer bug that I fixed. At least I added some good comments, I hope.
2010-09-21New function to load windows system librariesNick Mathewson
This function uses GetSystemDirectory() to make sure we load the version of the library from c:\windows\system32 (or local equivalent) rather than whatever version lives in the cwd.
2010-09-11Allow comments for multi-line torrc optionsSebastian Hahn
2010-09-10Support mutli-line torrc options via the usual backslash syntaxNick Mathewson
2010-09-06Merge remote branch 'public/win_unicode_fixes'Nick Mathewson
2010-08-31Fix some issues in rate-limiting noticed by SebastianNick Mathewson
2010-08-20Make the windows build succeed with or without -DUNICODE enabled.Nick Mathewson
This should keep WinCE working (unicode always-on) and get Win98 working again (unicode never-on). There are two places where we explicitly use ASCII-only APIs, still: in ntmain.c and in the unit tests. This patch also fixes a bug in windoes tor_listdir that would cause the first file to be listed an arbitrary number of times that was also introduced with WinCE support. Should fix bug 1797.
2010-08-18Add a generic rate-limited log mechanism, and use it in a few placesNick Mathewson
Incidentally fixes bug 1042.
2010-07-09Rename log.h to torlog.hNick Mathewson
This should make us conflict less with system files named "log.h". Yes, we shouldn't have been conflicting with those anyway, but some people's compilers act very oddly. The actual change was done with one "git mv", by editing Makefile.am, and running find . -name '*.[ch]' | xargs perl -i -pe 'if (/^#include.*\Wlog.h/) {s/log.h/torlog.h/; }'
2010-06-14Save a couple characters' allocation in esc_for_logFlorian Zumbiehl
2010-06-07Reinstate warning when HOME isn't set.Nick Mathewson
Having ~/.tor expand into /.tor is, after all, almost certainly not what the user wanted, and it deserves a warning message. Also, convert a guess-and-malloc-and-sprintf triple into an asprintf.
2010-06-07Treat unset $HOME like empty $HOMESebastian Hahn
This means Tor no longer dies when it doesn't have a $HOME.
2010-05-24Port Tor to work on Windows CEvalerino
Most of the changes here are switches to use APIs available on Windows CE. The most pervasive change is that Windows CE only provides the wide-character ("FooW") variants of most of the windows function, and doesn't support the older ASCII verions at all. This patch will require use of the wcecompat library to get working versions of the posix-style fd-based file IO functions. [commit message by nickm]
2010-02-27Merge remote branch 'origin/maint-0.2.1'Nick Mathewson
Conflicts: src/common/test.h src/or/test.c
2010-02-27Update Tor Project copyright yearsNick Mathewson
2010-02-22Make expand_filename into a tor_strdup() alias on windows.Nick Mathewson
On Windows, we don't have a notion of ~ meaning "our homedir", so we were deliberately using an #ifdef to avoid calling expand_filename() in multiple places. This is silly: The right place to turn a function into a no-op on a single platform is in the function itself, not in every single call-site.
2009-12-18Remove duplicate words and a duplicate newline.Karsten Loesing
2009-12-17Refactor out the 'find string at start of any line' logic.Nick Mathewson
We do this in too many places throughout the code; it's time to start clamping down. Also, refactor Karsten's patch to use strchr-then-strndup, rather than malloc-then-strlcpy-then-strchr-then-clear.
2009-12-15Refactor a bit so that it is safe to include math.h, and mostly not needed.Nick Mathewson
2009-12-12Merge commit 'sebastian/fixes'Nick Mathewson
2009-12-12Now that FOO_free(NULL) always works, remove checks before calling it.Nick Mathewson