| Age | Commit message (Collapse) | Author |
|---|
|
Apparently, my compiler now generates coverage markers for
label-only lines, so we need to exclude those too if they are meant
to be unreachable.
|
|
|
|
|
|
|
|
|
|
Catalyst points out that using pw_uid for two different purposes
here is likely to be confusing.
|
|
Closes 23528.
|
|
|
|
For the most part, these indicated a spot where the code could have
been better.
|
|
Found with clang's scan-build while looking at dead assignments.
Fixes bug 23487; bugfix on 1135405c8c6ea31 in 0.2.9.1-alpha
|
|
This is probably what the user wants, according to 20119.
|
|
|
|
We only did this on windows when building with MSVC 6 and earlier,
which is now considered a screamingly bad idea.
|
|
The contract is that, if may_spawn_background_process() is 0, you're
not even allowed to try to spawn a process.
|
|
Core of an implementation for 22976.
|
|
|
|
|
|
|
|
Wow, it sure seems like some compilers can't implement isnan() and
friends in a way that pleases themselves!
Fixes bug 22915. Bug trigged by 0.2.8.1-alpha and later; caused by
clang 4.
|
|
|
|
|
|
The 22081 fix disabled -Wfloat-conversion, but -Wfloat-conversion
didn't exist in every relevant mingw; it was added in GCC 4.9.x some
time, if the documentation can be trusted.
Bug not in any released version of tor.
|
|
|
|
|
|
|
|
We just have to suppress these warnings: Mingw's math.h uses gcc's
__builtin_choose_expr() facility to declare isnan, isfinite, and
signbit. But as implemented in at least some versions of gcc,
__builtin_choose_expr() can generate type warnings even from
branches that are not taken.
Fixes bug 22801; bugfix on 0.2.8.1-alpha.
|
|
No code changes needed: in the places where we actually check the
return value of these functions, we handle it correctly.
|
|
|
|
config_get_lines is now split into two functions:
- config_get_lines which is the same as before we had %include
- config_get_lines_include which actually processes %include
|
|
|
|
This patch fixes a regression described in bug #21757 that first
appeared after commit 6e78ede73f which was an attempt to fix bug #21654.
When switching from buffered I/O to direct file descriptor I/O our
output strings from get_string_from_pipe() might contain newline
characters (\n). In this patch we modify tor_get_lines_from_handle() to
ensure that the function splits the newly read string at the newline
character and thus might return multiple lines from a single call to
get_string_from_pipe().
Additionally, we add a test case to test_util_string_from_pipe() to
ensure that get_string_from_pipe() correctly returns multiple lines in a
single call.
See: https://bugs.torproject.org/21757
See: https://bugs.torproject.org/21654
|
|
|
|
This patch changes a number of read loops in the util module to use
less-than comparison instead of not-equal-to comparison. We do this in
the case that we have a bug elsewhere that might cause `numread` to
become larger than `count` and thus become an infinite loop.
|
|
This patch removes the buffered I/O stream usage in process_handle_t and
its related utility functions. This simplifies the code and avoids racy
code where we used buffered I/O on non-blocking file descriptors.
See: https://bugs.torproject.org/21654
|
|
This patch modifies `tor_read_all_handle()` to use read(2) instead of
fgets(3) when reading the stdout from the child process. This should
eliminate the race condition that can be triggered in the 'slow/util/*'
tests on slower machines running OpenBSD, FreeBSD and HardenedBSD.
See: https://bugs.torproject.org/21654
|
|
This patch changes our use of fgets() to tor_fgets() for more consistent
error handling across different versions of the C library.
|
|
|
|
Fixes bug 20894; bugfix on 0.2.0.16-alpha.
We already applied a workaround for this as 20834, so no need to
freak out (unless you didn't apply 20384 yet).
|
|
|
|
|
|
Give size_mul_check() external linkage and use it in base64_decode() to
avoid a potential integer wrap.
Closes #19222
|
|
|
|
|
|
(We previously added support for generating the spaceless
2016-11-14T19:58:12 variant, but not for actually parsing it.)
|
|
existing one failed
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
|
Conflicts:
src/or/rendservice.c
|
|
Comment changes only
|
|
Use the following coccinelle script to change uses of
smartlist_add(sl, tor_strdup(str)) to
smartlist_add_strdup(sl, string) (coccinelle script from nickm
via bug 20048):
@@
expression a;
expression b;
@@
- smartlist_add
+ smartlist_add_strdup
(a,
- tor_strdup(
b
- )
)
|
|
Add smartlist_add_strdup(sl, string) - replaces the use of
smartlist_add(sl, tor_strdup(string)). Fixes bug 20048.
|
|
|
