Age | Commit message (Collapse) | Author |
|
Our old https://bugs.torproject.org/nnnn URLs only work for bugs
numbered before 40000. Newer gitlab bugs need to have specific
projects mentioned.
This patch assumes that bugs are in tpo/core/tor by default, but
allows us to refer to several other projects by saying
e.g. "chutney#40002" if we want.
|
|
Co-authored-by: Florentin Rochet <florentin.rochet@uclouvain.be>
|
|
|
|
Per <https://trac.torproject.org/projects/tor/ticket/34381>, these
contrib scripts were generated by older versions of Tor and shellcheck
will throw warnings if they still exist.
|
|
|
|
Move a series of function from config.c into that new file which is related to
address resolving.
Part of #33789
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
|
Accept a few extra lines from the connection_buf_read_from_socket()
refactor.
Cleanup after 33131.
|
|
We added a cast, and wrapped a line.
|
|
Lock-in improvements.
Accept some small function size increases.
Allow a small amount of extra file size increase.
|
|
|
|
Lock in some file and function size improvements.
Accept some small file size and dependency increases.
Part of 33633.
|
|
|
|
|
|
|
|
|
|
|
|
Ignore editor temporary files when autostyling in:
* rectify_include_paths.py
* rename_c_identifier.py
Obviously correct changes to already-reviewed code.
|
|
|
|
|
|
Accept a smaller file and function.
Let router.c grow slightly without warning.
Accept an extra comment line.
Cleanup after 32588.
|
|
Due to improved function comments.
|
|
Accept the current state of the tor codebase, including all the
files and functions that have increased technical debt over the
last few months.
Accepts all the current practracker warnings, so that reviewers
can focus on new warnings.
Closes ticket 33635.
|
|
We've successfully resolved a bunch of technical debt over the last
few months. Let's remove the allowances for that debt from the
practracker exceptions.
|
|
When a service can not upload its descriptor(s), we have no logs on why. This
adds logging for each possible reason for each descriptors.
That logging is emitted every second so it is rate limited for each reason and
per descriptor.
Closes #33400
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
This is not the only relay-only handshake code, but it is most of
such code that is in connection_or.c.
|
|
Allow the "practracker" coding best practices checking script to read
unicode files, when using Python 2.
We made the script use unicode literals in 0.4.3.1-alpha, but didn't
change the codec for opening files.
Fixes bug 33374; bugfix on 0.4.3.1-alpha.
|
|
Closes ticket 33373.
|
|
|
|
|
|
Fixes 33192
|
|
Add a script to help check the alphabetical ordering of option names
in a manpage. Closes ticket 33339.
|
|
|
|
Conflicts:
doc/tor.1.txt
src/app/config/config.c
src/app/config/or_options_st.h
src/core/mainloop/connection.h
Between 042 and 043, the dirauth options were modularized so this merge commit
address this by moving the AuthDirRejectUncompressedRequests to the module
along with a series of accessors.
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
|
We're telling clang-format that a line with LCOV_EXCL must not be
split -- that's fine, but we shouldn't complain when it indents it.
|
|
Previously we would forbid macro indentations like this:
FOO({
int x;
})
But clang-format sometimes generates those.
|
|
|
|
Clang-format wants to put these in, and they do make sense for
consistency.
Also allow more types.
|
|
|
|
|
|
|
|
|
|
The format is the same as in my previous efforts here.
The script is a little tricky, since it invokes both clang-format
and codetool, and it makes sure that files do not have a changed
mtime unless there is actually some change in the file.
|
|
This code transformer makes a couple of changes that we want for our
source code, and can be expanded to handle more.
|