| Age | Commit message (Collapse) | Author |
|---|
|
Closes ticket 32372.
|
|
Except for src/ext, which we may not want to modify.
Closes ticket 32732.
|
|
The purpose of tracking whether an exception is used is so that we
can tell whether it is overbroad. This means that an _underbroad_
exception is still a used one. Fixes bug 31338.
|
|
|
|
We treat "0" as the expected number, and warn about everything
else. The problem type is "dependency-violation".
|
|
I'm using 500 as a file size limit, and 15 as an include limit.
This affects comparatively few files, but I think they are the worst
ones.
Closes ticket 31175.
|
|
I had the logic reversed here.
|
|
Now that there is only one toplevel place where we print problems,
we can redirect just that one print to a file when we are
regenerating the exceptions.txt file. Previously we redirected
sys.stdout, which is naughty, and forced us to send warnings (and
warnings alone) to stderr.
|
|
Previously warnings were generated by magic inside ProblemVault; now
they're printed on demand.
|
|
Instead of having "consider" functions that have to call a global
ProblemVault, we can now generate all the metrics for the code
separately from the decision about what to do for them.
|
|
I'm about to refactor the code into a set of iterators that yield
*all* the metrics for the code, and then add a filter on top of that
to return the problems.
|
|
When an exception is present, we can now violate the limit by a little
bit and only produce a warning. The strict flag overrides this
behavior.
I've given file sizes a 2% tolerances and function sizes/include
counts a 10% tolerance.
Part of 30752
|
|
This option lists every exception that is stricter than it needs to
be.
Part of 30752
|
|
Also add a useful argument parser.
|
|
Also, distinguish between empty lines (which we should ignore)
and incorrect lines (which we should warn about).
|
|
|
|
|
|
|
|
This was causing issues because the exceptions file is written using Posix
paths, whereas practracker in Windows was trying to match Windows paths ("\"
instead of "/").
|
|
|
|
- Introduce 'make check-best-practices'.
- Fix up Tor topdir etc to work with the way 'make check-local' gets called.
- Make practracker less likely to print useless stuff.
|
|
|
|
|
