aboutsummaryrefslogtreecommitdiff
path: root/scripts/maint/checkSpace.pl
AgeCommit message (Collapse)Author
2021-09-07Align and fix indentations in several maint scriptsskaluzka
Use 4 spaces indentations, convert tabs to spaces. No real code changes.
2020-02-06checkSpace: permit wide lines for LCOV_EXCLNick Mathewson
We're telling clang-format that a line with LCOV_EXCL must not be split -- that's fine, but we shouldn't complain when it indents it.
2020-02-06checkSpace: be more careful about bad function headers.Nick Mathewson
Previously we would forbid macro indentations like this: FOO({ int x; }) But clang-format sometimes generates those.
2020-02-06checkSpace: don't treat an unindented label as starting a function.Nick Mathewson
2020-02-06checkSpace.pl: Allow space between iteration macros and ().Nick Mathewson
Clang-format wants to put these in, and they do make sense for consistency. Also allow more types.
2020-02-06checkSpace.pl: Use a data structure for a list of non-function namesNick Mathewson
2020-02-06checkspace: allow spaces in cpp directives.Nick Mathewson
2020-02-06checkSpace.pl: allow {{, ){, and ({.Nick Mathewson
2020-02-06checkSpace: remove the nosplabel test.Nick Mathewson
2019-11-26checkSpace.pl: make output more uniform.Nick Mathewson
There were lots of slight differences in indentation and formatting among the in-file error messages.
2019-11-26check-spaces: Fix an outdated commentteor
2019-06-24checkSpace.pl: Allow 'bool' before a space and an open-parenNick Mathewson
We need this so we can declare function pointers returning bool without upsetting our style checker. :/
2019-03-12Make checkSpace.pl check guard macros:Nick Mathewson
- every .h file needs an #ifndef/#define pair. - They must refer to the same macro. - The guard macros that they refer to must be unique across all headers.
2018-06-18New check-spaces rule: Our C files may not have duplicate names.Nick Mathewson
2018-06-18Finally remove our EOL@EOF check.Nick Mathewson
This check was added by mistake long ago. It will be nice to see these EOLs disappear from our code over time.
2017-09-18Add check for double-semi-colons at the end of a lineEdmund Wong
2017-09-08test: Add an HS v3 reachability unit testDavid Goulet
This is a large and important unit test for the hidden service version 3! It tests the service reachability for a client using different consensus timings and makes sure that the computed hashring is the same on both side so it is actually reachable. Signed-off-by: David Goulet <dgoulet@torproject.org>
2016-12-16Use the new message functioncypherpunks
Substitutions were made using `sed -e 's/print/msg/g'`.
2016-12-16Add a function to keep track of found errorscypherpunks
2016-12-16Restrict unsafe constructs and enable all warningscypherpunks
2016-12-16Declare all variables to be localcypherpunks
Without the 'my' keyword the variables are global and Perl requires global symbols to include an explicit package name.
2016-12-16Convert tabs to spacescypherpunks
2016-09-06checkSpace.pl now forbids more identifiers.Nick Mathewson
The functions it warns about are: assert, memcmp, strcat, strcpy, sprintf, malloc, free, realloc, strdup, strndup, calloc. Also, fix a few lingering instances of these in the code. Use other conventions to indicate _intended_ use of assert and malloc/realloc/etc.
2015-08-21Observe workqueue_reply_t in check-spacesSebastian Hahn
2014-09-30Make 'make check-spaces' not complain about function pointers returning ↵Andrea Shepard
size_t or double
2014-08-18Improve comments in checkSpace.pl to explain how to fix its warningsNick Mathewson
2014-04-28Clean the contrib directory with torch and machete.Nick Mathewson
We've accumulated a lot of cruft in this directory over the years: so much, that it passed the point of being so disorganized that we no longer browsed through it to see how bad it had gotten. This patch (based on changes by rl1987) tries to remove the most useless items, and split the others into reasonable directories. It creates a new scripts/ directory for maint and test scripts. This patch was generated with the script below. No other changes are made in this patch. ############# # new directories mkdir -p contrib/test-tools mkdir -p contrib/or-tools mkdir -p contrib/dirauth-tools mkdir -p contrib/operator-tools mkdir -p contrib/client-tools mkdir -p contrib/test-tools mkdir -p contrib/dist mkdir -p contrib/dist/suse mkdir -p contrib/win32build mkdir -p scripts/maint mkdir -p scripts/test ############ # Deleted -- nobody who wants this is going to be looking for it here any # longer. Also, nobody wants it. git rm contrib/auto-naming/README # Deleted: We no longer do polipo. git rm contrib/polipo/Makefile.mingw git rm contrib/polipo/README git rm contrib/polipo/polipo-mingw.nsi # We haven't even tried to run this for ages. It is a relic of a bygone era git rm contrib/mdd.py # contrib/dir-tools/directory-archive/ # Tools for running a directory archive. No longer used - deleting them. git rm contrib/directory-archive/crontab.sample git rm contrib/directory-archive/fetch-all git rm contrib/directory-archive/fetch-all-v3 git rm contrib/directory-archive/tar-them-up git rm contrib/directory-archive/fetch-all-functions git rm contrib/directory-archive/sort-into-month-folder # This appears to be related to very old windows packaging stuff. git rm contrib/bundle.nsi git rm contrib/package_nsis-weasel.sh git rm contrib/package_nsis.sh git rm contrib/netinst.nsi git rm contrib/torinst32.ico git rm contrib/xenobite.ico # This should not be needed for cross-compilation any more, should it? git rm contrib/cross.sh # I don't think anyone ever used this. git rm contrib/make-signature.sh # These are attempts to send tor controller commands from the command-line. # They don't support modern authentication. git rm contrib/tor-ctrl.sh # this is for fetching about a tor server from a dirauth. But it # doesn't authenticate the dirauth: yuck. git rm contrib/sd # wow, such unused, very perl4. git rm contrib/tor-stress ####### contrib/dirauth-tools/ # Tools for running a directory authority git mv contrib/add-tor contrib/dirauth-tools/ git mv contrib/nagios-check-tor-authority-cert contrib/dirauth-tools/ ####### # contrib/or-tools/ # Tools for examining relays git mv contrib/check-tor contrib/or-tools/check-tor git mv contrib/checksocks.pl contrib/or-tools/checksocks.pl git mv contrib/exitlist contrib/or-tools/exitlist ####### # contrib/operator-tools # Tools for running a relay. git mv contrib/linux-tor-prio.sh contrib/operator-tools/linux-tor-prio.sh git mv contrib/tor-exit-notice.html contrib/operator-tools/tor-exit-notice.html git mv contrib/tor.logrotate.in contrib/operator-tools/ ###### # contrib/dist git mv contrib/rc.subr contrib/dist/ git mv contrib/tor.sh.in contrib/dist/ git mv contrib/torctl.in contrib/dist/ git mv contrib/suse/* contrib/dist/suse/ ###### # client-tools git mv contrib/torify contrib/client-tools/torify git mv contrib/tor-resolve.py contrib/client-tools/ ###### # win32build git mv contrib/package_nsis-mingw.sh contrib/win32build/ git mv contrib/tor.nsi.in contrib/win32build/ # Erinn didn't ask for this... git mv contrib/tor-mingw.nsi.in contrib/win32build/ git mv contrib/tor.ico contrib/win32build/ ###### # scripts/test git mv contrib/cov-blame scripts/test/cov-blame git mv contrib/cov-diff scripts/test/cov-diff git mv contrib/coverage scripts/test/coverage git mv contrib/scan-build.sh scripts/test/ ######## scripts/maint # Maintainance scripts # # These are scripts for developers to use when hacking on Tor. They mostly # look at the Tor source in one way or another. git mv contrib/findMergedChanges.pl scripts/maint/findMergedChanges.pl git mv contrib/checkOptionDocs.pl scripts/maint/checkOptionDocs.pl git mv contrib/checkSpace.pl scripts/maint/checkSpace.pl git mv contrib/redox.py scripts/maint/redox.py git mv contrib/updateVersions.pl scripts/maint/updateVersions.pl git mv contrib/checkLogs.pl scripts/maint/checkLogs.pl git mv contrib/format_changelog.py scripts/maint/