Age | Commit message (Collapse) | Author |
|
|
|
This warning, IIUC, means that the compiler doesn't like it when it
sees a NULL check _after_ we've already dereferenced the
variable. In such cases, it considers itself free to eliminate the
NULL check.
There are a couple of tricky cases:
One was the case related to the fact that tor_addr_to_in6() can
return NULL if it gets a non-AF_INET6 address. The fix was to
create a variant which asserts on the address type, and never
returns NULL.
|
|
|
|
Suppress it in the one spot in the code where we actually do want to
allow an aggregate return in order to call the mallinfo() API.
|
|
|
|
|
|
Previously, if the header was present, we'd proceed even if the
function wasn't there.
Easy fix for bug 19161. A better fix would involve trying harder to
find libscrypt_scrypt.
|
|
Add --enable-fatal-warnings to control -Werror.
Closes ticket 19044.
|
|
|
|
|
|
We use a pretty specific pair of autoconf tests here to make sure
that we only add this code when:
a) a 64-bit signed multiply fails to link,
AND
b) the same 64-bit signed multiply DOES link correctly when
__mulodi4 is defined.
Closes ticket 19079.
|
|
Fix the new crypto tests, which used truncate(3).
|
|
There were some conflicts here, and some breakage to fix concerning
library link order in newer targets.
|
|
|
|
We know there are overflows in curve25519-donna-c32, so we'll have
to have that one be fwrapv.
Only apply the asan, ubsan, and trapv options to the code that does
not need to run in constant time. Those options introduce branches
to the code they instrument.
(These introduced branches should never actually be taken, so it
might _still_ be constant time after all, but branch predictors are
complicated enough that I'm not really confident here. Let's aim for
safety.)
Closes 17983.
|
|
|
|
|
|
|
|
This makes our compilation options checks in autoconf work better on
systems that already define _FORTIFY_SOURCE.
Fixes at least one case of bug 18841; bugfix on 0.2.3.17-beta. Patch
from "trudokal".
|
|
|
|
Fixes the last case of 17744.
|
|
|
|
|
|
|
|
|
|
|
|
We added these a while ago, but they do no actual good, and
cause implicit declaration warnings in some situations. Rather than
just adding stdint.h, it's easier to remove the exit() calls
as redundant.
Fixes bug 18626; bugfix from "cypherpunks"
|
|
This will centralize the version configuration in one file to simplify
future changes.
Also fixes some typos in the Automake options comments.
|
|
CentOS 6 is roughly the oldest thing we care about developers still
using, and it has autoconf 2.63 / automake 1.11. These are both
older than openssl 1.0.0, so anybody who can't upgrade past those
probably can't upgrade to a modern openssl either. And since only
people building from git or editing configure.ac/Makefile.am need to
use autotools, I'm not totally enthused about keeping support for
old ones anyway.
Closes ticket 17732.
|
|
Solves #17744
The syntax has been generalized too, so there are only double quotes.
Signed-off-by: zerosion <zerosion@protonmail.ch>
|
|
|
|
|
|
|
|
|
|
Closes ticket 18242.
The rationale here is that I like having coverage on by default in my
own working directory, but I always want assertions turned on unless
I'm doing branch coverage specifically.
|
|
|
|
We've never actually tested this support, and we should probably assume
it's broken.
To the best of my knowledge, only OpenVMS has this, and even on
OpenVMS it's a compile-time option to disable it. And I don't think
we build on openvms anyway. (Everybody else seems to be working
around the 2038 problem by using a 64-bit time_t, which won't expire
for roughly 292 billion years.)
Closes ticket 18184.
|
|
We could be using AC_CHECK_FUNC_DECL too, but it shouldn't be needed.
|
|
|
|
|
|
See ticket 17944; patch from "logan".
|
|
|
|
This will fix the detection of struct in6_addr.s6_addr32 and others
Found and fixed by cypherpunks; bug 17923; bugfix on f948caad7b5bd
|
|
|
|
Fixes bug 17819; bugfix on 0.2.6.3-alpha (specifically, d684dbb0).
|
|
|
|
This feature allows us to bind low ports when starting as root and
switching UIDs.
Based on code by David Goulet.
Implement feature 8195
|
|
|
|
|
|
patch from rubiate on #16651
|