summaryrefslogtreecommitdiff
path: root/changes
AgeCommit message (Collapse)Author
2020-09-14Start an 0.4.4.5 changelogNick Mathewson
2020-09-08Merge branch 'maint-0.4.4' into release-0.4.4David Goulet
2020-09-07statistics: Properly count all rendezvous cells (avoid undercounting).George Kadianakis
tl;dr We were not counting cells flying from the client to the service, but we were counting cells flying from the service to the client. When a rendezvous cell arrives from the client to the RP, the RP forwards it to the service. For this to happen, the cell first passes through command_process_relay_cell() which normally does the statistics counting. However because the `rend_circ` circuit was not flagged with `circuit_carries_hs_traffic_stats` in rend_mid_rendezvous(), the cell is not counted there. Then the cell goes to circuit_receive_relay_cell() which has a special code block based on `rend_splice` specifically for rendezvous cells, and the cell gets directly passed to `rend_circ` via a direct call to circuit_receive_relay_cell(). The cell never passes through command_process_relay_cell() ever again and hence is never counted by our rephist module. The fix here is to flag the `rend_circ` circuit with `circuit_carries_hs_traffic_stats` so that the cell is counted as soon as it hits command_process_relay_cell(). Furthermore we avoid double-counting cells since the special code block of circuit_receive_relay_cell() makes us count rendezvous cells only as they enter the RP and not as they exit it. Fixes #40117.
2020-08-25Merge branch 'maint-0.4.4' into release-0.4.4David Goulet
2020-08-25Avoid guard-related warning when upgrading from 043 to 044.George Kadianakis
Fixes #40105.
2020-08-25Merge branch 'maint-0.4.4' into release-0.4.4George Kadianakis
2020-08-25Merge remote-tracking branch 'tor-gitlab/mr/130' into maint-0.4.4George Kadianakis
2020-08-20Merge branch 'maint-0.4.4' into release-0.4.4George Kadianakis
2020-08-20v3 control: Persist ONION_CLIENT_AUTH_ADD client nameNeel Chauhan
2020-08-19hs: Don't overwrite DoS parameters on circuit with consensus paramsDavid Goulet
Turns out that the HS DoS defenses parameters were overwritten by the consensus parameters everytime a new consensus would arrive. This means that a service operator can still enable the defenses but as soon as the intro point relay would get a new consensus, they would be overwritten. And at this commit, the network is entirely disabling DoS defenses. Fix this by introducing an "explicit" flag that indicate if the ESTABLISH_INTRO cell DoS extension set those parameters or not. If set, avoid using the consenus at once. We are not bumping the protover HSIntro value for this because 0.4.2.x series is EOL in 1 month and thus 0.4.3.x would be the only series with this bug. We are confident that a backport and then upgrade path to the latest 0.4.4.x stable coming up soon is enough to mitigate this problem in the coming months. It avoids the upgrade path on the service side by keeping the requirement for protover HSIntro=5. Fixes #40109 Signed-off-by: David Goulet <dgoulet@torproject.org>
2020-08-19Merge branch 'maint-0.4.4' into release-0.4.4George Kadianakis
2020-08-19Merge branch 'mr/124' into maint-0.4.4George Kadianakis
2020-08-19Parallelize src/test/test into chunks.Nick Mathewson
First, we introduce a flag to teach src/test/test to split its work into chunks. Then we replace our invocation of src/test/test in our "make check" target with a set of 8 scripts that invoke the first 8th of the tests, the second 8th, and so on. This change makes our "make -kj4 check" target in our hardened gitlab build more than twice as fast, since src/test/test was taking the longest to finish. Closes 40098.
2020-08-18Merge branch 'maint-0.4.4' into release-0.4.4David Goulet
2020-08-18Merge branch 'tor-gitlab/mr/121' into maint-0.4.4David Goulet
2020-08-13Merge branch 'maint-0.4.2' into maint-0.4.3Nick Mathewson
2020-08-13Merge branch 'maint-0.4.4' into release-0.4.4Nick Mathewson
2020-08-13Merge branch 'maint-0.4.3' into maint-0.4.4Nick Mathewson
2020-08-13Merge branch 'maint-0.3.5' into maint-0.4.2maint-0.4.2Nick Mathewson
2020-08-12Changelog draft for 0.4.4.4-rcNick Mathewson
2020-08-12Fix allocation counting in clean_v2_descs_as_dir test.Nick Mathewson
Without this fix, running this test on its own would fail. Fixes bug 40099. Bugfix on ade5005853c17b3 in 0.2.8.1-alpha.
2020-08-12Merge branch 'maint-0.4.4' into release-0.4.4George Kadianakis
2020-08-12Merge remote-tracking branch 'tor-gitlab/mr/107' into maint-0.4.4George Kadianakis
2020-08-12Merge branch 'maint-0.4.4' into release-0.4.4George Kadianakis
2020-08-12Merge remote-tracking branch 'tor-gitlab/mr/104' into maint-0.4.4George Kadianakis
2020-08-11Lower the minimum value for MaxMemInQueues to 64 MB for relays.Nick Mathewson
For clients, there is no minimum value; in both cases, we warn if the value seems too low. Closes ticket 24308.
2020-08-11Merge branch 'maint-0.4.4' into release-0.4.4Nick Mathewson
2020-08-11Merge remote-tracking branch 'tor-gitlab/mr/119' into maint-0.4.4Nick Mathewson
2020-08-11Merge branch 'maint-0.4.4' into release-0.4.4Nick Mathewson
2020-08-11Fix "run_check_subsystem_order.sh" to use $PYTHON.Nick Mathewson
Previously it just used /usr/bin/env/python, which would fail if we only had a "python3" binary. Fixes bug 40095; bugfix on 0.4.4.1-alpha.
2020-08-11Merge branch 'maint-0.4.4' into release-0.4.4George Kadianakis
2020-08-11Merge remote-tracking branch 'tor-gitlab/mr/102' into maint-0.4.4George Kadianakis
2020-08-11Remove a BUG() that could normally trigger in edge-cases.George Kadianakis
2020-08-04Merge branch 'bug40083_035' into bug40083_042Nick Mathewson
Fixes conflicts due to code movement.
2020-08-04Launch early reachability tests once a minute, not once a second.Nick Mathewson
This fixes bug 40083, which was introduced in 9f31908a in 0.2.8.1-alpha.
2020-08-03Merge branch 'ticket40081_035' into ticket40081_044Nick Mathewson
Resolves conflicts: src/core/or/channel.c src/test/test_channel.c
2020-08-03Remove channel_is_canonical_is_reliable()Nick Mathewson
This function once served to let circuits continue to be built over version-1 link connections. But such connections are long-obsolete, and it's time to remove this check. Closes #40081.
2020-08-03Wipe address strings from connections before freeing them them.Nick Mathewson
This is a defense-in-depth fix; closes 6198.
2020-08-03Merge branch 'maint-0.4.4' into release-0.4.4George Kadianakis
2020-08-03Merge remote-tracking branch 'tor-gitlab/mr/79' into maint-0.4.4George Kadianakis
2020-07-31Merge branch 'maint-0.4.2' into maint-0.4.3Alexander Færøy
2020-07-31Merge branch 'maint-0.3.5' into maint-0.4.2Alexander Færøy
2020-07-31Merge branch 'maint-0.4.4' into release-0.4.4Alexander Færøy
2020-07-30Merge branch 'bug40076_043' into bug40076_044Nick Mathewson
2020-07-30Merge branch 'bug40076_042' into bug40076_043Nick Mathewson
2020-07-30Merge branch 'maint-0.4.2' into bug40076_042Nick Mathewson
2020-07-30Fix a bug in buf_move_all() when the input buffer is empty.Nick Mathewson
We found this in #40076, after we started using buf_move_all() in more places. Fixes bug #40076; bugfix on 0.3.3.1-alpha. As far as I know, the crash only affects master, but I think this warrants a backport, "just in case".
2020-07-29Merge branch 'maint-0.4.4' into release-0.4.4Nick Mathewson
2020-07-29Merge branch 'maint-0.4.2' into maint-0.4.3Nick Mathewson
2020-07-29Merge branch 'maint-0.3.5' into maint-0.4.2Nick Mathewson
7apu2bq3rhoylwmucxizk54afw5jyda7pho4j5zdcqpwkufke7zdzwad.onion