summaryrefslogtreecommitdiff
path: root/changes
AgeCommit message (Collapse)Author
2012-10-23Fix a remotely triggerable assertion failure (CVE-2012-2250)Nick Mathewson
If we completed the handshake for the v2 link protocol but wound up negotiating the wong protocol version, we'd become so confused about what part of the handshake we were in that we'd promptly die with an assertion. This is a fix for CVE-2012-2250; it's a bugfix on 0.2.3.6-alpha. All servers running that version or later should really upgrade. Bug and fix from "some guy from France." I tweaked his code slightly to make it log the IP of the offending node.
2012-10-23Merge remote-tracking branch 'origin/maint-0.2.2' into maint-0.2.3Nick Mathewson
2012-10-23Add a changes file for bug 7191.Nick Mathewson
2012-10-23Let 0.2.3 clients exit to internal addresses if they wantRoger Dingledine
Clients now consider the ClientRejectInternalAddresses config option when using a microdescriptor consensus stanza to decide whether an exit relay would allow exiting to an internal address. Fixes bug 7190; bugfix on 0.2.3.1-alpha.
2012-10-23Fix parse_short_policy (bug 7192.)Nick Mathewson
Our implementation of parse_short_policy was screwed up: it would ignore the last character of every short policy. Obviously, that's broken. This patch fixes the busted behavior, and adds a bunch of unit tests to make sure the rest of that function is okay. Fixes bug 7192; fix on 0.2.3.1-alpha.
2012-10-19Merge branch 'block_renegotiate_023' into maint-0.2.3Nick Mathewson
2012-10-19Don't serve or accept v2 HS descs over a DirPortRobert Ransom
(changes file tweaked by nickm)
2012-10-19Merge remote-tracking branch 'origin/maint-0.2.2' into maint-0.2.3Nick Mathewson
2012-10-19Disable TLS Session Tickets, which we were apparently getting for freeNick Mathewson
OpenSSL 1.0.0 added an implementation of TLS session tickets, a "feature" that let session resumption occur without server-side state by giving clients an encrypted "ticket" that the client could present later to get the session going again with the same keys as before. OpenSSL was giving the keys to decrypt these tickets the lifetime of the SSL contexts, which would have been terrible for PFS if we had long-lived SSL contexts. Fortunately, we don't. Still, it's pretty bad. We should also drop these, since our use of the extension stands out with our non-use of session cacheing. Found by nextgens. Bugfix on all versions of Tor when built with openssl 1.0.0 or later. Fixes bug 7139.
2012-10-17Discard extraneous renegotiation attempts in the v3 link protocolNick Mathewson
Failure to do so left us open to a remotely triggerable assertion failure. Fixes CVE-2012-2249; bugfix on 0.2.3.6-alpha. Reported by "some guy from France".
2012-10-09Don't call fmt_addr() twice in a parameter list.George Kadianakis
2012-10-04Merge remote-tracking branch 'arma/bug7037' into maint-0.2.3Nick Mathewson
2012-10-03Refuse extra create cells with reason "resource limit"Roger Dingledine
In the past we had used reason "internal", which is more vague than it needs to be. Resolves bug 7037.
2012-10-03properly free the return values of rate_limit_log()Roger Dingledine
resolves bug 7022.
2012-09-22add faravahar as our ninth v3 dir authRoger Dingledine
2012-09-19Clarify that hidden services are TCP onlyNick Mathewson
Also remove some trailing whitespace. Patch from maker; fixes bug 6024.
2012-09-17Bug 6866: Convert pathbias asserts into log messages.Mike Perry
Asserts were hit by Tor2Web mode.
2012-09-14Use file-size-fixup code on cygwin too.Nick Mathewson
We already had code on windows to fix our file sizes when we're reading a file in text mode and its size doesn't match the size from fstat. But that code was only enabled when _WIN32 was defined, and Cygwin defines __CYGWIN__ instead. Fixes bug 6844; bugfix on 0.1.2.7-alpha.
2012-09-13mention the bug number in the 6827 changes fileNick Mathewson
2012-09-13Avoid undefined behaviour when parsing HS protocol versionsRobert Ransom
Fixes bug 6827; bugfix on c58675ca728f12b42f65e5b8964ae695c2e0ec2d (when the v2 HS desc parser was implemented). Found by asn.
2012-09-12Revert "6819: typo in torrc.sample.in"Nick Mathewson
This reverts commit 4aff97cfc7965414ad8506ce28a296da1bc4a161. We don't actually want to be changing the torrc.sample on stable or near-stable stuff, since doing so makes pointless busywork for debian users.
2012-09-12Merge remote-tracking branch 'public/bug6341_a_v2' into maint-0.2.3Nick Mathewson
2012-09-126819: typo in torrc.sample.inNick Mathewson
2012-09-11Merge remote-tracking branch 'origin/maint-0.2.2' into maint-0.2.3Nick Mathewson
Conflicts: src/test/test_util.c
2012-09-11Fix assertion failure in tor_timegm.Nick Mathewson
Fixes bug 6811.
2012-09-10Avoid segfault when reading state file from ancient torNick Mathewson
If s_values is null in rep_hist_load_bwhist_state_section, we would call smartlist_len() on it, and die. Fixes bug 6801.
2012-09-05Avoid segfault if EntryGuardPathBias precedes EntryGuardNick Mathewson
Fix for bug 6774; bugfix on 0.2.3.17-beta.
2012-09-01Make begindir_cutoff the same as general_cutoffRoger Dingledine
Allow one-hop directory fetching circuits the full "circuit build timeout" period, rather than just half of it, before failing them and marking the relay down. This fix should help reduce cases where clients declare relays (or worse, bridges) unreachable because the TLS handshake takes a few seconds to complete. Fixes bug 6743 (one piece of bug 3443); bugfix on 0.2.2.2-alpha, where we changed the timeout from a static 30 seconds.
2012-08-31Merge branch 'bug6732' into maint-0.2.3Nick Mathewson
2012-08-31Document consensus and microdesc filesNick Mathewson
Bugfix for #6732.
2012-08-27Quiet "Set buildtimeout to low val" warnings: make them infoNick Mathewson
Fix for #6251
2012-08-27Downgrade path-bias warning messages to INFO for now.Nick Mathewson
We've had over two months to fix them, and didn't. Now we need 0.2.3.x stable. Yes, it would be cool to get this working in 0.2.3.x, but not at the expense of delaying every other feature that _does_ work in 0.2.3.x. We can do a real fix in 0.2.4.
2012-08-27Merge branch 'bug6710_023' into maint-0.2.3Nick Mathewson
2012-08-27Merge remote-tracking branch 'origin/maint-0.2.2' into maint-0.2.3Nick Mathewson
Conflicts: src/or/policies.c
2012-08-27Fix changes file for 6710: before 0.0.8pre1, you couldn't extend toNick Mathewson
a router that another router wasn't already connected to.
2012-08-27Do not assert when comparing a null address/port against a policyNick Mathewson
This can create a remote crash opportunity for/against directory authorities.
2012-08-27Disable extending to private/internal addresses by defaultNick Mathewson
This is important, since otherwise an attacker can use timing info to probe the internal network. Also, add an option (ExtendAllowPrivateAddresses) so that TestingTorNetwork won't break. Fix for bug 6710; bugfix on all released versions of Tor.
2012-08-24Merge remote-tracking branch 'public/bug6472' into maint-0.2.3Nick Mathewson
2012-08-21Merge remote-tracking branch 'public/bug6404' into maint-0.2.3Nick Mathewson
2012-08-17When iterating over connections pending DNS, skip marked onesNick Mathewson
Failure to do this would lead to double-free cases and similar, especially when the exit's DNS was broken. See bug 6472 for full details; this is a fix for 6472. Anonymous patch from "cypherpunks" on trac.
2012-08-17Consider IPv6 OR ports when deciding whether a routerinfo change is cosmetic.Linus Nordberg
Closes #6423.
2012-08-17Merge branch 'bug6379' into maint-0.2.3Nick Mathewson
2012-08-17Merge remote-tracking branch 'public/bug6244_part_c' into maint-0.2.3Nick Mathewson
2012-08-17Merge remote-tracking branch 'public/bug6507' into maint-0.2.3Nick Mathewson
2012-08-17Merge remote-tracking branch 'mikeperry/bug6475' into maint-0.2.3Nick Mathewson
2012-08-17Merge remote-tracking branch 'public/bug6514' into maint-0.2.3Nick Mathewson
2012-08-16Address Nick's comments from code review.Mike Perry
Also promote log messages to notice and rate-limit them.
2012-08-15Fix warnings and 64-bit problems in openbsd-malloc codeNick Mathewson
The warning fixes are: - Only define issetugid if it's missing. - Explicitly ignore the return value of writev. - Explicitly cast the retval of readlink() to int. The 64-bit problems are related to just storing a size_t in an int. Not cool! Use a size_t instead. Fix for bug 6379. Bugfix on 0.2.0.20-rc, which introduced openbsd-malloc.
2012-08-15Fix wildcarded address mappings from the control portNick Mathewson
Apparently, we weren't actually detecting wildcardedness when parsing them: whoops! bug 6244. Bugfix on 0.2.3.9-alpha
2012-08-14Update description of what we did to upper limit on md sizeNick Mathewson
Spotted by asn