Age | Commit message (Collapse) | Author | |
---|---|---|---|
2017-10-23 | Merge branch 'maint-0.2.5' into maint-0.2.8 | Nick Mathewson | |
2017-10-23 | dirauth: Add bastet to the default authorities | David Goulet | |
Fixes #23910 Based on a patch by dgoulet; backported to 0.2.5 | |||
2017-10-23 | Merge branch 'maint-0.2.5' into maint-0.2.8 | Nick Mathewson | |
2017-10-23 | Merge remote-tracking branch 'public/bug23690_028' into maint-0.2.8 | Nick Mathewson | |
2017-10-17 | Update Longclaw's IP address; fixes 23592. | Nick Mathewson | |
2017-10-05 | Merge branch 'maint-0.2.5' into maint-0.2.8 | Nick Mathewson | |
2017-10-05 | add missing subcategory in changes file | Nick Mathewson | |
2017-10-05 | Merge branch 'maint-0.2.5' into maint-0.2.8 | Nick Mathewson | |
2017-10-05 | Update geoip and geoip6 to the October 4 2017 database. | Karsten Loesing | |
2017-09-29 | Clear outbuf_flushlen when we clear a connection's outbuf | Nick Mathewson | |
When we added single_conn_free_bytes(), we cleared the outbuf on a connection without setting outbuf_flushlen() to 0. This could cause an assertion failure later on in flush_buf(). Fixes bug 23690; bugfix on 0.2.6.1-alpha. | |||
2017-09-20 | Remove longclaw's IPv6 address, as it will soon change | teor | |
Authority IPv6 addresses were originally added in 0.2.8.1-alpha. This leaves 3/8 directory authorities with IPv6 addresses, but there are also 52 fallback directory mirrors with IPv6 addresses. Resolves 19760. | |||
2017-09-18 | Fix log-uninitialized-stack bug in rend_service_intro_established. | Nick Mathewson | |
Fixes bug 23490; bugfix on 0.2.7.2-alpha. TROVE-2017-008 CVE-2017-0380 | |||
2017-09-07 | Merge branch 'maint-0.2.5' into maint-0.2.8 | Nick Mathewson | |
2017-09-07 | Update geoip and geoip6 to the September 6 2017 database. | Karsten Loesing | |
2017-08-03 | Merge branch 'maint-0.2.5' into maint-0.2.8 | Nick Mathewson | |
2017-08-03 | Update geoip and geoip6 to the August 3 2017 database. | Karsten Loesing | |
2017-08-01 | Merge branch 'maint-0.2.7-redux' into maint-0.2.8 | Nick Mathewson | |
2017-08-01 | Merge branch 'maint-0.2.6' into maint-0.2.7-reduxmaint-0.2.7-redux | Nick Mathewson | |
2017-08-01 | Merge branch 'maint-0.2.5' into maint-0.2.6maint-0.2.6 | Nick Mathewson | |
2017-08-01 | Merge branch 'maint-0.2.4' into maint-0.2.5 | Nick Mathewson | |
2017-08-01 | Merge remote-tracking branch 'karsten/geoip-jul2017' into maint-0.2.4maint-0.2.4 | Nick Mathewson | |
2017-07-26 | Merge branch 'maint-0.2.7-redux' into maint-0.2.8 | Nick Mathewson | |
2017-07-26 | Merge branch 'maint-0.2.6' into maint-0.2.7-redux | Nick Mathewson | |
2017-07-26 | Merge branch 'maint-0.2.5' into maint-0.2.6 | Nick Mathewson | |
2017-07-26 | Merge branch 'maint-0.2.4' into maint-0.2.5 | Nick Mathewson | |
2017-07-17 | Add a changes file for bug22636. | Isis Lovecruft | |
2017-07-07 | Merge branch 'bug22838_028' into maint-0.2.8 | Nick Mathewson | |
2017-07-07 | mingw fix: avoid "unused var" warning. | Nick Mathewson | |
This is a backport of 19615bce64cd381a925bc3910120ac39ca918e7c to fix bug 22838. | |||
2017-07-07 | Merge branch 'maint-0.2.6' into maint-0.2.7-redux | Nick Mathewson | |
2017-07-07 | Merge branch 'maint-0.2.5' into maint-0.2.6 | Nick Mathewson | |
2017-07-07 | Merge branch 'maint-0.2.4' into maint-0.2.5 | Nick Mathewson | |
2017-07-07 | Merge branch 'maint-0.2.7-redux' into maint-0.2.8 | Nick Mathewson | |
2017-07-07 | Mention TROVE-2017-007 in changes file for 22789 | Nick Mathewson | |
2017-07-07 | Update geoip and geoip6 to the July 4 2017 database. | Karsten Loesing | |
2017-07-05 | Merge branch 'maint-0.2.7-redux' into maint-0.2.8 | Nick Mathewson | |
2017-07-05 | Merge branch 'maint-0.2.6' into maint-0.2.7-redux | Nick Mathewson | |
2017-07-05 | Merge branch 'maint-0.2.5' into maint-0.2.6 | Nick Mathewson | |
2017-07-05 | Merge branch 'maint-0.2.4' into maint-0.2.5 | Nick Mathewson | |
2017-07-03 | Fix assertion failure related to openbsd strtol(). | Nick Mathewson | |
Fixes bug 22789; bugfix on 0.2.3.8-alpha. | |||
2017-06-27 | Merge branch 'maint-0.2.7-redux' into maint-0.2.8 | Nick Mathewson | |
2017-06-27 | Merge branch 'maint-0.2.6' into maint-0.2.7-redux | Nick Mathewson | |
2017-06-27 | Merge branch 'maint-0.2.5' into maint-0.2.6 | Nick Mathewson | |
2017-06-27 | Merge branch 'maint-0.2.4' into maint-0.2.5 | Nick Mathewson | |
2017-06-27 | Fix an errant memset() into the middle of a struct in cell_pack(). | Nick Mathewson | |
This mistake causes two possible bugs. I believe they are both harmless IRL. BUG 1: memory stomping When we call the memset, we are overwriting two 0 bytes past the end of packed_cell_t.body. But I think that's harmless in practice, because the definition of packed_cell_t is: // ... typedef struct packed_cell_t { TOR_SIMPLEQ_ENTRY(packed_cell_t) next; char body[CELL_MAX_NETWORK_SIZE]; uint32_t inserted_time; } packed_cell_t; So we will overwrite either two bytes of inserted_time, or two bytes of padding, depending on how the platform handles alignment. If we're overwriting padding, that's safe. If we are overwriting the inserted_time field, that's also safe: In every case where we call cell_pack() from connection_or.c, we ignore the inserted_time field. When we call cell_pack() from relay.c, we don't set or use inserted_time until right after we have called cell_pack(). SO I believe we're safe in that case too. BUG 2: memory exposure The original reason for this memset was to avoid the possibility of accidentally leaking uninitialized ram to the network. Now remember, if wide_circ_ids is false on a connection, we shouldn't actually be sending more than 512 bytes of packed_cell_t.body, so these two bytes can only leak to the network if there is another bug somewhere else in the code that sends more data than is correct. Fortunately, in relay.c, where we allocate packed_cell_t in packed_cell_new() , we allocate it with tor_malloc_zero(), which clears the RAM, right before we call cell_pack. So those packed_cell_t.body bytes can't leak any information. That leaves the two calls to cell_pack() in connection_or.c, which use stack-alocated packed_cell_t instances. In or_handshake_state_record_cell(), we pass the cell's contents to crypto_digest_add_bytes(). When we do so, we get the number of bytes to pass using the same setting of wide_circ_ids as we passed to cell_pack(). So I believe that's safe. In connection_or_write_cell_to_buf(), we also use the same setting of wide_circ_ids in both calls. So I believe that's safe too. I introduced this bug with 1c0e87f6d8c7a0abdadf1b5cd9082c10abc7f4e2 back in 0.2.4.11-alpha; it is bug 22737 and CID 1401591 | |||
2017-06-09 | Merge branch 'maint-0.2.7-redux' into maint-0.2.8 | Nick Mathewson | |
2017-06-09 | Merge branch 'maint-0.2.6' into maint-0.2.7-redux | Nick Mathewson | |
2017-06-09 | Merge branch 'maint-0.2.5' into maint-0.2.6 | Nick Mathewson | |
2017-06-09 | Merge branch 'maint-0.2.4' into maint-0.2.5 | Nick Mathewson | |
2017-06-09 | Update geoip and geoip6 to the June 8 2017 database. | Karsten Loesing | |
2017-06-08 | Merge branch 'maint-0.2.7-redux' into maint-0.2.8 | Nick Mathewson | |