summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-02-20Merge branch 'maint-0.4.3'Nick Mathewson
2020-02-20Merge remote-tracking branch 'tor-github/pr/1719/head' into maint-0.4.3Nick Mathewson
2020-02-20Move router_reset_reachability() into correct header, add a stubNick Mathewson
Without this, -O0 builds fail, which is a sign that LTO builds may fail too.
2020-02-20run "make autostyle"Nick Mathewson
2020-02-20Merge branch 'ticket4631_squashed'Nick Mathewson
2020-02-20dirvote: Improve the posted vote log messageteor
Cleanup after 4631.
2020-02-19fix typo from 7920fc35Roger Dingledine
2020-02-19Merge branch 'extract_relay_dns'Nick Mathewson
2020-02-19Merge branch 'extract_ext_orport'Nick Mathewson
2020-02-19Make dns_cancel_pending_resolve() STATIC.Nick Mathewson
It is not called by anything outside of the tests and dns.c.
2020-02-19Remove assert_all_pending_dns_resolves_ok().Nick Mathewson
It hasn't been used since 2009.
2020-02-19dns.h: label functions that are only used inside feature/relayNick Mathewson
2020-02-19Note module-local functions in ext_orport.hNick Mathewson
Since these are only used inside the feature/relay module, they don't need stubs.
2020-02-19Make connection_or_get_by_ext_or_id() testing-onlyNick Mathewson
Apparently it is only used by the unit tests: tor doesn't want it at all. I've opened a new ticket (33383) to we if we should remove this whole feature.
2020-02-19Merge branch 'extract_selftest'Nick Mathewson
2020-02-19Merge remote-tracking branch 'tor-github/pr/1756/head'Nick Mathewson
2020-02-19Merge remote-tracking branch 'tor-github/pr/1755/head'Nick Mathewson
2020-02-19dirvote: Remove an incorrect log messageteor
Cleanup after 4631.
2020-02-19Merge remote-tracking branch 'tor-github/pr/1744'teor
2020-02-19Makefile: Tweak the test-network* chuttney networksteor
In "make test-network", add tests for single onion services v2 and v3. In "make test-network-all", test onion services v2 and v3 in the same network. Part of 33334.
2020-02-19Run "practracker --regen-overbroad"teor
Closes ticket 33373.
2020-02-18changes file for ticket 33275Taylor Yu
2020-02-18manpage: Add a missing out-of-order commentTaylor Yu
2020-02-18Merge branch 'tor-github/pr/1746'David Goulet
2020-02-18Small changes to scheduler comments and state changesSteven Engler
Tries to make some of the comments in scheduler.c easier to follow, and simplifies a couple of the scheduler channel state changes.
2020-02-18Do not build selftest.c when running relay mode is disabled.Nick Mathewson
2020-02-18Make ext_orport.c relay-mode-only.Nick Mathewson
2020-02-18Move ext_orport identifier map into ext_orport.cNick Mathewson
There's no need to move the declarations: those were already in ext_orport.h. This shrinks connection_or.c a little.
2020-02-18Move some declarations into proto_ext_or.hNick Mathewson
They are for functions declared in that file.
2020-02-18Make sure callers can handle NULL ext-or auth cookie filenameNick Mathewson
2020-02-18Disable dns.c when relay mode is disabled.Nick Mathewson
This saves about 1% for me on a binary compiled without relay mode. Closes ticket 33366.
2020-02-18Move DNS TTL manipulation code to src/core/orNick Mathewson
This removes a dependency from the client code on feature/relay.
2020-02-18Replace identifiers related to clipping DNS ttls.Nick Mathewson
This is an automated commit, generated by this command: ./scripts/maint/rename_c_identifier.py \ MIN_DNS_TTL_AT_EXIT MIN_DNS_TTL \ MAX_DNS_TTL_AT_EXIT MAX_DNS_TTL \ dns_clip_ttl clip_dns_ttl
2020-02-18Merge branch 'tor-github/pr/1743'David Goulet
2020-02-18lintChanges: Tolerate variants that sortChanges knows how to clean up.Nick Mathewson
2020-02-18Merge branch 'tor-github/pr/1740'David Goulet
2020-02-18dirauth: Update disabled dirvote_add_vote()teor
Update the function that handles directory authority votes when the dirauth module is disabled. Part of 4631.
2020-02-18changes: file for 4631teor
2020-02-18dirauth: Refactor dirvote_add_vote()teor
Refactor dirvote_add_vote() by splitting some code out into static functions. Cleanup after 4631.
2020-02-18test/dir: Add specific tests for late vote rejectionteor
Part of 4631.
2020-02-18test/dir: Update the tests for late vote rejectionteor
Part of 4631.
2020-02-18Don't accept posted votes after :52:30Roger Dingledine
If we receive via 'post' a vote from a dir auth after the fetch_missing_votes cutoff, that means we didn't get it by the time we begin the "fetching missing votes from everybody else" phase, which means it is very likely to cause a consensus split if we count it. Instead, we reject it. But we still allow votes that we fetch ourselves after that cutoff. This is a demo branch for making progress on #4631. I've been running it on moria1 and it catches and handles real buggy behavior from directory authorities, e.g. Jan 28 15:59:50.804 [warn] Rejecting vote from 199.58.81.140 received at 2020-01-28 20:59:50; our cutoff for received votes is 2020-01-28 20:52:30 Jan 28 15:59:50.805 [warn] Rejected vote from 199.58.81.140 ("Vote received too late, would be dangerous to count it"). Jan 29 01:52:52.667 [warn] Rejecting vote from 204.13.164.118 received at 2020-01-29 06:52:52; our cutoff for received votes is 2020-01-29 06:52:30 Jan 29 01:52:52.669 [warn] Rejected vote from 204.13.164.118 ("Vote received too late, would be dangerous to count it"). Jan 29 04:53:26.323 [warn] Rejecting vote from 204.13.164.118 received at 2020-01-29 09:53:26; our cutoff for received votes is 2020-01-29 09:52:30 Jan 29 04:53:26.326 [warn] Rejected vote from 204.13.164.118 ("Vote received too late, would be dangerous to count it").
2020-02-17Revised and incorportaed comments from #33275swati
2020-02-17Makefile: Silence some submake logs in test-networkteor
These logs split up the chutney SKIP, PASS, and FAIL messages, and they don't actually contain any useful information. Cleanup after 33334.
2020-02-17Makefile: Add an IPv6 mixed chutney networkteor
This network is used in make test-network-all and test-network-ipv6. Closes 33334.
2020-02-17Makefile: Add v3 onion services to the mixed networkteor
This network is used in make test-network-all and test-network-ipv4. Part of 33334.
2020-02-17Makefile: Refactor and tweak test-networkteor
The refactor is simpler, and supports IPv6 mixed networks. The refactor also slightly changes the order of the IPv6 and mixed checks. But it's closer to the original order before 33280. And if all the network lists that need a network type are empty, we don't check if we can run that network type. (And if a network list is empty, we don't say we're going to run an empty list.) Part of 33334.
2020-02-17Merge remote-tracking branch 'tor-github/pr/1731'teor
2020-02-17Makefile: Hide some recursive make logsteor
These logs break up the chutney test output. Part of 33280.
2020-02-17Makefile: Quote test-network variable expansionsteor
Also: * wrap some long lines * replace an instance of "test ... -a ..." with "test ... && test ..." Part of 33280.